From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C32B43CEC8 for ; Tue, 1 Sep 2026 15:58:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788278340; cv=none; b=s7D97aGMCDwa8nlTPPHZXujQuBaCus9uf0AD53xKSuHJ/FYslecH2lmAklZDbc+mDA5wj4iSuQUMqKO8gE75dOx2nrhb5gz4ot+U1rX1VGhRTWbqx4eY2q0xFOQTMramyCesl61o9AxzGzCmiLVyrDXZw8XBnLMxOktDMuVJX5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788278340; c=relaxed/simple; bh=Y25ZfFIxBhDOGUWVEJAecNuMSUqszdMQjw2VjAfHskk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=RIfdP2XqJPo0MXiFmJOaeosFTXSXKJDMImS2ZPXuToguq0FO4TQ5JMPfBUrU/a0R4gtJ5JGVeqSE5cvuv+1sY0RNSsPKb7vMnv2d9kwhUao3EGukbv67FhADYCA29P1pf3E99PVMyIQzybDqpHtgztHRq4vOdwcO9G5c8KC7YIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H2PoN62R; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H2PoN62R" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3965d3d9ab8so3922871a91.3 for ; Tue, 01 Sep 2026 08:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788278338; x=1788883138; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=nHlmQPyMxuK2/4fncYc9lzGccBisveBJQIOdVcUgRoU=; b=H2PoN62R2yug/HNhKMEtqinJsy2Uf1TrQFk9+xY2QXYmXGUmtR/KQ4xSyLmQbqmfQl SmoaCtns2UTrkhzVeCrQzn0NejaaZmMabkAeg3+1lblZBZZal6TvyCorZqWZ/ePoNigS mTDiZ1bY238ioCNfyKksERioTDgafJdXQdTIXw9EvIbcu4DbXU0aIEJnfOS3cnnWEhf3 Gv2Ea5JJPM+ef9+SI7VHdAPXgyVqcOyfGA/qPFmzj0JevjqXA4iOT4Y601zB6Yac33xF iL8viIecvWRgwKlPfZwcqo0sfEPojI/KmeGCBILpfTOOYgDV5MvcHukgIqxHXB50J25U ZOTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788278338; x=1788883138; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nHlmQPyMxuK2/4fncYc9lzGccBisveBJQIOdVcUgRoU=; b=Xd8bHFFiQwmrfthh3EOSmUS1IyUBlDI6DTt4BzDRtSxYrzXaA96WUGig1IBoLT1na8 95Lcjzl6snmIso934yqyyXKCmOGtiO8QAPHtfHM216x0CCDqSmaMcD/ctwKB66jcORiD 3b9KKRuvPFth03hoa0UQMBeVl6dyppaLqJ8THkLqruqgh0LCzn7HCIKL8LlgdhyeCBSr 6TNH80CKxc045G24kcND1nwzb1Jx/ClAn04hEltcaHenL0qcArRLjhqGd4/29Mwh0GLb 7/t8dXspVhYnwpPY2dpKLq/GY2ijZWvG3OgnMwaGF/Lu4WIFO2SZJUejM/3pBzw7gPqp KhAg== X-Forwarded-Encrypted: i=1; AKwUvBxRC+tj3EfESR7Ldt/s8vlowVTAoOwMJNTcthW+a8NJBSnfSNjodDJyphlll2mjaBAAA4nyC37LAKG1qLg=@vger.kernel.org X-Gm-Message-State: AFuF++moCWxFpUtQOPL/kagcduI7oqXaBfFxfyr+2woYg5yEr5zlNcxU mTadiES9qYPbzExsPAT0+3/pjEYWamjNAAJ6XFx9c0QXk/mdAGvAwkon X-Gm-Gg: AYBFou3Gtl6wygi6ARzyIPQ3XH+wjDtrb/s7ho+ydLjCwrUWxKKxeuwIxJx6z5TBBtk cuKjCbhMlZ3wynFJY+fVWmIDwCXs/KSF8prJTQyink95DETEVnanepORaBuf0D7MwooHiYGlcdi dkmEtUCOcLtYKNCJbmNs8t0sOl5wjJvi6o50CTnKEEWpTyTFPCphnqb7zDr9jt/RJCVugYl7YHv 7HT7X/T3bLaMV+ITJEz6QkolB6IGKEMI7j3X8spVI4Z9e74n4JG0hbQRR9JKPKSi3fSGXIvfGGC O02LQg15MQaCmhzhv0fd6JWnPDYhRnrj/hwfibmw13ed7H68uxo+kuhCDjKaTQsxiuM6aOPBk+S RQdSCAxMLSUVL5hZ388pJH3e510Fc1LdaPA5NVneNHbGsl+lPUpIVpt3W3CValNdKfqlcrkaBIF UMgZI02b7AhnfZsyaO2tsYmQ3/03ezve9PTYmlp3UM5fWSYhAhLdPBhWV0CwWkPq5GrAW9ddSUn f/5jPdnuEXZ5g== X-Received: by 2002:a17:90b:5544:b0:398:bd37:6a49 with SMTP id 98e67ed59e1d1-398bd376c65mr31470657a91.12.1788278338408; Tue, 01 Sep 2026 08:58:58 -0700 (PDT) Received: from SGN-LDSENG.tasernet.com ([42.116.29.172]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1430c7a173asm1741874c88.10.2026.09.01.08.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 08:58:58 -0700 (PDT) From: Cong Nguyen To: Guenter Roeck , Simon Guinot Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Cong Nguyen , Sashiko AI review Subject: [PATCH] hwmon: (gpio-fan) return IRQ_HANDLED from the shared alarm IRQ handler Date: Tue, 1 Sep 2026 22:56:48 +0700 Message-Id: <20260901155648.1538876-1-congnt264@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fan_alarm_irq_handler() is IRQF_SHARED but unconditionally returns IRQ_NONE, even though it always schedules work in response. Enough "unhandled" reports on a shared line trips the kernel's spurious- interrupt detection and disables it, taking every device sharing it down too. Return IRQ_HANDLED, matching what the handler actually does. Fixes: d6fe1360f42e ("hwmon: add generic GPIO fan driver") Reported-by: Sashiko AI review Link: https://lore.kernel.org/r/20260830152150.27F5F1F000E9@smtp.kernel.org Assisted-by: Claude:claude-opus-4 Signed-off-by: Cong Nguyen --- drivers/hwmon/gpio-fan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c index 084828e1e281..a55a7ea07fc0 100644 --- a/drivers/hwmon/gpio-fan.c +++ b/drivers/hwmon/gpio-fan.c @@ -67,7 +67,7 @@ static irqreturn_t fan_alarm_irq_handler(int irq, void *dev_id) schedule_work(&fan_data->alarm_work); - return IRQ_NONE; + return IRQ_HANDLED; } static ssize_t fan1_alarm_show(struct device *dev, -- 2.25.1