From: Jakub Kicinski <kuba@kernel.org>
To: "Shengzhuo Wei" <me@cherr.cc>
Cc: "Chris Snook" <chris.snook@gmail.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jeff Garzik" <jeff@garzik.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2] atlx: atl1: cancel reset and link works on remove
Date: Tue, 1 Sep 2026 16:31:48 -0700 [thread overview]
Message-ID: <20260901163148.7b86a53e@kernel.org> (raw)
In-Reply-To: <20260828-atl1-cancel-reset-work-v2-1-1ee8a5ac2f47@cherr.cc>
On Fri, 28 Aug 2026 18:14:58 +0800 Shengzhuo Wei wrote:
> atl1_reset_dev_task is scheduled from the interrupt handler on PCIe
> PHY link down and DMA read/write errors, and link_chg_task can be
> pending from link events. atl1_remove() tears down and frees the
> net_device without cancelling either work, so a work scheduled just
> before unregister_netdev() can run after free_netdev() and touch the
> freed adapter.
>
> Cancel both works before unregistering the net_device, as atl2_remove()
> already does for its reset and link works.
This is not enough to fully fix the issue, please leave this driver
alone.
--
pw-bot: reject
pv-bot: slop
prev parent reply other threads:[~2026-09-01 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 10:14 Shengzhuo Wei
2026-09-01 23:31 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901163148.7b86a53e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@cherr.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®