From: Khalil <khalilst@gmail.com>
To: "Mark Brown" <broonie@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Richard Fitzgerald <rf@opensource.cirrus.com>,
patches@opensource.cirrus.com, Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-spi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Khalil <khalil@rentman.nl>
Subject: [PATCH v3 0/3] Fix CS35L56 amplifier on Intel LPSS SPI with broken ACPI cs-gpios
Date: Tue, 1 Sep 2026 21:26:22 +0200 [thread overview]
Message-ID: <20260901192625.1497791-1-khalil@rentman.nl> (raw)
v3 of the patch series fixing dual CS35L56 amplifiers on HP laptops
with Intel Lunar Lake and broken ACPI cs-gpios.
Changes since v2:
- Rebased onto broonie/spi for-next (commit b00c00f7dc)
- No code changes
Changes since RFC v1 (addressing feedback from Richard Fitzgerald):
- Added DMI quirk table: GPIO CS fixup is now only applied on known
affected platforms (HP EliteBook 8 G1i, board 8D8A), not generically
for all devices with CS > 0.
- Fixed chip select range check: only chip selects outside the
controller's num_chipselect range are fixed up. A NULL cs_gpiods[cs]
within range means "native chip select", not broken.
- Removed ASUS reference (GU605C was fixed by BIOS update).
- Added Patch 1/3 (spi core): __spi_add_device() now preserves preset
cs_gpiod on the device instead of unconditionally overwriting from
ctlr->cs_gpiods. Suggested by Richard Fitzgerald.
- Patch 2/3 (serial-multi-instantiate): Extracted GPIO fixup into a
dedicated helper function with DMI-based quirk table.
- Patch 3/3 (spi-pxa2xx): Handles clock gating on Intel LPSS
controllers when GPIO chip select is active.
Tested on HP EliteBook 8 G1i 16 inch (Intel Core Ultra 7 258V,
Lunar Lake-M) with 2x CS35L56 Rev B0. Both amplifiers probe
successfully, load calibration and tuning, and produce audio.
Related bug reports:
- https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/2131138
- https://bugzilla.kernel.org/show_bug.cgi?id=221064
- https://github.com/thesofproject/linux/issues/5621
Khalil (3):
spi: Preserve preset cs_gpiod in __spi_add_device()
platform/x86: serial-multi-instantiate: Fix SPI chip select on
platforms with incomplete ACPI cs-gpios
spi: pxa2xx: Handle clock gating for GPIO chip select devices
.../platform/x86/serial-multi-instantiate.c | 168 ++++++++++++++++++
drivers/spi/spi-pxa2xx.c | 45 ++++-
drivers/spi/spi.c | 3 +-
3 files changed, 211 insertions(+), 5 deletions(-)
--
2.43.0
next reply other threads:[~2026-09-01 19:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 19:26 Khalil [this message]
2026-09-01 19:26 ` [PATCH v3 1/3] spi: Preserve preset cs_gpiod in __spi_add_device() Khalil
2026-09-01 19:26 ` [PATCH v3 2/3] platform/x86: serial-multi-instantiate: Fix SPI chip select on platforms with incomplete ACPI cs-gpios Khalil
2026-09-16 21:24 ` Juan Jimenez Carrero
2026-09-01 19:26 ` [PATCH v3 3/3] spi: pxa2xx: Handle clock gating for GPIO chip select devices Khalil
2026-09-16 21:24 ` Juan Jimenez Carrero
2026-09-03 9:21 ` [PATCH v3 0/3] Fix CS35L56 amplifier on Intel LPSS SPI with broken ACPI cs-gpios Richard Fitzgerald
2026-09-11 9:10 ` Juan Jimenez Carrero
2026-09-16 21:23 ` Juan Jimenez Carrero
2026-09-17 13:42 ` Richard Fitzgerald
2026-09-18 11:52 ` Juan Jimenez Carrero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901192625.1497791-1-khalil@rentman.nl \
--to=khalilst@gmail.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=hansg@kernel.org \
--cc=haojian.zhuang@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=khalil@rentman.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rf@opensource.cirrus.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®