Re: [PATCH 1/3] usb: octeon-hcd: fix the FIFO-flush timeout computation

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Aug 27, 2026 at 08:57:00PM +0300, Orgad Shaneh wrote:
> cvmx_wait_tx_rx() computes its 100us deadline from
> (u64)octeon_get_clock_rate - the address of the function, not its
> return value; the parentheses have been missing since the
> CVMX_WAIT_FOR_FIELD32 macro became a function. The cast makes it
> compile silently, and the resulting deadline is effectively infinite.
> 
> On a healthy controller the flush bit clears on the first read and
> nothing is noticed. On a controller whose PHY did not come up (for
> example when the reference-clock configuration is wrong for the board),
> txfflsh/rxfflsh never clear and probe spins forever in __delay() -
> observed as a hard hang with a soft-lockup splat on a CN5020 board,
> where the board watchdog then resets the system with no console output.
> 
> Call the function, restoring the 100us timeout the code always
> intended.

Should this series have an Assisted-by: tag?

How did you find and test it?

thanks,

greg k-h