From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mohit Mishra <mishraloopmohit@gmail.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Nikolay Kulikov <nikolayof23@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: convert swing index variables from u8 to int
Date: Tue, 1 Sep 2026 11:43:11 +0200 [thread overview]
Message-ID: <2026090155-cruelness-plus-404c@gregkh> (raw)
In-Reply-To: <20260804170137.20708-1-mishraloopmohit@gmail.com>
On Tue, Aug 04, 2026 at 10:31:37PM +0530, Mohit Mishra wrote:
> In ODM_TxPwrTrackSetPwr_8723B(), Final_OFDM_Swing_Index and
> Final_CCK_Swing_Index are declared as u8. Using u8 for variables involved
> in arithmetic calculations and lower-bound comparisons (<= 0) is unusual
> and triggers static analysis warnings.
What warnings?
> Convert both variables from u8 to int to clean up the variable types,
> aligning with the TODO item to "convert any remaining unusual variable
> types".
u8 is NOT an unusual variable type at all.
thanks,
greg k-h
next prev parent reply other threads:[~2026-09-01 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YOUR-ORIGINAL-MESSAGE-ID>
2026-08-04 17:01 ` Mohit Mishra
2026-09-01 9:43 ` Greg Kroah-Hartman [this message]
2026-09-01 12:51 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026090155-cruelness-plus-404c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mishraloopmohit@gmail.com \
--cc=nikolayof23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®