From: Linus Walleij <linusw@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>,
Daniel Palmer <daniel@thingy.jp>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linusw@kernel.org>
Subject: [PATCH v2 0/5] Modernize the Faraday FOTG210 driver
Date: Wed, 02 Sep 2026 08:11:31 +0200 [thread overview]
Message-ID: <20260902-gemini-usb-fotg2-v2-0-0057408495d8@kernel.org> (raw)
Replace the private FOTG210 EHCI fork with the common EHCI core and
quirks for its shifted or missing registers, integrated transaction
translator, speed reporting, and reset sequence.
This is a late reaction to a comment from Daniel Palmer in 2023:
https://lore.kernel.org/linux-usb/CAFr9PXmVXqAX73VUzAt_M2yPN93in9Y_LHyYcEA1Dfj_m_4ZHA@mail.gmail.com/
The fork was originally made from the v3.7 EHCI core driver. Arguably
this was a bad idea since it copied over 5000 lines of code. Correct the
mistake by using the maintained common implementation.
Also clean up fixed-role initialization, power and resource handling,
UDC lifecycle, and system sleep handling. The binding and Gemini board
updates are split into a separate series.
Tested on the D-Link DIR-685.
Assisted-by: LLM
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
Changes in v2:
- Split the first v1 EHCI core patch into three patches covering port
status registers, port reset and speed hooks, and other quirks.
- Call reset_control_reset() without a redundant optional-reset NULL
check.
- Link to v1: https://patch.msgid.link/20260831-gemini-usb-fotg2-v1-0-8a8ee12c4b32@kernel.org
---
Linus Walleij (5):
usb: ehci: support non-standard port status registers
usb: ehci: add port reset and speed hooks
usb: ehci: support additional controller quirks
usb: fotg210: use the common EHCI core
usb: fotg210-udc: fix endpoint and resource handling
drivers/usb/fotg210/Kconfig | 2 +
drivers/usb/fotg210/fotg210-core.c | 274 +-
drivers/usb/fotg210/fotg210-hcd.c | 5672 +-----------------------------------
drivers/usb/fotg210/fotg210-hcd.h | 689 -----
drivers/usb/fotg210/fotg210-udc.c | 97 +-
drivers/usb/fotg210/fotg210-udc.h | 2 +-
drivers/usb/fotg210/fotg210.h | 26 +-
drivers/usb/host/ehci-dbg.c | 3 +-
drivers/usb/host/ehci-hcd.c | 31 +-
drivers/usb/host/ehci-hub.c | 100 +-
drivers/usb/host/ehci-timer.c | 3 +-
drivers/usb/host/ehci.h | 47 +-
12 files changed, 516 insertions(+), 6430 deletions(-)
---
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
change-id: 20260203-gemini-usb-fotg2-3873e0d9288a
Best regards,
--
Linus Walleij <linusw@kernel.org>
next reply other threads:[~2026-09-02 6:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 6:11 Linus Walleij [this message]
2026-09-02 6:11 ` [PATCH v2 1/5] usb: ehci: support non-standard port status registers Linus Walleij
2026-09-02 14:48 ` Alan Stern
2026-09-02 6:11 ` [PATCH v2 2/5] usb: ehci: add port reset and speed hooks Linus Walleij
2026-09-02 6:11 ` [PATCH v2 3/5] usb: ehci: support additional controller quirks Linus Walleij
2026-09-02 6:11 ` [PATCH v2 4/5] usb: fotg210: use the common EHCI core Linus Walleij
2026-09-02 6:11 ` [PATCH v2 5/5] usb: fotg210-udc: fix endpoint and resource handling Linus Walleij
2026-09-03 11:06 ` [PATCH v2 0/5] Modernize the Faraday FOTG210 driver Daniel Palmer
2026-09-03 19:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902-gemini-usb-fotg2-v2-0-0057408495d8@kernel.org \
--to=linusw@kernel.org \
--cc=daniel@thingy.jp \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®