From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 205D942E8FF; Wed, 2 Sep 2026 10:06:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.86 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788343577; cv=none; b=M4Bdw1B2Zyt9FBy/hkwxk1RdltjBhVb0wBHYNCXHb3zaLnJuc0/CPZK7t92mIviF1Dr49ZWUD+ta+NudBMh7ecLYNIWnq2s/bq6r+sGYs7isl8nemByMCkpEEWMvXfs4uhmXLfd5TAo85tA2zvkN+skJ8NY4R/NAaXeYQCicq7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788343577; c=relaxed/simple; bh=X1j/z9CN+wTMhriDPTHqnbmFUehoyfU/U++SKVe5JAs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=OCPgtxbcETTYEPFpMZ28XQexU7RL2KBSGEZF8CFP2yud9uCWQlDBsLTGDTcwH3D36oitEGI5Mp9rc+fieMR72d3xvlAef00X/mc8tjY8vY74hiJxDiVTnqpHTeBsWoRW3OSg23CkNAsbDtx/Cv9m6sGbEAOokszxaFdH8H/kwHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=RwXREDwd; arc=none smtp.client-ip=91.207.212.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="RwXREDwd" Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6827mgoU3471800; Wed, 2 Sep 2026 10:56:14 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=dk201812; bh=3 HQQ6ejznpGTVXHbseK7zQ5Wjt/QGJZlhcovtlPdsP0=; b=RwXREDwdVYHQzBUh6 +WRxP7WiU88qEUev/oZNM4/vlFcpoqbhYQPlzsj2gf1Lob+DzwTncSSWd9I2weW+ GUf9liZjiYWw6DbkFNV1YZ+RizsRUMAvCIwIHkWQRnC9HLfMm1usSROvwiTMRbuj HFmtMFdOqrrlJchwRtBuBUMdoW1gh/Lz8FQqXzOEol6IyWPIVqn4jo+ZZyNU9qrV p8sAI8zrNzAq6bnYc+ZG4/MVP6eNtVJWKVmgGTDS92ztfnH+NfGXB2+ArJ9q+PyQ vrKEMtU8ZEQqPAP5YumV7dpA4JYPJbP4yapwANozNGK66avH3Cl1AZMvL/zTR/hp gEWcg== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 4gbnpptvvd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Sep 2026 10:56:14 +0100 (BST) Received: from [127.0.1.1] (172.25.128.225) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Wed, 2 Sep 2026 10:56:11 +0100 From: Brajesh Gupta Date: Wed, 2 Sep 2026 15:25:31 +0530 Subject: [PATCH 1/2] drm/imagination: Propagate map failures correctly from pvr_mmu_map_sgl() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20260902-mmu_fix-v1-1-c55a23fb7cab@imgtec.com> References: <20260902-mmu_fix-v1-0-c55a23fb7cab@imgtec.com> In-Reply-To: <20260902-mmu_fix-v1-0-c55a23fb7cab@imgtec.com> To: Alessio Belle , Luigi Santivetti , Frank Binns , Alexandru Dadu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: , , , , Brajesh Gupta X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4763; i=brajesh.gupta@imgtec.com; h=from:subject:message-id; bh=X1j/z9CN+wTMhriDPTHqnbmFUehoyfU/U++SKVe5JAs=; b=owEBbQKS/ZANAwAKAdAmd1l+AvFwAcsmYgBql/K46DsZs0TCg68YM7gkrLgJE/wavjkNfTJL5 8v3wr6xwdGJAjMEAAEKAB0WIQSQIkZAwD1cxcAsz3LQJndZfgLxcAUCapfyuAAKCRDQJndZfgLx cLHLEACXOvQz4N2SgRiMB+Z+1iUd3dIsZBXR5To425XEiZOLFFBcLcW1fct6vURoC08Ql9O7hkI wS4q54XuGBZ4BIWalQVOyhsiY7rdSKp9KxRL4n2XwTxGTA3dDIsFiliDJ+2yg9ghltX9jVr10d8 P3yrX5dfjz/DXlvr88Ha1WnLFysqtdhrqj7DIbu5nrrmcXYflkyYjZfIygUB+vQYcouo8UMRId/ wzt8Iy9m1YPIC+qBfYDsngPDf7CP2mllPe247mjEX1A6Qktv+6SWgrnu5VC8i5DiIaO0Ig51ZQa 1VPaXyiPafUPbNJGC0tnycBZalag/5DWbHHDlBtuxMCiw50faglRO3ApwVcTDpxd7Edsfmrp3XX zLiO+L2TNDv+k6HatGbDDxlzK5wcwOXJnA1iB/d/R7eBbATzwQIwk8nqGtOAJNbt3uXv4JnmKIB jWHk/H0EidQ0DTqbFijPvt/ozXEdaRVFTSTE9dfUN2mUWpSVQg60dUmkya+RTq8kxYLsGQPOmcr JVRzoYNsUtD5YNrcxrr2ATCUON6shpNeA2A4bi5pbdQifmZoVOxtDqRmnkRGhcKrxpyPDtwqbZ+ 7GYeZX6GrfFPdcGAxCZHYKp7pjWAv17VoisLcjjzk/z+z+nT9302sMBD8BWk8DH3p63JkROVGJp oRazZO2ippUj6Aw== X-Developer-Key: i=brajesh.gupta@imgtec.com; a=openpgp; fpr=05BAA300FD5C580EFD3F8D2F073292BAD0D39671 X-Authority-Analysis: v=2.4 cv=CagAdrrl c=1 sm=1 tr=0 ts=6a97f2be cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=HYrZrZQ_E1YA:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=qZQ2PDNLMSdLoqI-hfl9:22 a=r_1tXGB3AAAA:8 a=MA1SxRKIldkD5NN-sdEA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 X-Proofpoint-ORIG-GUID: 15QJ9kprxJcLJR91OWHe74MzYrCEmPjc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAyMDA4MSBTYWx0ZWRfXwy1Wo2AdFFMG xYiP/oS+KTWakca9eYZflHOkc2+myH+xRXFqsVBzJ22qp4+Oj7OY9IZh1cNzOW6qxY9Er5ZK+Q6 gOicANMDWmBiQXBRGwBcUXvYW0F/eDmdGbLOJp/ZiA67w92k8TYHTMjdxMMMbUn0MujSCe3DR+G 5l2fsVH1GcG/R6gDvXtM9IjayOY9G6RPvwYx7nTKL1HwK/9USfDAIBF0rfwUB0olwSAzIEdNFD5 KvjVEy9ZQj3XMOUkr5lAPCVHZUEXE3ofAMOOh+Zb1UYnLF8TNkWDKvsthlYBPwuPVWEq4IHfTDB 3ApH7Tz4p5c0M5dl0WgNfDOWaNBl/fgN1d8WgZ7QrEa+akhM8Lgaa/0iW4myxe24QVwgsII32yF FaCuC9d5AGPuDa5HMPe6KAZ9yHvqRrS/KK5x8znSoYB0E3uOPOuYhsgjKAo3sMzRfh1r6WdIB67 fIPG7wmZGNgudDwOsCw== X-Proofpoint-GUID: 15QJ9kprxJcLJR91OWHe74MzYrCEmPjc X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAyMDA4MSBTYWx0ZWRfX8TPNkAd879SB yN4APpsUKhdWIhPfwPMJRnGJXFJ3UKeIQgRyiDrzEkTMAijtZzC1tF4BrsUQou+HPmwKYMXxxPg qkGhZaDa1eK3eHxZSbpbtQJGUMwLZYE= Map failure from pvr_mmu_map_sgl() interface was not returned correctly to pvr_mmu_map() interface. This resulted in pvr_mmu_map() interface to continue instead of returning an error to caller. Fix it by returning a proper error code from pvr_mmu_map_sgl() interface. Call stack for crash: [ 1179.286237] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008 [ 1179.295067] Mem abort info: [ 1179.297877] ESR = 0x0000000096000004 [ 1179.301656] EC = 0x25: DABT (current EL), IL = 32 bits [ 1179.306987] SET = 0, FnV = 0 [ 1179.310048] EA = 0, S1PTW = 0 [ 1179.313198] FSC = 0x04: level 0 translation fault [ 1179.318096] Data abort info: [ 1179.320993] ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000 [ 1179.326483] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 [ 1179.331546] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [ 1179.336895] user pgtable: 4k pages, 48-bit VAs, pgdp=000000009822a000 [ 1179.343402] [0000000000000008] pgd=0000000000000000, p4d=0000000000000000 [ 1179.350243] Internal error: Oops: 0000000096000004 [#2] SMP [ 1179.355908] Modules linked in: powervr gpu_sched drm_shmem_helper drm_gpuvm drm_exec xhci_plat_hcd xhci_hcd dwc3 usbcore usb_common snd_soc_simple_card snd_soc_simple_card_utils dwc3_am62 at24 sa2ul sha512 libsha512 sha256 authenc sch_fq_codel fuse dm_mod ipv6 [ 1179.378992] CPU: 1 UID: 1000 PID: 680 Comm: deqp-vk Tainted: G D 6.17.0 #1 PREEMPT [ 1179.388120] Tainted: [D]=DIE [ 1179.390994] Hardware name: Texas Instruments AM625 SK (DT) [ 1179.396467] pstate: 00000005 (nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 1179.403415] pc : pvr_mmu_op_context_unmap_curr_page+0x6c/0x134 [powervr] [ 1179.410140] lr : pvr_mmu_op_context_unmap_curr_page+0x58/0x134 [powervr] [ 1179.416848] sp : ffff8000839ab8c0 [ 1179.420153] x29: ffff8000839ab8c0 x28: 0000000000000001 x27: 000000008f386000 [ 1179.427283] x26: ffff000016d1df98 x25: 0000000000247000 x24: 00000000000001e6 [ 1179.434413] x23: 0000000000000002 x22: 000000000000ffff x21: 0000000000000247 [ 1179.441540] x20: 0000000000000245 x19: ffff000016d1df60 x18: 0000000000000002 [ 1179.448668] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000001 [ 1179.455793] x14: 0000000000060810 x13: ffff80007fffffff x12: ffff000004190480 [ 1179.462921] x11: ffff8000853f7000 x10: ffff8000811ae000 x9 : ffff0000041900b8 [ 1179.470051] x8 : 0000000000000000 x7 : 00000000990c4001 x6 : 0000000000000007 [ 1179.477177] x5 : ffff000016d1df60 x4 : 0000000000000000 x3 : ffff00000a7d8000 [ 1179.484306] x2 : 00000000000001ff x1 : 0000000000000000 x0 : 0000000000000000 [ 1179.491433] Call trace: [ 1179.493872] pvr_mmu_op_context_unmap_curr_page+0x6c/0x134 [powervr] (P) [ 1179.500582] pvr_mmu_map+0x31c/0x388 [powervr] [ 1179.505027] pvr_vm_gpuva_map+0x40/0x88 [powervr] [ 1179.509732] __drm_gpuvm_sm_map+0x250/0x44c [drm_gpuvm] [ 1179.514952] drm_gpuvm_sm_map+0x48/0x5c [drm_gpuvm] [ 1179.519822] pvr_vm_bind_op_exec+0x64/0x70 [powervr] [ 1179.524785] pvr_vm_map+0x1f8/0x2a8 [powervr] [ 1179.529142] pvr_ioctl_vm_map+0x12c/0x188 [powervr] [ 1179.534018] drm_ioctl_kernel+0xb8/0x128 [ 1179.537941] drm_ioctl+0x21c/0x4ec [ 1179.541337] __arm64_sys_ioctl+0xac/0x108 [ 1179.545344] invoke_syscall+0x44/0x100 [ 1179.549091] el0_svc_common.constprop.0+0x40/0xe0 [ 1179.553790] do_el0_svc+0x1c/0x28 [ 1179.557106] el0_svc+0x34/0xf0 [ 1179.560159] el0t_64_sync_handler+0xd0/0xe4 [ 1179.564334] el0t_64_sync+0x198/0x19c [ 1179.567996] Code: 54000300 35000360 f9402261 79409a62 (f9400421) [ 1179.574081] ---[ end trace 0000000000000000 ]--- Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code") Signed-off-by: Brajesh Gupta --- drivers/gpu/drm/imagination/pvr_mmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imagination/pvr_mmu.c b/drivers/gpu/drm/imagination/pvr_mmu.c index 3cac482e1034..175f0ba4d993 100644 --- a/drivers/gpu/drm/imagination/pvr_mmu.c +++ b/drivers/gpu/drm/imagination/pvr_mmu.c @@ -12,6 +12,7 @@ #include "pvr_rogue_mmu_defs.h" #include +#include #include #include #include @@ -2553,7 +2554,9 @@ pvr_mmu_map_sgl(struct pvr_mmu_op_context *op_ctx, struct scatterlist *sgl, err_destroy_pages: memcpy(&op_ctx->curr_page, &ptr_copy, sizeof(op_ctx->curr_page)); - err = pvr_mmu_op_context_unmap_curr_page(op_ctx, page); + if (pvr_mmu_op_context_unmap_curr_page(op_ctx, page)) + drm_err(from_pvr_device(op_ctx->mmu_ctx->pvr_dev), "%s : Failure in unmapping pages\n", + __func__); return err; } -- 2.43.0