From: Tal Zussman <tz2294@columbia.edu>
To: Ilya Dryomov <idryomov@gmail.com>,
Alex Markuze <amarkuze@redhat.com>,
Viacheslav Dubeyko <slava@dubeyko.com>,
Christian Brauner <brauner@kernel.org>,
Jeff Layton <jlayton@kernel.org>,
David Howells <dhowells@redhat.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Zi Yan <ziy@nvidia.com>
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Tal Zussman <tz2294@columbia.edu>
Subject: [PATCH v5 07/10] ceph: remove page remnants from write_folio_nounlock()
Date: Wed, 02 Sep 2026 12:11:31 -0400 [thread overview]
Message-ID: <20260902-remove-wait-on-page-writeback-v5-7-0b512e77e75b@columbia.edu> (raw)
In-Reply-To: <20260902-remove-wait-on-page-writeback-v5-0-0b512e77e75b@columbia.edu>
Use ceph_folio_start_fscache() and only use a struct page pointer at the
osd_req_op_extent_osd_data_pages() boundary, which requires a page
array. This removes a call to compound_head() in
ceph_set_page_fscache().
This was the last user of ceph_set_page_fscache(), so remove it.
Signed-off-by: Tal Zussman <tz2294@columbia.edu>
---
fs/ceph/addr.c | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index b0deff481d95..8e761144e8fb 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -563,11 +563,6 @@ static void ceph_folio_start_fscache(struct folio *folio)
folio_start_private_2(folio); /* [DEPRECATED] */
}
-static void ceph_set_page_fscache(struct page *page)
-{
- folio_start_private_2(page_folio(page)); /* [DEPRECATED] */
-}
-
static void ceph_folio_wait_fscache(struct folio *folio)
{
folio_wait_private_2(folio); /* [DEPRECATED] */
@@ -594,10 +589,6 @@ static inline void ceph_folio_start_fscache(struct folio *folio)
{
}
-static inline void ceph_set_page_fscache(struct page *page)
-{
-}
-
static inline void ceph_folio_wait_fscache(struct folio *folio)
{
}
@@ -748,7 +739,7 @@ static u64 get_writepages_data_length(struct inode *inode,
static int write_folio_nounlock(struct folio *folio,
struct writeback_control *wbc)
{
- struct page *page = &folio->page;
+ struct page *page;
struct inode *inode = folio->mapping->host;
struct ceph_inode_info *ci = ceph_inode(inode);
struct ceph_fs_client *fsc = ceph_inode_to_fs_client(inode);
@@ -830,7 +821,7 @@ static int write_folio_nounlock(struct folio *folio,
folio_start_writeback(folio);
if (caching)
- ceph_set_page_fscache(&folio->page);
+ ceph_folio_start_fscache(folio);
ceph_fscache_write_to_cache(inode, page_off, len, caching);
if (IS_ENCRYPTED(inode)) {
@@ -850,9 +841,8 @@ static int write_folio_nounlock(struct folio *folio,
/* it may be a short write due to an object boundary */
WARN_ON_ONCE(len > folio_size(folio));
- osd_req_op_extent_osd_data_pages(req, 0,
- bounce_page ? &bounce_page : &page, wlen, 0,
- false, false);
+ page = bounce_page ? bounce_page : &folio->page;
+ osd_req_op_extent_osd_data_pages(req, 0, &page, wlen, 0, false, false);
doutc(cl, "%llx.%llx %llu~%llu (%llu bytes, %sencrypted)\n",
ceph_vinop(inode), page_off, len, wlen,
IS_ENCRYPTED(inode) ? "" : "not ");
--
2.39.5
next prev parent reply other threads:[~2026-09-02 16:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 16:11 [PATCH v5 00/10] ceph: convert writeback path to folios Tal Zussman
2026-09-02 16:11 ` [PATCH v5 01/10] ceph: fix error handling when the OSD client is stopping in ceph_submit_write() Tal Zussman
2026-09-02 16:11 ` [PATCH v5 02/10] ceph: wait for pending fscache write in write_folio_nounlock() Tal Zussman
2026-09-02 16:11 ` [PATCH v5 03/10] ceph: add ceph_folio_snap_context() Tal Zussman
2026-09-02 16:11 ` [PATCH v5 04/10] ceph: convert ceph_wait_until_current_writes_complete() to folios Tal Zussman
2026-09-02 16:11 ` [PATCH v5 05/10] ceph: convert get_writepages_data_length() " Tal Zussman
2026-09-02 16:11 ` [PATCH v5 06/10] ceph: convert ceph_submit_write() " Tal Zussman
2026-09-02 16:11 ` Tal Zussman [this message]
2026-09-02 16:11 ` [PATCH v5 08/10] ceph: convert page cleanup loop in writepages_finish() " Tal Zussman
2026-09-02 16:11 ` [PATCH v5 09/10] ceph: remove ceph_fscrypt_pagecache_page() and ceph_fscrypt_page_offset() Tal Zussman
2026-09-02 16:11 ` [PATCH v5 10/10] ceph: rename ceph_check_page_before_write() to ceph_check_folio_before_write() Tal Zussman
2026-10-08 16:00 ` [PATCH v5 00/10] ceph: convert writeback path to folios David Howells
2026-10-10 0:16 ` Tal Zussman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902-remove-wait-on-page-writeback-v5-7-0b512e77e75b@columbia.edu \
--to=tz2294@columbia.edu \
--cc=amarkuze@redhat.com \
--cc=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®