mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sanghyun Park <sanghyun.park.cnu@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Sanghyun Park <sanghyun.park.cnu@gmail.com>,
	netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	David Stevens <dlstevens@us.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] vxlan: use one headroom snapshot for neighbour replies
Date: Wed,  2 Sep 2026 15:59:12 +0900	[thread overview]
Message-ID: <20260902065911.1177698-3-sanghyun.park.cnu@gmail.com> (raw)
In-Reply-To: <53a67f9a-b8a0-4967-b2c6-be4ee3a09735@redhat.com>

Thanks for the review, Paolo.

> if you can observe a splat on the unpatched kernel, please include it,
> otherwise please explain why the issue is not just a theoretical one.

I thought it would make the changelog verbose by putting the evidences of the
bugs (some people like concise changelogs).

If you prefer splats in there, let me add some in v2.

It would be like:

```
/* vxlan_na_create() samples ... */

The race is reproducible on the unpatched kernel. It occurred when
vxlan_na_create() generated a neighbour reply while vxlan_changelink() changed
the link headroom. KASAN caught a four-byte write two bytes beyond a 704-byte
skbuff_small_head allocation.

/* Snapshot the headroom once ... */
```

JFYI, every patch I make is done only after I get real evidence :)

> Also please specify if some LLM has been used.

I used LLM assistance during bug discovery, analysis, etc, but try to review
with my eyes as much as I can.


Plz check the new paragraph of the changelog whether it is ok for v2.

Thanks,
Sanghyun

      reply	other threads:[~2026-09-02  7:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31  5:46 Sanghyun Park
2026-09-01 10:10 ` Paolo Abeni
2026-09-02  6:59   ` Sanghyun Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902065911.1177698-3-sanghyun.park.cnu@gmail.com \
    --to=sanghyun.park.cnu@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dlstevens@us.ibm.com \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®