From: Jakub Kicinski <kuba@kernel.org>
To: Vitaliy Sochnev <sochnev.v.74@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Alexander Duyck <alexanderduyck@fb.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
Wei Wang <weiwan@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: yield the CPU on every exit of the threaded NAPI poll loop
Date: Wed, 2 Sep 2026 15:48:36 -0700 [thread overview]
Message-ID: <20260902154836.19a497e5@kernel.org> (raw)
In-Reply-To: <20260902210053.263070-1-sochnev.v.74@gmail.com>
On Wed, 2 Sep 2026 22:00:53 +0100 Vitaliy Sochnev wrote:
> On preemption, raised in v1: same board and load, unpatched, two halves
> differing only in that choice - worst "ip link del" 248.48 s with 8 stalls
> under PREEMPT_NONE against 0.39 s and none under PREEMPT_LAZY. So lazy
> preemption does hide the symptom, and PREEMPT_NONE and PREEMPT_VOLUNTARY
> builds are what is left. It is not the NAPI thread being preempted more -
> nonvoluntary_ctxt_switches on it is 4.6/s under LAZY against 13.9/s under
> PREEMPT_NONE - so that is a measurement, not a mechanism. The missing yield
> is there under either model.
>
> The loop is unchanged in Linus's tree - net/core/dev.c at v7.3-rc1 is
> identical here to net/main. The numbers come from 6.18 because that is the
> only kernel this board runs: mainline carries en7581-evb alone, while the
> SoC dtsi, the board DTS and the airoha_eth changes it needs are still out
> of tree. On 6.18 the loop has no busy_poll_last_qs parameter, but with that
> pointer NULL the two are the same code, so the change under test is this
> one. The busy-poll path is unaffected; cond_resched() was already reached
> there.
Rebase your OOT patches on latest and test the tree you're targeting
or keep this patch in your downstream kernel as well.
next prev parent reply other threads:[~2026-09-02 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 21:00 Vitaliy Sochnev
2026-09-02 22:48 ` Jakub Kicinski [this message]
2026-09-03 23:12 ` Vitaliy Sochnev
2026-09-04 21:23 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902154836.19a497e5@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sochnev.v.74@gmail.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®