From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DCFC4AC170 for ; Wed, 2 Sep 2026 17:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788369762; cv=none; b=pNWfCcDVNcK6Z+MvDAHLMZTj27QrK3tKAYaUFkLkl+9GgB3uDsqbS1+PoRNcnzEmdtl7ewdZ6mua2UVfvyZz50SiGf1O1/JF6Lv40mBCTnoFkl3Eu7upcj6RY0zANXiuWoM25cKrc31GhTuHoXBCbQ8o0lAPXNdXq5VEVCiYvAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788369762; c=relaxed/simple; bh=4XulWumZXqpCfKb3SArb1B6Yum/mNtjYciJqXggO0jo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CI48L3vFu38eEWrXAWuzSSt7bfpRZYFDJrivjIpeafB2cKzg1+uTyXPf32ee5xQ8rKsd9PQUkNX5E2CRtxkuKHtDlJWxM0/gs+kBb5bOBX1t9BEZwtwXaDbsscGMA23Rn9eT9aZse6qjuCk43dVWLn4CZCZssIQ5Yp9EGrcNNeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f7muB3Sy; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f7muB3Sy" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4953e04ef16so12577505e9.2 for ; Wed, 02 Sep 2026 10:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788369759; x=1788974559; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mrl372Fg43b2CyduoRGiy3yZV5K9VIBKnZ3Q5D/PZek=; b=f7muB3SyY8DHNb3BH7P6gDMmOTZSDXM9qtha2dOuXusTTSOTUBD6s/f4gd5anYYUy9 sqrca/j3SZAmTEgthEpeurMhoLSSXK0r0AfDCHsaWhBPSNT3daciZN9+SlIlQlMjFR3W C6FvVyqxaIWuJD6opaaXesKbbnzCfKAvqmntMU5qhYhOmKAn/gkYmFDEIIYK3uXYdVk4 SLj7J7Ft/Du7aOhH9vnPNJGUOj3vPmOImlnuxKEaeoG3LYCN6YhFFiIBO9MhOEnWhBt/ KmFRWb5zpAalTim+mQvuIQ4OLOIr21YQOUrPIeIOqKNjbpyLwEuwSwN079p5eVsUstca HpKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788369759; x=1788974559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mrl372Fg43b2CyduoRGiy3yZV5K9VIBKnZ3Q5D/PZek=; b=j38SVVfmCpxdIuJ/8Xoblwquc4f6uxbu4PzB9vkscYNFQuWWahAsWiGKLWakTPn/iu ekeybfif3f2wNCfhByhHvtgYiW0DH0qCWtQicmun0eC1E0Pq0u7QkfHvGRKwJjjXPvKH x4x/Y3dP2c2y0HlcFEePlpt78rG395gxFvWZ/nVMaG5bJjyMBZUoTMJrDzjtoMPoroNj jebabmzpTyO1mnzFpI0m7gDASlL+KBv/gkH1EHCPdB+q0d9Z3JKiZ3MTAbIrtsutaBHj 2hkmVa/kSpnQOjbUt2f2y89v90TGm4oMJeFL/vwax2IDoWt8CabeCge8tpDU+QbE3zy7 24xA== X-Forwarded-Encrypted: i=1; AHgh+RpK49a7IRAQ/5R8w9Tr/mUy8l1xT0EUWih/s8Wctb4QR3O4bIR8G4EcIC/Mxh2O4q1jJLxoYV9C8JR/F4E=@vger.kernel.org X-Gm-Message-State: AFuF++lxPSkX+wd/1FBm4+tDaIw03knbchkHuoaQ18h2mLrc3CFZNkdH FakYyFMtCOKrBh48nVP+pCRFZwV+PdAec+BXhl25PAzMms+C0bEqTViE X-Gm-Gg: AR+sD13idLQ+/yQ+AaiEbaH1dZ7+ki6bGWPeYPIGgp61DleJSNIWtY9+xhaN1bvJrIm G7WJyog521wZx8aJQZZ9Wh1Gxb0zyb1oBGLkL2IMM2/kEWmH4+NoAOLP7GgSHYq84SOaTLBibtw 6YeOjE4JZpNI9A5+Upe8v0SEGuK1kyinY6Cv0aLdFVwdu601OFS5x4Sn3vdctLVL2Z8Di0qNg74 HY5Ag9mpPSoosy9UKLA9G5hnlZR7TW9ua9LW5SGyxCCuyCZT4kuY5Y8UukLjW7CuVeKahpPF4be jNTE5hY0Nbt6K4haO6PVw2rzUhNbrPJVh87y9Br7cSne52B7TALbF0QRE0W/XOpyYFqvv/Xd0Xj HlXJFfF8MFecQEfG5KFrev6qScqxzAbKWd5kXXkX8Vn52rvhTvj7xmv3pAiQhIU9e+KHHWkyFcW jw5JnVV/JeW7Qy6sFhPIGeSdfqzkQ8H2wgbQnG369LdtxaGRES4IGhUsgJSjcr9seemkE/PYNzo doRcKO/NyKKjLL1VIEAKwqqQozmgWG7KMKkCDD+ X-Received: by 2002:a05:600c:45c4:b0:499:79b9:e220 with SMTP id 5b1f17b1804b1-49ce5816186mr117844465e9.10.1788369759149; Wed, 02 Sep 2026 10:22:39 -0700 (PDT) Received: from flaviu-Aspire-E5-572G.. ([93.122.251.26]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cee6023d6sm5813145e9.8.2026.09.02.10.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 10:22:38 -0700 (PDT) From: Flaviu Nistor To: Jonathan Cameron , David Lechner , Nuno Sa , Andy Shevchenko , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Daniel Baluta , Antoniu Miclaus Cc: Flaviu Nistor , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH v2 2/2] iio: adc: ti-ads1015: Add support for label Date: Wed, 2 Sep 2026 20:22:30 +0300 Message-ID: <20260902172230.5234-2-flaviu.nistor@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260902172230.5234-1-flaviu.nistor@gmail.com> References: <20260902172230.5234-1-flaviu.nistor@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for label sysfs attribute similar to other adc devices. This is particularly useful because the label can match the schematic signal name, identifying channel voltages easier if label is defined via device tree. Signed-off-by: Flaviu Nistor --- Changes in v2: - Implement changes suggested by Andy Shevchenko. - Link to v1: https://lore.kernel.org/all/20260901184302.8127-2-flaviu.nistor@gmail.com/ drivers/iio/adc/ti-ads1015.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index 0fbfa4e499aa..8be1f0c32ca9 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -233,6 +233,7 @@ static const struct iio_event_spec ads1015_events[] = { struct ads1015_channel_data { unsigned int pga; unsigned int data_rate; + const char *label; }; struct ads1015_thresh_data { @@ -586,6 +587,15 @@ static int ads1015_read_raw(struct iio_dev *indio_dev, } } +static int ads1015_read_label(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, char *label) +{ + struct ads1015_data *data = iio_priv(indio_dev); + const char *name = data->channel_data[chan->address].label; + + return sysfs_emit(label, "%s\n", name); +} + static int ads1015_write_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int val, int val2, long mask) @@ -843,6 +853,7 @@ static const struct iio_buffer_setup_ops ads1015_buffer_setup_ops = { static const struct iio_info ads1015_info = { .read_avail = ads1015_read_avail, .read_raw = ads1015_read_raw, + .read_label = ads1015_read_label, .write_raw = ads1015_write_raw, .read_event_value = ads1015_read_event, .write_event_value = ads1015_write_event, @@ -853,6 +864,7 @@ static const struct iio_info ads1015_info = { static const struct iio_info tla2024_info = { .read_avail = ads1015_read_avail, .read_raw = ads1015_read_raw, + .read_label = ads1015_read_label, .write_raw = ads1015_write_raw, }; @@ -861,7 +873,9 @@ static int ads1015_client_get_channels_config(struct i2c_client *client) struct iio_dev *indio_dev = i2c_get_clientdata(client); struct ads1015_data *data = iio_priv(indio_dev); struct device *dev = &client->dev; + const char *label; int i = -1; + int ret; device_for_each_child_node_scoped(dev, node) { u32 pval; @@ -897,6 +911,17 @@ static int ads1015_client_get_channels_config(struct i2c_client *client) } } + if (fwnode_property_present(node, "label")) { + ret = fwnode_property_read_string(node, "label", &label); + if (ret) { + dev_err(dev, "invalid label on %pfw\n", node); + return ret; + } + data->channel_data[channel].label = label; + } else { + data->channel_data[channel].label = ""; + } + data->channel_data[channel].pga = pga; data->channel_data[channel].data_rate = data_rate; -- 2.34.1