From: Andrew Morton <akpm@linux-foundation.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] scripts/checkstack.pl: support llvm-objdump disassembly for x86
Date: Wed, 2 Sep 2026 17:51:54 -0700 [thread overview]
Message-ID: <20260902175154.14870f981733146727c67c20@linux-foundation.org> (raw)
In-Reply-To: <20260902-checkstack_llvm_objdump-v1-1-edb4eca5f163@google.com>
On Wed, 02 Sep 2026 14:01:53 -0700 Nick Desaulniers <ndesaulniers@google.com> wrote:
> When running `make LLVM=1 checkstack`, OBJDUMP is set to llvm-objdump.
> llvm-objdump outputs disassembly with instruction size suffixes (such as
> subq/addq/subl/addl), tabs/whitespace differences, spaces after commas,
> and trailing comments (e.g. `# imm = 0x...`).
>
> Because scripts/checkstack.pl used rigid regular expressions specifically
> tuned to GNU objdump format (e.g. requiring exactly four spaces, no
> suffix, and no space after comma), checkstack.pl failed to match any
> stack adjustment instructions and yielded no output when using
> llvm-objdump on x86.
>
> Update the regular expressions for x86 to match optional suffixes,
> variable whitespace, and trailing comments.
OK, so checkstack is broken with LLVM.
Users of checkstack/LLVM in earlier kernels won't like that, so
should we backport this with cc:stable?
next prev parent reply other threads:[~2026-09-03 0:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 21:01 Nick Desaulniers
2026-09-03 0:51 ` Andrew Morton [this message]
2026-09-03 16:17 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902175154.14870f981733146727c67c20@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®