From: Justin Vargas <justinyvar@gmail.com>
To: jlee@suse.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: W_Armin@gmx.de, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Justin Vargas <justinyvar@gmail.com>
Subject: [PATCH] platform/x86: acer-wmi: Remove unused platform_profile_support variable
Date: Wed, 2 Sep 2026 15:30:39 -0400 [thread overview]
Message-ID: <20260902193039.21725-1-justinyvar@gmail.com> (raw)
The platform_profile_support variable is assigned during platform
profile setup but is never read anywhere in the driver. Remove it.
Assisted-by: Claude:claude-opus-5
Signed-off-by: Justin Vargas <justinyvar@gmail.com>
---
Found while reading through the driver. Compile tested only, as this
is a pure dead-code removal.
hp-wmi.c and asus-wmi.c appear to carry the same unused variable -
declared and assigned once, never read. All three were converted to
devm_platform_profile_register() in the same series, which may be where
the last reader went, though my clone is too shallow to confirm that.
Happy to send patches for the other two as well if that is useful; I
left them out here to keep this patch focused on the driver I use.
If the intent was for this variable to be checked somewhere rather than
removed, let me know and I will send that instead.
Disclosure: this patch was produced with the assistance of an AI model
(see the Assisted-by trailer). I have reviewed it and take
responsibility for it as signed off above.
drivers/platform/x86/acer-wmi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 61ae622c93d..528a89c3eed 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -839,7 +839,6 @@ static const struct dmi_system_id non_acer_quirks[] __initconst = {
};
static struct device *platform_profile_device;
-static bool platform_profile_support;
/*
* The profile used before turbo mode. This variable is needed for
@@ -2199,8 +2198,6 @@ static int acer_platform_profile_setup(struct platform_device *device)
&device->dev, "acer-wmi", NULL, &acer_predator_v4_platform_profile_ops);
if (IS_ERR(platform_profile_device))
return PTR_ERR(platform_profile_device);
-
- platform_profile_support = true;
}
return 0;
}
--
2.47.3
reply other threads:[~2026-09-02 19:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902193039.21725-1-justinyvar@gmail.com \
--to=justinyvar@gmail.com \
--cc=W_Armin@gmx.de \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jlee@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®