mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Murphy <christian@themurphys.eu>
To: sakari.ailus@linux.intel.com
Cc: linux-media@vger.kernel.org, hpa@redhat.com, mchehab@kernel.org,
	tarang.raval@siliconsignals.io, jai.luthra@ideasonboard.com,
	linux-kernel@vger.kernel.org, antti.laakso@linux.intel.com
Subject: Re: [PATCH] media: i2c: imx471: Fix pixel rate and line length
Date: Wed,  2 Sep 2026 20:51:14 +0100	[thread overview]
Message-ID: <20260902195114.9983-1-christian@themurphys.eu> (raw)
In-Reply-To: <apVBljHkHhjcodTX@kekkonen.localdomain>

Hi Sakari,

Thanks for the review.

On Mon, Aug 31, 2026 at 11:55:50AM +0300, Sakari Ailus wrote:
> Interestingly, 2328 would appear to be a seemigly valid value.
>
> Cc Antti.

I believe it was inherited from Intel's out-of-tree imx471 driver, which
has the same .llp = 2328 but writes LINE_LENGTH_PCK 2560 in its register
list; the mainline list dropped that write. I didn't try writing 2328,
as it would make the line 6.01 us, below the 12.05 us a 1928-pixel RAW10
line takes on four lanes at 200 MHz. Happy to probe it if that's useful.

> Can you calculate the value instead, please?

Done in v2:
https://lore.kernel.org/linux-media/ede568ada4304d2dc92cd43986fc07aa68628154.1788377269.git.christian@themurphys.eu/

Kind regards,

Christian

      reply	other threads:[~2026-09-02 20:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-30 17:33 Christian Murphy
2026-08-31  8:55 ` Sakari Ailus
2026-09-02 19:51   ` Christian Murphy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902195114.9983-1-christian@themurphys.eu \
    --to=christian@themurphys.eu \
    --cc=antti.laakso@linux.intel.com \
    --cc=hpa@redhat.com \
    --cc=jai.luthra@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tarang.raval@siliconsignals.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®