From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58EA335203D for ; Wed, 2 Sep 2026 20:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788380131; cv=none; b=LAmvQIELhGBOVQOYzGXsHxRqeRGI2w7+O3NNkh2WNd4pruqLdtcupjLuVHIQC9lbeDMT7hNhGPn5XOrpCb4QJfWVVfBTxjW1GR/l2tpi8TFwC1HWbPgEYfeMt6W1MVKs5vHQ7gppTvNRtPelrBcvTbiEoLOQcnXM5y8fxwlJtus= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788380131; c=relaxed/simple; bh=JwyZ01kuAk/qfl+mFKMw2jltAZAwwxU9OjstgPcmPv4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Pp5Vmjmo7IlhxMWVQZz4nH2ISeNgm08zfGVX8pevWhsOo7+00JAcXddNEXFsZ2kUuz9Nxf2iXVl5lyklTLaTosHospiqgiofjnkk7pS6HgWoFbJXxehCsSNC+cv3IeGvaZZ3bM1+RDPHD3D4EWefwHWeFj+GsoO31r3SM0+ERyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XWtdPkAC; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XWtdPkAC" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7eb61bbeb25so1449286a34.1 for ; Wed, 02 Sep 2026 13:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788380124; x=1788984924; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=RwvNUiQuAitNr4jRa/k1l/qEywBvK5orh/+JwgBfAtc=; b=XWtdPkACBA/wZ901baYeRiajj0eaMeZT0HCszyTR9KYxxzi4lVEgvn5OyjbIKlp2sq YO8HGGcTnUipFrDadS7CRNiOjkIaODQIvV7JuljzIqPIU/bHD2dm7PzEG4u5sKJ3evPI OeFNIy/Trpo4n09hFZugdbofAQ60ueTk8KRobDl5lcV5XKqJwq+3IcwnNnRW3bePnOiC /45MTllt47kA7qLClXNTSm6FqERK1hyzXVDDn/UsJKI5IKKFNkLde42m8nggOCBeU3S0 N+Ht5cRW6kvNntqnRyXTrFDSUqbzKCekpavSxrdZl33zy4A1R2uqcfHnbAyaGYJmNfE7 cXFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788380124; x=1788984924; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RwvNUiQuAitNr4jRa/k1l/qEywBvK5orh/+JwgBfAtc=; b=bbEqeSkTFoHOdj0XVtyWCyMFOncMTcLq8EddWSZHgLkAOjyjenC71gOaJ99ac1f7Og 3L/KTyevnxT0WlMiVtfEcccaTktp3m0dhEe71TvK4jM7lF+uyv4KAzVEmOKTPvlqiA3m hGJmtcuSdkmIdrUCLnJMzXloAaqV8ujvqOTAtq2OgNmmItN2/IdOpINQhwtmM2rIsz1b pKSnkPWCpZtPofOB5umZCjd8drxDo4wsu4Ydn03V3DnolBucmkaVXD3g3gVk9iO4qmG4 OrOfPQhL6uzXfr/apmZT8Z6tpiBfPNnejQywACnQjusepDpUvpsfsB9YufFDvHLTBAqH iZSQ== X-Forwarded-Encrypted: i=1; AHgh+Rq3Jokkvm8qos7QzqdoUq46Yrb3a1BcNEjXKTLhBazEKLJUetrGxWrEWq80biv89be3xvJ177yyWOwyw4Y=@vger.kernel.org X-Gm-Message-State: AFuF++moBuja8Yba9yviefGq5LP2RIlmm3boYIy58COyfiTvIWCwrNRk OwUWq69EBU6KC8BFI7HgdIK5MaGej4+HPBodYaylfZPwHELqVKZjZy2m X-Gm-Gg: AR+sD11tzdvcw5P1r/d2qecG3vGfrbnNl7xIZBhpAadgj00KTNwslCcu09v80vzFMEK xe1pwaqezWrpd+IvBjVODmYvrPya6BwPtNVjcR1bX7Uf3SsH/Pk0EM+uX9xR2SAqZSOwZYVF7iO KVADRGbCFD5I+VAME+jyLpXgD9dCTiiGTcGaeNylh1RIP6aaowIjCN0sDXt28Tj/OY08V8dAF0/ UnXSm8xSRfOhrqnB/dSYbD4KeuNbz0uEQSeql/ruNdLbyKIZ5vJMvuNdqn7H8MvMAJMh0tzy1b6 l98+CvFbG+SB/swkzbyvyGmBrJ0vHcQMgVYY/6QSpRqdDvqUitwetap0kS6yhaqBvRwS0LdAX8+ b6mcLMHDqp+8ZuYDBpWlgpEXSQXNU2bhxlSadDOXEQ/Jybf+ft/qoxlL2EpvJnCqRmF7aDhLL9j Iyl+ahvPMobvcg9gnXPugW9yghnyj/+LSdHrmmblJN68b2Y4fT5ObZKM8RaKfGIXyJAvcAnVnmV n17F4KFiD5qtmAU9FU7H9UncVzvO54= X-Received: by 2002:a05:6830:6317:b0:7f8:9fba:2cd8 with SMTP id 46e09a7af769-7f89fc97821mr2058368a34.9.1788380124278; Wed, 02 Sep 2026 13:15:24 -0700 (PDT) Received: from archlinux.lan ([136.34.156.120]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f74f8f7fbcsm3172554a34.23.2026.09.02.13.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 13:15:23 -0700 (PDT) From: Danish Khateeb To: Ard Biesheuvel Cc: Ilias Apalodimas , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Danish Khateeb Subject: [PATCH] efi/capsule: Replace kmap_atomic() with kmap_local_page() Date: Wed, 2 Sep 2026 15:13:40 -0500 Message-ID: <20260902201340.70189-1-danishkhateeb03@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit kmap_atomic() is deprecated in favour of kmap_local_page(), as described in Documentation/mm/highmem.rst. The conversion is safe here: the mapping is created and torn down within a single iteration of the sg_count loop, preserving the strict stack-based ordering that kmap_local_page() requires, and the mapped region is only written to, so neither pagefault_disable() nor preempt_disable() is needed. The surrounding code already sleeps (it allocates the pages with alloc_page(GFP_KERNEL) and later takes capsule_mutex), so there is no atomic context to preserve. Build-tested only. Assisted-by: LLM sparse Signed-off-by: Danish Khateeb --- drivers/firmware/efi/capsule.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/capsule.c b/drivers/firmware/efi/capsule.c index dd6252638..417e8f13a 100644 --- a/drivers/firmware/efi/capsule.c +++ b/drivers/firmware/efi/capsule.c @@ -245,7 +245,7 @@ int efi_capsule_update(efi_capsule_header_t *capsule, phys_addr_t *pages) for (i = 0; i < sg_count; i++) { efi_capsule_block_desc_t *sglist; - sglist = kmap_atomic(sg_pages[i]); + sglist = kmap_local_page(sg_pages[i]); for (j = 0; j < SGLIST_PER_PAGE && count > 0; j++) { u64 sz = min_t(u64, imagesize, @@ -277,7 +277,7 @@ int efi_capsule_update(efi_capsule_header_t *capsule, phys_addr_t *pages) */ efi_capsule_flush_cache_range(sglist, PAGE_SIZE); #endif - kunmap_atomic(sglist); + kunmap_local(sglist); } mutex_lock(&capsule_mutex); -- 2.55.0