From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB12D4ACC70 for ; Wed, 2 Sep 2026 21:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788384309; cv=none; b=VTj9nICz8bjawOBuOY083fOxaSKPbHI8J2Lmdpak/GKN6T+oS8RW0ajb1wIqIowai4D2T1uqRIC/esaT1fBlstlh1A78kuQVAGm8yKDz5EhhYiTzY7U9jCHptgEkxH4KuIx/+l3ht3BfQn2sAwC73FRiGUH0VNTTZibmZfviRpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788384309; c=relaxed/simple; bh=q9SAIJUr87M37a1nD9qzZab/gM5Ib5Ik8xsr+y/h9ic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eihuQC//5cXM3XdYkvNY9N+pfNWff1BtIgaGaH51GsxMcSCHzuDgAovsYLqF4HRIKerj4Ov7au6gWQO2oZaJnj/8KW9/BMRpnnkyt4FSu5SoMkYwL5CrhD/S1BCz4BJdbD49aq8ww4BL2elKAiScow00ZbEZZiXVhc/nCg5KT/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XBcjtfLp; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XBcjtfLp" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-85339ed040aso1366741b3a.1 for ; Wed, 02 Sep 2026 14:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788384301; x=1788989101; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rGaS9rMCdfAhEqnXYmIjGA+bHQqtxuQ5ZcfYKFa0ZgI=; b=XBcjtfLpZxcpsZfEo/CtsE4o7q0y5V/edJMkwkaCEJdUvkEOQmOmObGeK2HEP0HMEH VTmfYr4frVZJZSjAuNBjPDT0aVSiFGaz5awYvLiEb4YPssgRddg1CasQlbodwF1cSYOS gBPAcjlHHPqNUqEZpeZL4ScV71LCYFrEVtRxWHiti6ooLeCozAMsX/mG1+/cWea9pfqx 3AwMG3AQ8HznZVOGR0fgDU6KqP7u4KTDlmGvEA5I8KWK8eezGcxbmffBoDvCHHBA7uEl Ywu6ZcVCHOyLaJSqKV8eUv95gUNzC5JI4cxA7SnD5SMLuj2XNRC3FZxoRdabo7W3VOfp U+/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788384301; x=1788989101; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rGaS9rMCdfAhEqnXYmIjGA+bHQqtxuQ5ZcfYKFa0ZgI=; b=JpBCRME6+OgLq7rbuuHoLHgewF/6JcgtCC9S4JAvFlTsZH8mUmTUfDMDh0ZdKSonq0 yv/UqWssiy8jG+dKXVYv6qTSYVbTj/aE3wlZeNsfPKMOmYD+Xa8e/QJNGyZDU107AVP4 XGsRKKJDCCmZ4OIjPIMMpNdxCHAgvQIvg7CnDPVs6HbJ1FzBNGcMnE+GVmghG5fKzUV8 Qw4mbjAhus1aOsF1h0dBFjA+0U8kcPfUS+s7nG5TwmEiv9q7WWkFw+pTfMM7cZMdCSGM /uM82+YELkOc3wkR1kX89o7o4Dd6+Oz631PfEMTux4/2qgElsB+3rAV7xyfj8pWL8SOr 4LOA== X-Forwarded-Encrypted: i=1; AKwUvBwzZPBgyYY6QC80GzEilgIw9571P5T2/uc7MEu35H1kbwNYGWCGTdBF8A6PAAPNF/sC6bPf3si8F/DJuJ8=@vger.kernel.org X-Gm-Message-State: AFuF++kT/1oXem3y9bVjeSjkGlEglvjM0D7Bvz0BMFlT+YttSOoW+nPH pt2q6k4RtY7Ah5lxclLHlfoLKLpqClrdMMuqh0SLkqpheCVhc7SW9SpQtvSYsg== X-Gm-Gg: AYBFou0mARp7Gj8VmrcYFuvTfvlRb9GeOxTFbfiPfB6tQJqhRbGjkTcJYmGNIMZE7Tj tYf6plhJSBieL225zv/A5wU0lJcajHnMHpcm2tezlSPVEVL0C/s1NjtvwZpZsJwX9HYxzrmo1Uy cKJm/+48Vqx1vWMG7J3G/3ctq6y3IsrBWIeb1FZsMYazp5fzbljt3FWjyzl/bmlO6qWl/KXpZBH ItUijhiDRhy2ZdZiIsu76EYB9XfhKEH95U47bL/pcX6DxZhlY9UCqvvcEybwOo+SLOBb64OUrms tDUoQbrt+hikQGrCGRVAc9hwnG+1qy1c+eIDhNLLIqnXeEgnzYyOzsSS3NFNRBZhOUUvAWYMng1 1xVOq5gX7w4hXj3j/L665INpRfvacMwlyBB3e0zWibiG5cSZZdZW1OcUJJhc64otbuv345zFdXr qaNXOQlGQDyN65c5dQ5d0UhdyIoryaV0sw3qbXtUHEwjcmjJmJT+eZ0SdjPFghjeYojgs21Dw+Z FeJ+iR/qxmHowy2hPOiHhB3XYi7jPC9F/NeGOskHm4VqATaIJOuzA85RYVHwHkTy3o3NHu2u5dh cXiVWTv4J/Yy6G2EY41NomaEosh7FYuuNHhDLQ== X-Received: by 2002:a05:6a00:1784:b0:857:7384:b5f7 with SMTP id d2e1a72fcca58-85ed4640c6dmr10398979b3a.19.1788384301297; Wed, 02 Sep 2026 14:25:01 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc43d40c55fsm90890a12.19.2026.09.02.14.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 14:25:00 -0700 (PDT) From: Rosen Penev To: linux-i2c@vger.kernel.org Cc: Andi Shyti , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 1/3] i2c: ibm_iic: ioremap with platform pointer Date: Wed, 2 Sep 2026 14:24:54 -0700 Message-ID: <20260902212456.289608-2-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260902212456.289608-1-rosenp@gmail.com> References: <20260902212456.289608-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use devm_platform_ioremap_resource() as it only needs a platform_device pointer. Call it early to avoid allocation of the main struct and to avoid having to use goto. Signed-off-by: Rosen Penev --- drivers/i2c/busses/i2c-ibm_iic.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c index 7c70e8bda24e..20421ebe73ab 100644 --- a/drivers/i2c/busses/i2c-ibm_iic.c +++ b/drivers/i2c/busses/i2c-ibm_iic.c @@ -38,7 +38,6 @@ #include #include #include -#include #include #include @@ -684,21 +683,21 @@ static int iic_probe(struct platform_device *ofdev) struct device_node *np = ofdev->dev.of_node; struct ibm_iic_private *dev; struct i2c_adapter *adap; + void __iomem *vaddr; const u32 *freq; int ret; + vaddr = devm_platform_ioremap_resource(ofdev, 0); + if (IS_ERR(vaddr)) + return PTR_ERR(vaddr); + dev = kzalloc_obj(*dev); if (!dev) return -ENOMEM; platform_set_drvdata(ofdev, dev); - dev->vaddr = of_iomap(np, 0); - if (dev->vaddr == NULL) { - dev_err(&ofdev->dev, "failed to iomap device\n"); - ret = -ENXIO; - goto error_cleanup; - } + dev->vaddr = vaddr; init_waitqueue_head(&dev->wq); @@ -751,9 +750,6 @@ static int iic_probe(struct platform_device *ofdev) free_irq(dev->irq, dev); } - if (dev->vaddr) - iounmap(dev->vaddr); - kfree(dev); return ret; } @@ -772,7 +768,6 @@ static void iic_remove(struct platform_device *ofdev) free_irq(dev->irq, dev); } - iounmap(dev->vaddr); kfree(dev); } -- 2.55.0