From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b8-smtp.messagingengine.com (fout-b8-smtp.messagingengine.com [202.12.124.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E949477985; Wed, 2 Sep 2026 11:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788350184; cv=none; b=usbS6l1g8cjDBUfJYd4R4/BUG+QAmDKIPE0xHoRCSj8sHOIhP3gn6VVaoaUTa7dI1hpWchm2/fLvOoW3CKbehNVhm+8rbVfMTfuYP2p9SZ202KveOU7I/V+NVjhriWjUS60GLhync90bjP46KT8KaDmqncHXI+5iyeiPNU3HGIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788350184; c=relaxed/simple; bh=o/2hWz9cYSsj1g9n+IKiZF+6EPFNa85rk6eAvu3wqoI=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mlJU0dEH95DlSdvVjmNFMxWPGjiVUlqmn+AcsSxmx/On6faDk7vuKd4AVirDgv1nARRMF4HTSDOlAdj2J+yscYiTSwdIRe1GgWtEGwcY8EFK0wwZChSQmVjwbDFkhjx5fE3T+WGI+YYjrTdB43gxr3uRToUNGCFgwmUpJruS8BI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com; spf=pass smtp.mailfrom=kroah.com; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b=ra9H0Yvc; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=CoezHoSo; arc=none smtp.client-ip=202.12.124.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kroah.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="ra9H0Yvc"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="CoezHoSo" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id CF8BC1D000D6; Wed, 2 Sep 2026 07:55:52 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Wed, 02 Sep 2026 07:55:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1788350152; x=1788436552; bh=T8Ta5dWC3i BQKIe7qAuLecVMVEjIkycgwE+Mr3w9bDo=; b=ra9H0Yvc06w8a4i2Mr9PN+fn6A 5/f71qutVXClxp8cj/DQrWjSGdNyN0GJ1AgahqpDaeIwDFFUXqTbPl/xyzUBixiS pC/8kQqs6ogixbMC1YEPqNtWmrquW3kKIPmeEg0D+kxOMmV81WxJVHRDSXLzUfXa X381eos3ezytpkdkdrJeuUdyzIZCSc+mAjzXaVB3NKNRbxzV/BvZl+jgaJtZtNLZ eyj2VhzRKiIzNbtT1fhfzRflo1sE9AF2UGNpmHYiCYRKwWHfbb37QMOiIjKalx/V soa+ikfy6xgXbrqnkQiNXGtCwPitLtAqMq4LyjjsaZrnIfwh4Gge5c1dw5Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1788350152; x=1788436552; bh=T8Ta5dWC3iBQKIe7qAuLecVMVEjIkycgwE+ Mr3w9bDo=; b=CoezHoSoD19NrdrpilCXpNReX7RE96MFFFphDn4XWH5dS5QZ89C hNqacLnh32Ub4mKnXK5tbPLsxGkWAm6lDSuz7pGcdhq6J7fF5ns8Gg+IgwvbLEm/ 4AWQC5NmZpXhbEp8PzIBChDCjXmsJEZ4Xlo0jMCKDFzz0ZX0ci83hFXABZe1Klqf qgM9frxjGNRVUFDolE5feaUOUv/vPMk2VOjjPxJUPpCE3kmXkXnDVgg2jK9bvsOD q2FgFYtQTrNdXYMIOOZqF6+VZVFZvvnz48DHvx4X5Z7LxHdYF2ZI/e7Og4K0zqBb TOuDl4jq4og2SbZVpdla34llsOJAPKwBYCQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFe488197dB6Kik+J0Fs7xaGaBq5nNfTkYsjiWm9HfNozAMDVGdAgxUgOIiADB8Ll CHhgKEkZSuR1+dCHfrf0f20PU4fd+cYta99XPtep9/mBv9tqyy0VkUrCWj6pQcI/cNFo7C gs3JGCFUPhZ9h4WOluGPu/wrrzh4J/LGGMGfqnlyNNgyazV+QgUSUBfChGTlqa7ZM37zco 2fgefX2SQV94ZqSd72WCc6NudRzhoJlZQ6QMMN1KlOZ0SfaWQeZGcqibcG9LdHSH143J4r 3sm5gLtJX+puYCqsUh9gGVMGRQYv3jVnuNqo99bW6sJOPqR3BODxE6UmZCNy+KX1hkf3Zz W8JmuXTectD6FjtDckpY8DK7HKlgcXqQ3p3JQRR4POTnMNtkKg8sUh/acwNe0pgw6TL+un gMmXzpbOhOvQliQBudC/lNWxKWB0nlWugR0xI6iUYjuNyevu1iiv5uKQ4cSReUtcSZo5vI duNC0EPxawBJ9ADrt42y/+MvWGw9CjXWGJXLroEFW7AwzEVgQSpaIZF2lynoFRGPDxxcmZ R+ZtzoMBE4IgZcexAEyrtqOKHCSR0C24vb1Vsqv97K3i2qM+BPpRsl9CIxe3RClpeFEj6J yjN3b+u+lHVse6bmVg/3i4cCoS5E7lNmPQ/iJUSlFivzHFGMMSZ80wACj+4w X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 2 Sep 2026 07:55:52 -0400 (EDT) Date: Wed, 2 Sep 2026 13:54:08 +0200 From: Greg KH To: Jingbo Xu , xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] erofs: add sysfs feature entry for xattr prefixes Message-ID: <2026090258-zealous-oyster-2874@gregkh> References: <20260902015039.54190-1-jefflexu@linux.alibaba.com> <2026090256-impart-headstand-7d29@gregkh> <2026090249-rework-vividly-5abb@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Sep 02, 2026 at 07:42:36PM +0800, Gao Xiang wrote: > On Wed, Sep 02, 2026 at 01:38:16PM +0200, Greg KH wrote: > > On Wed, Sep 02, 2026 at 06:53:16PM +0800, Gao Xiang wrote: > > > Hi Greg, > > > > > > On Wed, Sep 02, 2026 at 07:36:13AM +0200, Greg KH wrote: > > > > On Wed, Sep 02, 2026 at 09:50:39AM +0800, Jingbo Xu wrote: > > > > > Let /sys/fs/erofs/features/xattr_prefixes advertise that this kernel > > > > > supports the EROFS_FEATURE_INCOMPAT_XATTR_PREFIXES on-disk format. > > > > > > > > > > Fixes: 6a318ccd7e08 ("erofs: enable long extended attribute name prefixes") > > > > > Cc: # 6.4+ > > > > > Reviewed-by: Gao Xiang > > > > > Signed-off-by: Jingbo Xu > > > > > --- > > > > > changes since v2: > > > > > - add Reviewed-by tag (Gao Xiang) > > > > > - update list in Documentation/ABI/testing/sysfs-fs-erofs > > > > > (https://sashiko.dev/#/patchset/20260901062243.109172-1-jefflexu%40linux.alibaba.com) > > > > > --- > > > > > Documentation/ABI/testing/sysfs-fs-erofs | 2 +- > > > > > fs/erofs/sysfs.c | 2 ++ > > > > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > > > > > Why is adding a new feature a stable thing? > > > > > > It's not a new feature (Also, this patch has 3 lines diff): > > > This is a bugfix to address the missing part of > > > commit 6a318ccd7e08 ("erofs: enable long extended > > > attribute name prefixes"") since every on-disk features > > > should be shown in `/sys/fs/erofs/features/*` according to > > > the definition of: > > > > > > What: /sys/fs/erofs/features/ > > > Date: November 2021 > > > Contact: "Huang Jianan" > > > Description: Shows all enabled kernel features. > > > ... > > > > > > IOWs, this sysfs entry should be part of commit 6a318ccd7e08 > > > to indicate this feature is supported since Linux 6.4+ > > > > Ok, but as this has not been present for a very long time, did anyone > > even notice and need this now in stable kernels? :) > > I think Jingbo needs it (btw, I'm no longer in Alibaba Cloud > anymore). > > Also it would be better to port this into stable kernels so > that users can get the supported on-disk features in a more > unique obvious way. Ok, that makes more sense, sorry for the noise! greg k-h