Re: [PATCH 5/7] media: i2c: st-vd55g: Add generic driver and VD55G0 support

[Krzysztof Kozlowski <krzk@kernel.org>]

On Wed, Sep 02, 2026 at 04:45:44PM -0400, Peter Marshall wrote:
> +static int vd55g_probe(struct i2c_client *client)
> +{
> +	struct device *dev = &client->dev;
> +	struct vd55g *sensor;
> +	int ret;
> +
> +	sensor = devm_kzalloc(dev, sizeof(*sensor), GFP_KERNEL);
> +	if (!sensor)
> +		return -ENOMEM;
> +	sensor->dev = &client->dev;
> +
> +	v4l2_i2c_subdev_init(&sensor->sd, client, &vd55g_subdev_ops);
> +
> +	ret = vd55g_parse_dt(sensor);
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Failed to parse Device Tree\n");

Isn't vd55g_parse_dt() printing errors already? How many times same error
should be printed?

> +
> +	/* Get (and check) resources : power regs, ext clock, reset gpio */
> +	ret = vd55g_get_regulators(sensor);
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Failed to get regulators\n");
> +
> +	sensor->xclk = devm_v4l2_sensor_clk_get(dev, NULL);
> +	if (IS_ERR(sensor->xclk))
> +		return dev_err_probe(dev, PTR_ERR(sensor->xclk),
> +				     "Failed to get xclk\n");
> +
> +	sensor->xclk_freq = clk_get_rate(sensor->xclk);
> +
> +	sensor->reset_gpio =
> +		devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
> +	if (IS_ERR(sensor->reset_gpio))
> +		return dev_err_probe(dev, PTR_ERR(sensor->reset_gpio),
> +				     "Failed to get reset gpio\n");
> +
> +	sensor->regmap = devm_cci_regmap_init_i2c(client, 16);
> +	if (IS_ERR(sensor->regmap))
> +		return dev_err_probe(dev, PTR_ERR(sensor->regmap),
> +				     "Failed to init regmap\n");
> +
> +	/* Detect if sensor is present and if its revision is supported */
> +	ret = vd55g_power_on(dev);
> +	if (ret)
> +		return ret;
> +
> +	/* Enable pm_runtime and power off the sensor */
> +	pm_runtime_set_active(dev);
> +	pm_runtime_get_noresume(dev);
> +	pm_runtime_enable(dev);
> +	pm_runtime_set_autosuspend_delay(dev, 4000);
> +	pm_runtime_use_autosuspend(dev);
> +	pm_runtime_put_autosuspend(dev);
> +
> +	ret = vd55g_subdev_init(sensor);
> +	if (ret) {
> +		dev_err(dev, "V4l2 init failed: %d\n", ret);
> +		goto err_power_off;
> +	}
> +
> +	ret = v4l2_async_register_subdev(&sensor->sd);
> +	if (ret) {
> +		dev_err(dev, "async subdev register failed %d\n", ret);
> +		goto err_subdev;
> +	}
> +
> +	return 0;
> +
> +err_subdev:
> +	vd55g_subdev_cleanup(sensor);
> +err_power_off:
> +	pm_runtime_disable(dev);
> +	pm_runtime_put_noidle(dev);
> +	pm_runtime_dont_use_autosuspend(dev);
> +	vd55g_power_off(dev);
> +
> +	return ret;
> +}
> +
> +static void vd55g_remove(struct i2c_client *client)
> +{
> +	struct v4l2_subdev *sd = i2c_get_clientdata(client);
> +	struct vd55g *sensor = to_vd55g(sd);
> +
> +	vd55g_subdev_cleanup(sensor);
> +
> +	pm_runtime_disable(&client->dev);
> +	if (!pm_runtime_status_suspended(&client->dev))
> +		vd55g_power_off(&client->dev);
> +	pm_runtime_set_suspended(&client->dev);
> +	pm_runtime_dont_use_autosuspend(&client->dev);
> +}
> +
> +static const struct acpi_device_id vd55g_acpi_match[] = {
> +	{ "SMO55F0", (kernel_ulong_t)&vd55g0_chip_info },

Use named initializers, like in the OF table.

> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(acpi, vd55g_acpi_match);
> +
> +static const struct of_device_id vd55g_dt_ids[] = {
> +	{ .compatible = "st,vd55g0", .data = &vd55g0_chip_info },
> +	{ .compatible = "st,vd55g1", .data = &vd55g1_chip_info },
> +	{ .compatible = "st,vd65g4", .data = &vd65g4_chip_info },
> +	{ /* sentinel */ }

Best regards,
Krzysztof