From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF6E74B5CB6 for ; Thu, 3 Sep 2026 14:29:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788445777; cv=none; b=rbxUN0enGVsJlMiWRtJAbhyGLyNephhTujtStgiu5ek+2bHMIoANqL7AJm5cfkAOmqlh2/yc9ysJjiqNOFybJmm33AQ8Sdd9pUY1dpkJqPTI/DgHhxYA+xo6PZfaoPMglgEpbwCcXwsD59UUWXnHrtCDsCKY4q28Pb8ihgpgN2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788445777; c=relaxed/simple; bh=1h8UY7C7DRfSBJpx+Kqk2kMtTanSJ0uIlMXF2pMqnmI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gPWu1OACaOvZNaiGHrgNuL7W1Etd/4jHZLthfl5T8w1wmY1N/vRYCmAsP+NRIaLEHoZdMuKfvawj5kDDq7W3CNMOPbsFtu6GS6z50WlMRF0dBcWgEUmF+RG/yzNwww1pFqKrl2JSVhyIxQa9zqJ4pJlNoO7k3jZeamqQMLtclXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E28mpCZO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jW5rfLb1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E28mpCZO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jW5rfLb1" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 683DAAmF1704864 for ; Thu, 3 Sep 2026 14:29:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YrYZPm63HO7KH0MIwA5KVAUAv2xcSfYhYKeQJlbSewA=; b=E28mpCZOYSVLIZUg feqGJZzVkbTIloQAxjTgVzF46iC2DKqWJgxBJv9nWtuyWk3iR1SrX/Sdr3eFo6wX r6mkjtEVsqQF/0fLb+hSDt0gZIMB1v6rOWe3gkWDUxsLA/BPl6ch6+Ri4GbDSsfZ ulRDNbIWlhBnJUIX0SqfrWEyQ2mQW6FE3T5GN9dZHZXzLatGPGDgLlu+VmNhWLAE 150PEADxA1wMOfEMF6LCr9GTy+n0rrmLSRvrMmhaKJWe72nZ/brYO8RdD87kZFjP RxGwQ9cm9rzhZCmdNjkxF1SPjzZKz6TKovh7BKugQYcfSmbLiuwRH/ZfUEKU0qTD wvOb2w== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf9b18cf7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 14:29:24 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93771aa0379so663225185a.1 for ; Thu, 03 Sep 2026 07:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788445764; x=1789050564; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YrYZPm63HO7KH0MIwA5KVAUAv2xcSfYhYKeQJlbSewA=; b=jW5rfLb1GTiGMJ/ggH6WVGUnYFguEj4py/ZCsNSkq7I/A/krbQILsAT3BjuVY4p/pJ HcJwUmFv3PhNrOlfql/MmnGr+1O05KkO3DacivO61+OInUn8t3zNsp8JJT4FGUxxXUtx 9R9yNUeEiogEyb2km8TwKkJzJycYlU+pqM7CYdzMzio9riq4Ij2GCHJ2O+4xANAHsmYf JoxLFqzy6l9/+8mtsGMSB1o5x2E0NEKRkvkoISeKx2L/s6e1ILFzBwhqxzJeds44tlYR 7CKiR0VlJKcvH7hRWel8F8wMezh+uUDewZ1Icb8KoUHd2n05E01YTSeb8Cd+3FmpQdJG sL4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788445764; x=1789050564; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YrYZPm63HO7KH0MIwA5KVAUAv2xcSfYhYKeQJlbSewA=; b=X6xj2bsThfoARuvlcA5dCMkGnW/4xFBtWij8QCNeQZLkOhm4CMlNZWTjhyBJVpnk7e uWhjIALbsdAdefzGhdonwnyrOmhszfD4L42lxHIf5DLGg9Hj6Zr7XJmAzykTzsYu7erS xjWXfLe3ZEhSLQEYc02ksuxSNZUyKrIc3EZVUtkuPH5vAK4IvCCL4yIJJNYNaUzsncya 3rh+C8CM4NM1wBHq/ktjJiTT1U8wYa0bD4yBc0vegPsskVUMK/BntNdNA3KShhnz1eTD 7Jh1vXgEDwSDqfPNEB7LBfWgefA1Fu6kH/z8JkwNFOXXD2d/xtbRY3AaS0opVUUJppYw LwTg== X-Forwarded-Encrypted: i=1; AKwUvBwtk4Bi2aAlvrxLh6cF1OV22CM4R7L5Et1Xr+ufQF0kC4QEyCVD80aJITku/kVBQkfPOjMQ7xNiqYwls1o=@vger.kernel.org X-Gm-Message-State: AFuF++n1XSf1SEUPtp9Nj4U7M208znU3xCuljp0lVmtWP0y65j+YST7Q SwDaLKgmKmdqwuW6R19YUJI5i1rS4KjuW6FR7ZweqfOJRAotjxJ6quv11Ry5PMRNz8yITiEZDBX h/LkiakztaLediRVOZXeG01r0hdIMgDIakZKwMJki8jGtFF0lDQdVu91NzlPV+in7w3yxzunf/T I= X-Gm-Gg: AYBFou0PcsRymWKQPVNXG1tM57QHu3a388iqeKbzP2WxTphs3WSeRCnS4BAcDkpovkC l0pMjjyVi27Fnom/PlhRFXg/0h2Kva5z67X0A835lppQjgG4eTRdnRIDkyKsgfoQKMq49jlC5aE w42l30beF6xnpUFDieqq0x66W1Xc9ejoKKGTdhDWvJVkWpHeLcOhCaJ4ZMJ3foVne9d009RHA1E IXRzPdEzTLkcv54fs5XalFpVVsjm0HZO84YH5oUtX3t4YEYPJzLEAJAf1eG1avhaRXl0u5FC2xc WOAGhxSg788I0ZIFM6oXNquLUtz7a9T5rGWnFi/abDir8n4gOypH0VBN97529bh25VelHS1zm4S MHXjyfKCMzYAep6hZD7tIBOD3D0cb X-Received: by 2002:a05:620a:4114:b0:939:57ca:7e0a with SMTP id af79cd13be357-93960cabe26mr1473852185a.7.1788445763662; Thu, 03 Sep 2026 07:29:23 -0700 (PDT) X-Received: by 2002:a05:620a:4114:b0:939:57ca:7e0a with SMTP id af79cd13be357-93960cabe26mr1473842785a.7.1788445762889; Thu, 03 Sep 2026 07:29:22 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:1c7d:412b:f9d3:3bfc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cee5f9114sm72799415e9.5.2026.09.03.07.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 07:29:21 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 03 Sep 2026 16:29:08 +0200 Subject: [PATCH 1/2] power: sequencing: don't call .post_enable() if pwrseq_unit_enable() failed Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260903-pwrseq-kunit-v1-1-1f893d2cabc2@oss.qualcomm.com> References: <20260903-pwrseq-kunit-v1-0-1f893d2cabc2@oss.qualcomm.com> In-Reply-To: <20260903-pwrseq-kunit-v1-0-1f893d2cabc2@oss.qualcomm.com> To: Bartosz Golaszewski , Manivannan Sadhasivam , Chen-Yu Tsai , Krzysztof Kozlowski Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=908; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=1h8UY7C7DRfSBJpx+Kqk2kMtTanSJ0uIlMXF2pMqnmI=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqmYQ8f67iDxjYYuF9u6KuV9DjWQ8r4SVQDMArr QvqpcuuORWJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCapmEPAAKCRAFnS7L/zaE wz1QD/48X4FfbNFqvDxZCWx2jhXOClH8pEnGIil8YRnF0id/RgcwhJyI2nRkXz1UWuq+tHyUUUJ nIZsbzcL4LptvIbWt20lI+Qwp1S/QqZVhjq5nIFYTop1lLX+tYrKZxCIOFyPObOMx8rEOV+BhG+ cHL6R93C6o8c1VW84qHCvz5CLVBwsWDFhJi2cMBm2vqQmPcosm2ntjl3yDHwjNe5PiUmv9mPxUA bqY61zXsbS17XFMG+JnBxnoLMmg8TEW8q2O1IWoVcs1LpWViq59sc1UaR5l8BZ/cUTPTGMX6Tjv 2jVqqRaUYurrMpkbdX2U6+T0FM+q5oMzfOfc3tEQoub+GOusp/7U6DrmvjPC1wJSwnv3e9Rdtrt mhVn2EPAaayGyO3yHOIxHIcF6KEWyoXjDmtMWKpctHO+qC/23wEbMaSURvsqsThpD5s4qtTjuLu QdLT0WiuR9RmMwbwYP2GwxATeRKup8P9JJicTeOfOtM/nXx6dHS1nl8xM7JJNa3g5YiRZSdqFMn Kw8K3aWGuayYa3meYob3Nfx+CX2Yn6n9SQu4nnE2OwcGCgocLWVs2M5CM+qyn4YnWj7wpZOaoIz XeyYsJfbucjy0/l6i1V7//swCUnHokK7kUxJJKbB+wtaRLCl9wgRsd2yHYpbWwAYNhtE9kQwpE4 Pu9efPOytK2abdw== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-ORIG-GUID: L2HnXZCxBM8-s82W8Fj23dQuEoQV_OaG X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDEyNiBTYWx0ZWRfXwX4gnfhGdEWR tuUbrmynNlq2VIDG9NBKWwk915uDrP1NHZ0tzW1WnWzjoX+HTzdvX9c2+2W9Yo/4hIGPVYFPO13 rNqgIMRZt/nondretcSM1N3zqg0fEM8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDEyNiBTYWx0ZWRfX7ZfFmnTtFE1F eu9Ws6DJrH+L7vqh3TLy7QFPIfK3Y1lLjlzeC4iV0S57win45M2oDySMZvzUlyM6RAEcylYuyS+ yClQK7NaFszaXcYyC3LIbq3flh2Gp5tCK2vqzx8Ul7wEd74Ifov1m+aeMGBXE/VxZrZtr4T7hkl sMEp8qxrMHsmfiE3GH/W9qDOOmXipLFGzV90ZHeB0Q/o6oj6s4h9GWupxyhrya//kkQ4fpO2ucf JPAnHYtnEr8pY2RLdSKAZslR9FiIZBpimz2ChlP8QijbFhQfe9As34RJeRSElnZKJok65bpGfW4 BhOpX+eCimWJeg2x4n3aM8AtRodum/TFDKBM56OhMAX5Kzc/b7FjIDHIJTReGIXG21O+QKnCbU3 JahU7a7NVNanecuTiSTvz0QYeAJSuZToRuYptANX1qm4o0pTHDEqM8CFypK++Owq4yuUCLoSw5g N0Pu/ghCKg3BOb9wgQw== X-Authority-Analysis: v=2.4 cv=NNTlPU6g c=1 sm=1 tr=0 ts=6a998444 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Trbc2l1I1fXLbfWOQTAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: L2HnXZCxBM8-s82W8Fj23dQuEoQV_OaG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_04,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030126 If the call to pwrseq_unit_enable() failed in pwrseq_enable(), bail out instead of calling target->post_enable() which assumes the target was successfully enabled. Fixes: 249ebf3f65f8 ("power: sequencing: implement the pwrseq core") Cc: stable@vger.kernel.org Signed-off-by: Bartosz Golaszewski --- drivers/power/sequencing/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/power/sequencing/core.c b/drivers/power/sequencing/core.c index 721e888b658d1f254513e126bb72f2d0487a8383..76c39600f690d9f19a21f4a89512ee24942e3b14 100644 --- a/drivers/power/sequencing/core.c +++ b/drivers/power/sequencing/core.c @@ -912,6 +912,8 @@ int pwrseq_enable(struct pwrseq_desc *desc) if (!ret) desc->powered_on = true; } + if (ret) + return ret; if (target->post_enable) { ret = target->post_enable(pwrseq); -- 2.47.3