From: Huang Shijie <huangsj@hygon.cn>
To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<namhyung@kernel.org>
Cc: <zhongyuan@hygon.cn>, <fangbaoshun@hygon.cn>,
<yingzhiwei@hygon.cn>, <mark.rutland@arm.com>,
<alexander.shishkin@linux.intel.com>, <jolsa@kernel.org>,
<irogers@google.com>, <adrian.hunter@intel.com>,
<james.clark@linaro.org>, <tglx@kernel.org>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <liuqi@hygon.cn>,
<lijing@hygon.cn>, <wujianyong@hygon.cn>, <wangfengyu@hygon.cn>,
Huang Shijie <huangsj@hygon.cn>,
Ravi Bangoria <ravi.bangoria@amd.com>
Subject: [PATCH] perf/amd/ibs: Report physical address for IBS fetch samples
Date: Thu, 3 Sep 2026 13:44:22 +0800 [thread overview]
Message-ID: <20260903054422.148739-1-huangsj@hygon.cn> (raw)
The IBS Fetch sampling does not report the physical address of the
fetched instruction even when PERF_SAMPLE_PHYS_ADDR is requested,
while IBS Op sampling does.
This patch reports physical address for IBS fetch samples which can be
used for profiling the running program.
Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com>
Signed-off-by: Huang Shijie <huangsj@hygon.cn>
---
arch/x86/events/amd/ibs.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c
index 3531f9c23b8c..e5376ad5b2ec 100644
--- a/arch/x86/events/amd/ibs.c
+++ b/arch/x86/events/amd/ibs.c
@@ -1318,11 +1318,31 @@ static void perf_ibs_parse_ld_st_data(__u64 sample_type,
}
}
+static void perf_ibs_parse_fetch_data(__u64 sample_type,
+ struct perf_ibs_data *ibs_data,
+ struct perf_sample_data *data)
+{
+ union ibs_fetch_ctl fetch_ctl;
+
+ if (!(sample_type & PERF_SAMPLE_PHYS_ADDR))
+ return;
+
+ fetch_ctl.val = ibs_data->regs[ibs_fetch_msr_idx(MSR_AMD64_IBSFETCHCTL)];
+ if (!fetch_ctl.phy_addr_valid)
+ return;
+
+ data->phys_addr = ibs_data->regs[ibs_fetch_msr_idx(MSR_AMD64_IBSFETCHPHYSAD)];
+ data->sample_flags |= PERF_SAMPLE_PHYS_ADDR;
+}
+
static bool perf_ibs_is_mem_sample_type(struct perf_ibs *perf_ibs,
struct perf_event *event)
{
u64 sample_type = event->attr.sample_type;
+ if (perf_ibs == &perf_ibs_fetch)
+ return sample_type & PERF_SAMPLE_PHYS_ADDR;
+
return perf_ibs == &perf_ibs_op &&
sample_type & (PERF_SAMPLE_DATA_SRC |
PERF_SAMPLE_WEIGHT_TYPE |
@@ -1555,6 +1575,8 @@ static int perf_ibs_handle_irq(struct perf_ibs *perf_ibs, struct pt_regs *iregs)
if (perf_ibs == &perf_ibs_op)
perf_ibs_parse_ld_st_data(event->attr.sample_type, &ibs_data, &data);
+ else
+ perf_ibs_parse_fetch_data(event->attr.sample_type, &ibs_data, &data);
/*
* rip recorded by IbsOpRip will not be consistent with rsp and rbp
--
2.53.0
next reply other threads:[~2026-09-03 5:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 5:44 Huang Shijie [this message]
2026-09-03 11:55 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903054422.148739-1-huangsj@hygon.cn \
--to=huangsj@hygon.cn \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fangbaoshun@hygon.cn \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=lijing@hygon.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liuqi@hygon.cn \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=tglx@kernel.org \
--cc=wangfengyu@hygon.cn \
--cc=wujianyong@hygon.cn \
--cc=x86@kernel.org \
--cc=yingzhiwei@hygon.cn \
--cc=zhongyuan@hygon.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®