From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E26DC3FC5B5 for ; Thu, 3 Sep 2026 07:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788420806; cv=none; b=RRwgkYDpIpvIe/2+0KBLj9NgSE5asE9uULHHb98QEqkEA6NBJcxC5JnU5kc8tIAanbJGowfbEV/fIw5CYp5NTcczUR8dDKpn62A0aficj48SjuyPMyI77yYOKAGY9fEKuTtgLsC64TxGcj0As/PDGLZwiggRPwNFFwlA6Kn/jRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788420806; c=relaxed/simple; bh=vc9oGAqRaMzb6Xdaj+3NGIpap5QZHwRnk2S+pTd4Ur0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QxYsd9T6BzJbmNjolKF4u+FoZTUR1gljkJGHY+uKpi4vm8N5332fXYHFN8tt2YMKLwwgagPCdopqt3/hiea2QymEFrbUO2B3MLE9iHun9N54tJBBPMZB6NaHesmvRpcQMEJ+uuZIAfUdy++Q0S0oA5G8KtaIZdCxoTNIUcuGr5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gXRQ+ot8; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gXRQ+ot8" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38511175ad3so2085466a91.2 for ; Thu, 03 Sep 2026 00:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788420804; x=1789025604; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vwKd+TdvIX9ZItYpiwc95hBpIK2+IZI68PvC5hF8oBU=; b=gXRQ+ot8xrnODpfz1oRU3OnQE6YKCLOZFFWUun64wvWG1Qd/SV1XbeOBvHjFSUwdQN MIw7JW3scVPQVv+bhdAVTtUnv1WFC4GkkFCBzn7gMI4C8W1gbSXiAMZGa9+H0jhoa2Ys oAQQhjKU/1nP2fkRJur38BsS2WXfCXou3RF8f4XVhY5Nde4Y5ory/VEObNee23KJdFqm vJSMolBQHjCF9MAR7RQI1O/84uCRW20Xvf04KYO0sAPQIKaThLySwbd46kgtrFVjZ0l4 xdgQo0Ift7I5rZmBzQDZKTBrF2OwrTGi9MQV0Oh1H6pMQycsfFUcJFliLGlgCialR2FF mYrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788420804; x=1789025604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vwKd+TdvIX9ZItYpiwc95hBpIK2+IZI68PvC5hF8oBU=; b=X9RW3i5nuKIuRibtF7YNGH4CvfMplFosn+KJe28WZOIvhtf6tFj5RQaFWmQVfFFkwG KO6a0zFnN/pKaks4tRaDS7AGNOOTrAPiB2V6CHPUOMttWzscrkylshP9T5JIoiRzKInW j+2VO3MOLnkLTqKii2VyPBNsL3zSH6cRGTgj4FiHqCLe3+FQ+TB4ntgofXyF6BkbuMnA 4Q4uP5NkSnY5H+Hh8iEbFm48SvdPKrmW+DLVHKGEeYaApOdwD6O1qc8dzhZ8q8DCKFSq eFw9+mpRzWpPChndQ567+fSKZgoLqBzCX0785uehhlzmA4cFQ2JU9VtGFZK+keA1cGW2 4HhQ== X-Forwarded-Encrypted: i=1; AKwUvByyV02iD0sTVXinngM9iEYz1OgATgaLVK9gXGFwRvg8SqxJs1A6Je4JTJ4uiU8ejUDwOFaZ8JB1TICHraU=@vger.kernel.org X-Gm-Message-State: AFuF++nhubHKAW8hBm+wLNHDXdPY71Fy8ez95yQbStSaDZjqcoHmk1BT lAA2heHvyJM1cVwgOk/GqwgYXzStImXXverDIAbb7h5aCvktC5AlU22Kp/YDJA== X-Gm-Gg: AYBFou0MmEyZjZeq71vFHpKyJAh1bMhSvaMwYbAx6DU+is/hQSRFuvxOFmOl9FITs1k 4Lx5Cscu3bsytPy6o/NTyiufR5ch1BwX7GckSV7k16WeBb07o9Hmwhjkn4RCub6z9L4GqJ7PaSs ZRBOLHI52YpyYq/DcRAAM4uAtfJAFTghzSveGgL4fe/w7ml7w42mu/Z5te3IwgVcpuh9q+9dUXc o9wfbRN0F7Yg83mvZ9fkeVdARZmHtEXJnmi3ovijxVCicQvk/CimFbZvSxqHR5VodNFp9Jb4Lca 2V+m++1qJYc2wXfm3IOyNzf+tcDylBEvlH3mV43M3PawbEvIEAfJRVmkge0dwIOIJo5poP8ugoF xmIyWYWo3rDMFPNfT0+bkojJmzM+xbvQyG8QcA9T7J9gylpXiKNfMv/d7j6jgnfbgnOgQBEW7tJ tJt5/aHZpaxfiAxzlxrC3FpNwzKGpBhSJvF0p+DIMbWNORtgP/mrdDm1Y4SlGoLTzi6kSPUJUeH XnTZZvSBAQrDb7EMDCNsM2yqZa2k53+SGFz6jB7Fjt0MK3VcMaogUH3OPYBdXldfp67v7edbkau e4xz X-Received: by 2002:a17:90b:3d84:b0:392:ca3b:370a with SMTP id 98e67ed59e1d1-39aedf7cc2cmr17489022a91.2.1788420804175; Thu, 03 Sep 2026 00:33:24 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08624f11sm3606813a91.11.2026.09.03.00.33.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 00:33:23 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Simon Horman Cc: Andre Przywara , Robert Hancock , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH net-next v5 2/3] net: xilinx: axienet: Handle optional IRQ return value correctly Date: Thu, 3 Sep 2026 14:32:51 +0700 Message-ID: <20260903073252.339250-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260903073252.339250-1-phucduc.bui@gmail.com> References: <20260903073252.339250-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc lp->eth_irq is assigned from platform_get_irq_optional(), which returns a non-zero interrupt number on success or a negative error number on failure. Errors other than -ENXIO are handled before this check, so -ENXIO is the only error value that can reach this point. Check for a negative value instead of treating 0 as an undefined IRQ. Fixes: 522856cefaf0 ("net: axienet: Add optional support for Ethernet core interrupt") Reviewed-by: Radhey Shyam Pandey Signed-off-by: bui duc phuc --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 207aecb5f8b9..3927ababf833 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -3052,7 +3052,7 @@ static int axienet_probe(struct platform_device *pdev) ndev->ethtool_ops = &axienet_ethtool_ops; } /* Check for Ethernet core IRQ (optional) */ - if (lp->eth_irq <= 0) + if (lp->eth_irq < 0) dev_info(&pdev->dev, "Ethernet core IRQ not defined\n"); /* Retrieve the MAC address */ -- 2.43.0