From: Leon Romanovsky <leon@kernel.org>
To: Jeffin Philip <jeffinphilip14@gmail.com>
Cc: jgg@ziepe.ca, kees@kernel.org, Tatyana.E.Nikolova@intel.com,
roland@purestorage.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, larrystevenwise@gmail.com,
pj.waskiewicz@solidfire.com,
syzbot+bd317784d628820741b5@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2] RDMA/core: fix refcount bug in iwpm_get_nlmsg_request()
Date: Thu, 3 Sep 2026 13:23:23 +0300 [thread overview]
Message-ID: <20260903102323.GC24140@unreal> (raw)
In-Reply-To: <20260903101742.214304-1-jeffinphilip14@gmail.com>
On Thu, Sep 03, 2026 at 03:47:42PM +0530, Jeffin Philip wrote:
> iwpm_get_nlmsg_request() initializes refcount _after_ list_add_tail()
> making it accessible to global list where another CPU can kref_get()
> on nlmsg_request causing a refcount "addition on 0" bug. Fix this
> by initializing kref _before_ list_add_tail() so refcount for
> nlmsg_request can be incremented/decremented normally. In addition,
> also initialize every field before list_add_tail().
>
> Reported-by: syzbot+bd317784d628820741b5@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=bd317784d628820741b5
> Fixes: 30dc5e63d6a5 ("RDMA/core: Add support for iWARP Port Mapper user space service")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jeffin Philip <jeffinphilip14@gmail.com>
> ---
> Changelog:
> Changes in v2:
> Add list_add_tail() last after initializing every field as per Leon Romanovsky's
> suggestion.
> ---
> drivers/infiniband/core/iwpm_util.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
The patch doesn't apply and please send it as standalone patch and not
as Reply-to.
Thanks
prev parent reply other threads:[~2026-09-03 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 8:52 [PATCH] " Jeffin Philip
2026-09-03 9:52 ` Leon Romanovsky
2026-09-03 10:17 ` [PATCH v2] " Jeffin Philip
2026-09-03 10:23 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903102323.GC24140@unreal \
--to=leon@kernel.org \
--cc=Tatyana.E.Nikolova@intel.com \
--cc=jeffinphilip14@gmail.com \
--cc=jgg@ziepe.ca \
--cc=kees@kernel.org \
--cc=larrystevenwise@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=pj.waskiewicz@solidfire.com \
--cc=roland@purestorage.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+bd317784d628820741b5@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®