mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Nikita Taranov <nickita.taranov@gmail.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Darren Hart" <dvhart@infradead.org>,
	"Davidlohr Bueso" <dave@stgolabs.net>,
	"André Almeida" <andrealmeid@igalia.com>,
	linux-kernel@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: futex: private hash can stay on the shared atomic refcount indefinitely after auto-scaling
Date: Thu, 3 Sep 2026 18:03:17 +0200	[thread overview]
Message-ID: <20260903160317.-6L7VXXK@linutronix.de> (raw)
In-Reply-To: <20260902213143.3426531-1-nickita.taranov@gmail.com>

On 2026-09-02 21:31:42 [+0000], Nikita Taranov wrote:
> The problem was originally observed on a synthetic benchmark that pretty much
> did what the first repro does. On that benchmark, it was really bad as you saw.
> I've never seen it on a real workload, so cannot comment on that.

Okay. In that case I need to figure if we want to care about a
regression on micro benchmark.

>                           stock v7.3-rc1        + your patch
>   Xeon 6975P-C 96c/192t   8/8 at 96,128,192     0/8 everywhere
>   Graviton4 Neoverse-V2   see below             0/8 everywhere
>   AMD EPYC 9R45           0/8 (never stalls)    0/8

So this means my quick hacked fixed your problem?

> I'm guessing your patch was an early stage draft, but just in case let me flag
> one problem I saw: on the Intel box the futex selftests regress:
> 
>   stock v7.3-rc1     14 passed, 0 failed
>   + your patch       12 passed, 2 failed
> 
>   futex_requeue      requeue_multiple:
>                        expected 10 == futex_cmp_requeue(f1, 0, &f2, 3, 7, 0), got 0
>                        expected  7 == futex_wake(&f2, INT_MAX, 0), got 0
>   futex_requeue_pi   2 of 24 fail: broadcast_owner, owner
>                        "Test terminated by timeout"

Yeah, I might have got something wrong. It was just an idea but might
look into this if we need this fixed. Thanks for the feedback.

> Regards.

Sebastian

      reply	other threads:[~2026-09-03 16:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23 15:00 Nikita Taranov
2026-08-24 16:03 ` Sebastian Andrzej Siewior
2026-08-25 17:06   ` Nikita Taranov
2026-09-01 23:05     ` Nikita Taranov
2026-09-02  7:56       ` Sebastian Andrzej Siewior
2026-09-02 21:31         ` Nikita Taranov
2026-09-03 16:03           ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260903160317.-6L7VXXK@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=andrealmeid@igalia.com \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nickita.taranov@gmail.com \
    --cc=peterz@infradead.org \
    --cc=regressions@lists.linux.dev \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®