From: Chris Babroski <cbabroski@nvidia.com>
To: <andi.shyti@kernel.org>, <linux-i2c@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <cbabroski@nvidia.com>, <davthompson@nvidia.com>
Subject: [PATCH v1 0/3] i2c: mlxbf: Fix master GW corruption
Date: Thu, 3 Sep 2026 15:19:58 -0400 [thread overview]
Message-ID: <20260903192001.114263-1-cbabroski@nvidia.com> (raw)
This patch series fixes a bug that corrupts the slave address used in read
phases and cleans up the code to prevent similar corruption scenarios from
occurring in the future.
When the MLXBF_I2C_F_SMBUS_BLOCK and/or MLXBF_I2C_F_SMBUS_PEC flags are set, the
flag bitmask values are shifted and written to the master gateway control
register instead of the single-bit flag values. This caused slave address
corruption in read phases (unlike write phases which use the data_desc[0] slave
address value).
Patch 1 fixes this corruption issue by converting the flags to booleans before
setting their values in the control register.
Patch 2 converts register field accesses from explicit shifts to
BIT()/GENMASK()/FIELD_PREP().
Patch 3 removes an unnecessary register write (dead code).
Chris Babroski (3):
i2c: mlxbf: Fix master GW corruption from unmasked SMBus flags
i2c: mlxbf: Use GENMASK()/FIELD_PREP() for GW fields
i2c: mlxbf: Remove unused slave GW PEC handling
drivers/i2c/busses/i2c-mlxbf.c | 40 +++++++++++++++++-----------------
1 file changed, 20 insertions(+), 20 deletions(-)
--
2.34.1
next reply other threads:[~2026-09-03 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 19:19 Chris Babroski [this message]
2026-09-03 19:19 ` [PATCH v1 1/3] i2c: mlxbf: Fix master GW corruption from unmasked SMBus flags Chris Babroski
2026-09-03 19:20 ` [PATCH v1 2/3] i2c: mlxbf: Use GENMASK()/FIELD_PREP() for GW fields Chris Babroski
2026-09-03 19:20 ` [PATCH v1 3/3] i2c: mlxbf: Remove unused slave GW PEC handling Chris Babroski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903192001.114263-1-cbabroski@nvidia.com \
--to=cbabroski@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=davthompson@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®