mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Diego Fernando Mancera Gomez <diegomancera.dev@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, lkp@intel.com
Subject: [PATCH] uio: fsl_elbc_gpcm: preserve platform_get_irq() errors
Date: Thu,  3 Sep 2026 19:25:11 -0600	[thread overview]
Message-ID: <20260904012511.191397-1-diegomancera.dev@gmail.com> (raw)

In uio_fsl_elbc_gpcm_probe(), platform_get_irq() returns a negative errno
on failure. Because irq is declared as unsigned int, the error check
if (irq < 0) is never satisfied and negative error codes (such as
-EPROBE_DEFER) bypass the error handling.

Change the local irq declaration from unsigned int to int so negative
errors from platform_get_irq() reach the error check and are properly
returned.

Fixes: c8295feb756f ("uio: fsl_elbc_gpcm: use platform helpers for resource and IRQ")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202608011915.yZ4ITuSe-lkp@intel.com/
Signed-off-by: Diego Fernando Mancera Gomez <diegomancera.dev@gmail.com>
---
 drivers/uio/uio_fsl_elbc_gpcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/uio/uio_fsl_elbc_gpcm.c b/drivers/uio/uio_fsl_elbc_gpcm.c
index 08cb150fb12f..e6394dd14e43 100644
--- a/drivers/uio/uio_fsl_elbc_gpcm.c
+++ b/drivers/uio/uio_fsl_elbc_gpcm.c
@@ -303,7 +303,7 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_device *pdev)
 	char *uio_name = NULL;
 	struct resource *res;
 	void __iomem *base;
-	unsigned int irq;
+	int irq;
 	u32 reg_br_cur;
 	u32 reg_or_cur;
 	u32 reg_br_new;
-- 
2.55.0


                 reply	other threads:[~2026-09-04  1:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260904012511.191397-1-diegomancera.dev@gmail.com \
    --to=diegomancera.dev@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®