From: Arie Miller <renari@arimil.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Aleksa Savic <savicaleksa83@gmail.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
Arie Miller <renari@arimil.com>
Subject: [PATCH 0/2] hwmon: Fix ASUS ROG Ryujin HID report handling
Date: Thu, 3 Sep 2026 22:21:27 -0400 [thread overview]
Message-ID: <20260904022129.97896-1-renari@arimil.com> (raw)
A Sashiko review found two pre-existing issues in the ASUS ROG Ryujin
driver: missing HID report length validation and a race between completion
updates and reinitialization.
Reject undersized reports and serialize both paths with the existing
spinlock.
Tested on an ASUS ROG Ryujin III EVA using a DKMS-built module with 16,000
concurrent hwmon reads and 50 liquidctl status requests over hidraw. No
failures, timeouts, lock warnings, or HID errors were observed.
Arie Miller (2):
hwmon: (asus_rog_ryujin) Validate HID report lengths
hwmon: (asus_rog_ryujin) Synchronize HID command and report handling
drivers/hwmon/asus_rog_ryujin.c | 30 +++++++++++++++++++++++++-----
1 file changed, 25 insertions(+), 5 deletions(-)
--
2.55.0
next reply other threads:[~2026-09-04 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 2:21 Arie Miller [this message]
2026-09-04 2:21 ` [PATCH 1/2] hwmon: (asus_rog_ryujin) Validate HID report lengths Arie Miller
2026-09-04 2:21 ` [PATCH 2/2] hwmon: (asus_rog_ryujin) Synchronize HID command and report handling Arie Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904022129.97896-1-renari@arimil.com \
--to=renari@arimil.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=savicaleksa83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®