From: Tao Cui <cui.tao@linux.dev>
To: axboe@kernel.dk, Tang Yizhou <tangyeechou@gmail.com>
Cc: tj@kernel.org, josef@toxicpanda.com, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cuitao@kylinos.cn, cui.tao@linux.dev,
Tang Yizhou <yizhou.tang@shopee.com>
Subject: [PATCH v2] blk-cgroup: show io.stat numbers for discard-only cgroups
Date: Fri, 4 Sep 2026 15:16:19 +0800 [thread overview]
Message-ID: <20260904071619.1283221-1-cui.tao@linux.dev> (raw)
From: Tao Cui <cuitao@kylinos.cn>
blkcg_print_one_stat() gates the rbytes/wbytes/rios/wios/dbytes/dios
output on
if (rbytes || wbytes || rios || wios)
which omits the discard counters. A cgroup that has issued only discards
(zero read and write counters) therefore prints an empty stat line and its
dbytes/dios are never surfaced, even though they are accounted correctly.
The guard predates the addition of discard stats and was never updated;
include dbytes/dios so discard-only cgroups are reported.
Fixes: 636620b66d5d ("blkcg: Track DISCARD statistics and output them in cgroup io.stat")
Signed-off-by: Tao Cui <cuitao@kylinos.cn>
Reviewed-by: Tang Yizhou <yizhou.tang@shopee.com>
---
Changes in v2:
- Rebase onto current linux-next head (no code change).
- Add the Reviewed-by tag collected on v1 (Tang Yizhou).
- Link to v1: https://lore.kernel.org/r/20260714063302.1153238-1-cui.tao@linux.dev
---
block/blk-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 471cfd2347c9..7b48cd1db13d 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -1160,7 +1160,7 @@ static void blkcg_print_one_stat(struct blkcg_gq *blkg, struct seq_file *s)
dios = bis->cur.ios[BLKG_IOSTAT_DISCARD];
} while (u64_stats_fetch_retry(&bis->sync, seq));
- if (rbytes || wbytes || rios || wios) {
+ if (rbytes || wbytes || rios || wios || dbytes || dios) {
seq_printf(s, "rbytes=%llu wbytes=%llu rios=%llu wios=%llu dbytes=%llu dios=%llu",
rbytes, wbytes, rios, wios,
dbytes, dios);
--
2.43.0
reply other threads:[~2026-09-04 7:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904071619.1283221-1-cui.tao@linux.dev \
--to=cui.tao@linux.dev \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=cuitao@kylinos.cn \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangyeechou@gmail.com \
--cc=tj@kernel.org \
--cc=yizhou.tang@shopee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®