From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 350A141D13D for ; Fri, 4 Sep 2026 08:44:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788511452; cv=none; b=ZF7djnP+Y6VgfbVSKPT59LYIViGuCDlsLw8OWQFca7ul8ChDFOCZnnWLN6AdrJsEl1LpezaviQTCMCdZgfkWhkKudNglzU1gJi2Jh6Ee4f6Sst9Zcac3weM/dNSY4N3WKabfAU+28ZL0K0jXNjf04yJ3nnFuiGXhJ3ykqwJs0Ws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788511452; c=relaxed/simple; bh=GKxlf1sAAAtK88H6DAU3sh0iIYsWYsT2IYOx5SXsE3A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XjT1Gydm7ZxmXsIWQFepPLbUJKM84JETKcI0jmjhNryaD41dngI8116BMa7UDLZuo5ZIRVwpZGuHwNP+rwhNSkQIbQ4am3tRR/25jKOQJsJWokE1kS4e2c4BxXLIrsWn9+IfouknrJobOdJMo1xrUuVUyIw8wL6BoANM95t7JIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=VdY0iG85; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VdY0iG85" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-398e9698a70so665795a91.0 for ; Fri, 04 Sep 2026 01:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1788511447; x=1789116247; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xFmIb/8YvdtZL49BMQqQktnO00n+EPHrLzK7Dg1eMRc=; b=VdY0iG85RNkm9SkCaEqHCBCPJvjQCFRiRTVVxyJRlLXY6gFLiobguT2Ne1w6cUvCEM D3gEkgdol74YqaYwgxJXUdsCppnNHpFiUmzVvQrESERRM8iklThb3xVXk/Rppwa7UjPv +vVBhxRX6VVvPxyF1/pgk2dEHHC2eEOOggwpo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788511447; x=1789116247; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xFmIb/8YvdtZL49BMQqQktnO00n+EPHrLzK7Dg1eMRc=; b=XiBSWYi5KKosnvLNCJ8lI9kImaGHXrEGgeHaB6C/x/V0tcISRFyxpI1wjMfZoDJuJF sp1cXKbdauCkkyh46YLwyeYINzTdfK6Xd3il1ASGzamCrUngsk9LdrrmxRJZDaUkkbAk 4JtjEUmNsc4U0y+A4txZQKZFuzI0RlKDYgHqqgQ0fLbBwKiUbx+TYSj64YMI/G8vwp7x GjOm38fADCKMMWD0LXjA9PkYRG6+CI2InN3YYO8FavexF6CkBYgoc6QwXFoklfM8rXbq zBmys6+Er6BT2Ss8ThvW9vrhatyDeMrqi5XlHo1s+utNrWuwVCsSg2jYd9YFNgfMgQ1c PEeA== X-Forwarded-Encrypted: i=1; AKwUvBwRc8W5r3PfAg9Q8xvE3S2KMX2UGjZUMQVzzQZZoOVIGENfAOwSmWdySOppr6Iq8BMa2ELj0dW8kOKzwjA=@vger.kernel.org X-Gm-Message-State: AFuF++nZa7ENmwi2EclH7Sp/hJidx3d6+eam6i3dqqi0ivA7mM+f9Mfk YoV1Lf+P0eZRNjRaGUeqV3/tkek2Zu9jichE6WGMbhYbMqN79LoOtgKtkLmH437SeQ== X-Gm-Gg: AYBFou09GmFSz05CD2X91MyQYNdjYVDuhlXAPtthk2d/IxC2gepkgdfJ1BzdNEcRzsi bAveowAreaq53HxBGBAKGxMhXv0zWHeS84U5GwkVukchq9YVeq6gbQ8LdW63jlsitMny7CZVLuw s8pm2kzrIUXDJZWLp6Z5lwyWcOx5deAZT7mcOHo6kthIuzdzAbwZlm8YE7qeP6PqyXaPAiuHyBn G6OmD89ptnk0yBY5+4MJvt+l1MRuoJf8DWCJl8K+hpBFo79K43RbXekaWor1BI1h95RxQor863R 22ckyDWDAkIAC+DZqrEZwuepe8wqmgCuHSvF+NVssALyCY2wgM7hSVpqmzVXDwGOonRVP5QJhpc /miFukbuDwKHTd/giDEOe2x/6UWre6xANfyunm3j3GVxtW33mKgkGLeB7AaUdQ9qDGM7U0X6t81 mQkGhNKKnlbFQOr4F2iv48eE4huB8Ph5wau2tmSZ1lVliZKDKxbY4pLYFjyz5PCd4Oqhh2HWATE FW0mXaXpGmBK+uUOEqGQ9U/pAxu0aR679Bz6CJOEaYZ X-Received: by 2002:a17:90b:2d0b:b0:398:c794:ca26 with SMTP id 98e67ed59e1d1-39b263167f7mr7127157a91.25.1788511447090; Fri, 04 Sep 2026 01:44:07 -0700 (PDT) Received: from wenst-7875.tpe.corp.google.com ([2a00:79e0:201d:8:343:bf21:3095:9c5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b260fdf9asm3343538a91.9.2026.09.04.01.44.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 01:44:06 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Wei Deng , Konrad Dybcio , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v8 09/16] usb: hub: Use usb_hub_set_port_power() to control port power everywhere Date: Fri, 4 Sep 2026 16:41:48 +0800 Message-ID: <20260904084158.1341550-10-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.979.g7e5102b832-goog In-Reply-To: <20260904084158.1341550-1-wenst@chromium.org> References: <20260904084158.1341550-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are still some instances in the USB hub driver where port power is directly controlled by toggling the USB_PORT_FEAT_POWER feature flag. Switch these instances over to usb_hub_set_port_power() so that only one unified function to do this exists. This makes adding external power control with the power sequencing API easier and consistently applied. Reviewed-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Signed-off-by: Chen-Yu Tsai --- Changes since v2: - New patch --- drivers/usb/core/hub.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 1b891088a653..b7991eb53197 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -976,11 +976,8 @@ static void hub_power_on(struct usb_hub *hub, bool do_delay) dev_dbg(hub->intfdev, "trying to enable port power on " "non-switchable hub\n"); for (port1 = 1; port1 <= hub->hdev->maxchild; port1++) - if (test_bit(port1, hub->power_bits)) - set_port_feature(hub->hdev, port1, USB_PORT_FEAT_POWER); - else - usb_clear_port_feature(hub->hdev, port1, - USB_PORT_FEAT_POWER); + usb_hub_set_port_power(hub->hdev, hub, port1, + test_bit(port1, hub->power_bits)); if (do_delay) msleep(hub_power_on_good_delay(hub)); } @@ -5440,7 +5437,7 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus, if (hub_is_port_power_switchable(hub) && !usb_port_is_power_on(port_dev, portstatus) && !port_dev->port_owner) - set_port_feature(hdev, port1, USB_PORT_FEAT_POWER); + usb_hub_set_port_power(hdev, hub, port1, true); if (portstatus & USB_PORT_STAT_ENABLE) goto done; -- 2.55.0.979.g7e5102b832-goog