From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A8D132B112 for ; Fri, 4 Sep 2026 13:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527374; cv=none; b=fmZcUVsSAVb/3ZlOOnscll7cWHR0YlzCNHSog41qxKZUWsx0LkP1P3dlctsb2E+gok991u4aAeWey/SZxYAGQXYzuRVFzW0x9/aeY4iKapibLRzO/wOLNrXXjW3SGkRS8pqiiUKm0e48sqMNTFxI6YENCQsYhbSWAWO8k757ojY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788527374; c=relaxed/simple; bh=n0grn4S6vKiAtGhBq6W727/5/lW0S4rqzuGh21UW2MY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lghFkMMZfpNx8wqC+YZ3usDJNdSAdhZXtdABd0AW1514bbylrOnM6PI4gemzLztJ7xRJ6r6RQ9i38KMLNJY0m/lSC2deMQw2ctuFlCFrMECWNBpcFvqNetAWjeVmCEUqg/Bkmk8YUvzTQT3+sbhx9qY0VMbs5ngbX8hhRzshIuc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L/of0B1h; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L/of0B1h" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-482e7093e75so131686f8f.1 for ; Fri, 04 Sep 2026 06:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788527370; x=1789132170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0Nc493Zxn3lB2uIUk0uEHaMMSyj53T93ezhvvuGgReI=; b=L/of0B1hbxlldHquHgfbS1bCXKJRdF4ZE9AZYGhFPZXJbW5SzMqTpMsDoor4k7oZXY /3j7BmRFcPaA8bgIG4nQhpFsN7J0hfA++Bum9LTXB8FQ1rIL7Jhc+lXC1EtU9H1zdgT8 n5gqpYt3RWrJt3ogD7p/6LEb25B/3ZSvEcHOc/zDKnKWngdWoK/YhsLTCVLdQx8ne66E d6Zfcv+MU3lgmTV8/S+Z0tpy6buRUtMT9BO4C8hGYFJK01/cErfO9ol6cFGPKpC4JYe1 KENrgrXaFXa+J6kA/uGkgP1D4FtECHagMSDdbSDOULfmP51SJGkhjhHE0C302I+8HRX/ kzsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788527370; x=1789132170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0Nc493Zxn3lB2uIUk0uEHaMMSyj53T93ezhvvuGgReI=; b=VfYC+aWxO7XX/6xXuieJ3NBFGqF5WaYun7e4yvjufQlSDmmq9+z5A2+CS9rS4XCRu1 AtaC29GeUcGY9Ii+8fKG4xBU8zH+v/wSsm5EnxDHp++RyTDhLNvvkjpkyOXhkchZ6IZJ 1em7A+UEVKbtHu67FEF9uSgUFgxZYDE6XvMFP4q0V7K/u9sY7f5LNWvjYGHGA0urxia5 lO1xuzWm109JEdyCe7sgrVLsHWI944tCP7rbDDd5Ouzx+3l/2UcPdtYKPyREqvcvB4yA HD1YpTGgMsfmQskhQTEcL+Wb43jSvvR2kokWNhZTFeecbBj8YeStUg7RWq/3Aw9Dth3y Aqeg== X-Forwarded-Encrypted: i=1; AKwUvByhSzP3959xsCKBphi2Wbb2uhMV8g5Q1ZwPYKcJShbJ40Uynj9WTGHh+ss04FBxObJ/zeBxpYtcCADpLSY=@vger.kernel.org X-Gm-Message-State: AFuF++mjBrhoX4WqfTSq3zmPBY2h2kZnbEGaJHD8kGtu+CsxlNJmx00t WhroUzS5o2di/cGusq7X9BLC+lX5V6s1YkmQTg0HV+NxiEu/KQS22Ih2zwvcXA== X-Gm-Gg: AYBFou0jsKrfF1NNuE+ShkRqAQKQ0qAA5eJfvaMCpfzQ8qLZ8onteSSwsuuXG1jNhKa OMyq1CBq4a89r8iVhwWdz2IOBK/AXEJtDPFxTQEX+a+Q4VrJ/SKkeTetmm8duGHAeU7yIa37HMp JkhemWUNr23e8mo5LA4QL9IaJi3TAmHXv3A1ff4dDC+KBazDUrw8Q2Lgq1/l6ExYoOiNjJ0/lvH lPMRy3bn3KfUyKBSuBoB/H55dH/qboh70q8bfEAg3O85hIqUr+d2EI/WTlvFGv1tcA4Go3Z0LpP JpxWBRNjDQm+QtmWlXAp6uVJI1jQqf3J1h9e4i/r1dXhCDeMzvuMaTRFYReDQO8EfWU+nalDiPc Swed/Hd7/lC6OyEZYr+2TQ8GeddhYmjActqWDY5KoAU5jHamQI9nYHHWCl2uxnhv2Y+fbSypr/d d1qVJl+ux7RxL3KtIOmmyASNCeE9jJxBBbcpcebQWZSFQnBMAF2XbEoCSmogZCij0ohzKVWVD8h ad1olNAVOVGFEyGHgZS/pPOQnTTdkPRhS+CWr8VKJYp4JpqvOsZUHwvr9zIbhkILzZ9 X-Received: by 2002:a05:600c:1d26:b0:49c:cbf4:572b with SMTP id 5b1f17b1804b1-49cf8245fe1mr47842485e9.2.1788527370519; Fri, 04 Sep 2026 06:09:30 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B871500CB6EF488A18F9C42.dsl.pool.telekom.hu. [2001:4c4e:1b87:1500:cb6e:f488:a18f:9c42]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce554d52esm135575435e9.3.2026.09.04.06.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 06:09:29 -0700 (PDT) From: Igor Paunovic To: Tomeu Vizoso , Oded Gabbay , Heiko Stuebner Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sidong Yang , Diederik de Haas , Sebastian Reichel , Jiaxing Hu , Nicolas Dufresne , Jonas Karlman , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Paunovic Subject: [PATCH 4/7] accel/rocket: restore the NPU clock boot rate before powering the cores down Date: Fri, 4 Sep 2026 15:08:55 +0200 Message-ID: <20260904130858.27803-5-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260904130858.27803-1-royalnet026@gmail.com> References: <20260904130858.27803-1-royalnet026@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The compute clock is generated by a PVTPLL that lives inside the NPU power island. Powering an island up while that clock is above the rate the bootloader left it at does not work: the domain never acks the power-on, and the first register access into it afterwards takes an asynchronous SError. So the rate has to be back down before the last core goes away. Nothing in the driver raises the clock today, which makes this a no-op on its own, but it is the guard that has to be in the tree before anything does, and the next patches do. The .shutdown hook is the same guard for the handover: once devfreq is driving the clock, a reboot or a kexec would otherwise pass the raised rate to the next kernel, which powers the islands up before it looks at it. What this cannot do is rescue a rate it did not set - the rate read at probe is taken as the boot rate whatever it is. The rate is read at probe rather than hardcoded. Mainline pins the RK3588 cores at 200 MHz with assigned-clock-rates, but that is a devicetree property, not a property of the hardware, and a SoC whose devicetree does not set it would be left running at a rate this driver had invented. All three cores share the clock, so only the last core to suspend may lower it; the others just drop the count. Lowering it is safe with the islands already down, because the firmware serves the boot rate from GPLL and writes only CRU clock selectors to get there, never a register inside the NPU. Signed-off-by: Igor Paunovic Assisted-by: LLM sparse checkpatch --- drivers/accel/rocket/rocket_core.c | 12 +++++++++ drivers/accel/rocket/rocket_device.h | 10 +++++++ drivers/accel/rocket/rocket_drv.c | 40 ++++++++++++++++++++++++++++ 3 files changed, 62 insertions(+) diff --git a/drivers/accel/rocket/rocket_core.c b/drivers/accel/rocket/rocket_core.c index 5dd260bacbff6..61200e5d5ac0d 100644 --- a/drivers/accel/rocket/rocket_core.c +++ b/drivers/accel/rocket/rocket_core.c @@ -12,6 +12,7 @@ #include #include "rocket_core.h" +#include "rocket_device.h" #include "rocket_job.h" int rocket_core_init(struct rocket_core *core) @@ -36,6 +37,17 @@ int rocket_core_init(struct rocket_core *core) if (err) return dev_err_probe(dev, err, "failed to get clocks for core %d\n", core->index); + /* + * Record what the compute clock was running at before anything here + * touched it, on the first core to probe. Reading it rather than + * hardcoding a rate keeps this working on a SoC whose devicetree does + * not pin the clock with assigned-clock-rates. + */ + if (!core->rdev->npu_clk) { + core->rdev->npu_clk = core->clks[2].clk; + core->rdev->npu_boot_rate = clk_get_rate(core->rdev->npu_clk); + } + core->pc_iomem = devm_platform_ioremap_resource_byname(pdev, "pc"); if (IS_ERR(core->pc_iomem)) { dev_err(dev, "couldn't find PC registers %ld\n", PTR_ERR(core->pc_iomem)); diff --git a/drivers/accel/rocket/rocket_device.h b/drivers/accel/rocket/rocket_device.h index c62d567010696..466ebc4c26a8a 100644 --- a/drivers/accel/rocket/rocket_device.h +++ b/drivers/accel/rocket/rocket_device.h @@ -20,6 +20,16 @@ struct rocket_device { struct rocket_core *cores; unsigned int num_cores; unsigned int max_cores; + + /* + * The cores have no clock of their own: one clock feeds all of them, + * so any core's handle refers to the same thing. npu_boot_rate is the + * rate it was left at before the driver touched it, and active_cores + * counts the cores that are runtime resumed right now. + */ + struct clk *npu_clk; + unsigned long npu_boot_rate; + atomic_t active_cores; }; struct rocket_device *rocket_device_init(struct platform_device *pdev, diff --git a/drivers/accel/rocket/rocket_drv.c b/drivers/accel/rocket/rocket_drv.c index 2bcfe4ab3c68f..b7199de57ccc7 100644 --- a/drivers/accel/rocket/rocket_drv.c +++ b/drivers/accel/rocket/rocket_drv.c @@ -231,6 +231,28 @@ static int find_core_for_dev(struct device *dev) return -1; } +/* + * Put the compute clock back where the bootloader had it. The cores share + * this clock, so this is only correct once none of them is running any more. + * + * Lowering the rate is safe with the power islands down: the firmware serves + * the boot rate from GPLL and touches only the CRU clock selectors on the way + * there, none of the NPU's own registers. + */ +static void rocket_npu_restore_boot_rate(struct rocket_device *rdev) +{ + int err; + + if (!rdev->npu_clk) + return; + + err = clk_set_rate(rdev->npu_clk, rdev->npu_boot_rate); + if (err) + dev_warn(rdev->cores[0].dev, + "failed to restore the NPU boot rate of %lu Hz: %d\n", + rdev->npu_boot_rate, err); +} + static int rocket_device_runtime_resume(struct device *dev) { struct rocket_device *rdev = dev_get_drvdata(dev); @@ -246,6 +268,8 @@ static int rocket_device_runtime_resume(struct device *dev) return err; } + atomic_inc(&rdev->active_cores); + return 0; } @@ -262,6 +286,9 @@ static int rocket_device_runtime_suspend(struct device *dev) clk_bulk_disable_unprepare(ARRAY_SIZE(rdev->cores[core].clks), rdev->cores[core].clks); + if (atomic_dec_and_test(&rdev->active_cores)) + rocket_npu_restore_boot_rate(rdev); + return 0; } @@ -270,9 +297,22 @@ EXPORT_GPL_DEV_PM_OPS(rocket_pm_ops) = { SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) }; +/* + * A kexec or a reboot hands the next kernel whatever rate is set here, and + * that kernel will power the islands up before it looks at the clock. + */ +static void rocket_shutdown(struct platform_device *pdev) +{ + struct rocket_device *rdev = dev_get_drvdata(&pdev->dev); + + if (rdev) + rocket_npu_restore_boot_rate(rdev); +} + static struct platform_driver rocket_driver = { .probe = rocket_probe, .remove = rocket_remove, + .shutdown = rocket_shutdown, .driver = { .name = "rocket", .pm = pm_ptr(&rocket_pm_ops), -- 2.43.0