From: Diederik de Haas <diederik@cknow-tech.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Andreas Kemnade <andreas@kemnade.info>,
Yufan Chen <ericterminal@gmail.com>,
Surendra Singh Chouhan <kr494167@gmail.com>,
Mario Rugiero <mrugiero@gmail.com>,
linux-rockchip@lists.infradead.org,
Diederik de Haas <diederik@cknow-tech.com>
Subject: [PATCH] regulator: tps65185: Remove redundant dev_err_probe()
Date: Fri, 4 Sep 2026 16:46:31 +0200 [thread overview]
Message-ID: <20260904144728.1629471-1-diederik@cknow-tech.com> (raw)
The devm_request_threaded_irq() function now automatically logs detailed
error messages on failure. This eliminates the need for driver-specific
dev_err_probe() calls that print generic messages.
Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
---
drivers/regulator/tps65185.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/tps65185.c b/drivers/regulator/tps65185.c
index 6a3130177e7a..4865227e444a 100644
--- a/drivers/regulator/tps65185.c
+++ b/drivers/regulator/tps65185.c
@@ -392,8 +392,7 @@ static int tps65185_probe(struct i2c_client *client)
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
"PGOOD", data);
if (ret)
- return dev_err_probe(&client->dev, ret,
- "failed to request power good irq\n");
+ return ret;
if (client->irq) {
ret = devm_request_threaded_irq(&client->dev, client->irq,
@@ -401,8 +400,7 @@ static int tps65185_probe(struct i2c_client *client)
IRQF_TRIGGER_LOW | IRQF_ONESHOT,
"tps65185", data);
if (ret)
- return dev_err_probe(&client->dev, ret,
- "failed to request irq\n");
+ return ret;
}
ret = regmap_update_bits(data->regmap, TPS65185_REG_INT_EN2, BIT(0), BIT(0));
--
2.55.0
next reply other threads:[~2026-09-04 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 14:46 Diederik de Haas [this message]
2026-09-04 16:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904144728.1629471-1-diederik@cknow-tech.com \
--to=diederik@cknow-tech.com \
--cc=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=ericterminal@gmail.com \
--cc=kr494167@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mrugiero@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®