From: Jakub Kicinski <kuba@kernel.org>
To: Dong Yibo <dong100@mucse.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, vadim.fedorenko@linux.dev,
u.kleine-koenig@baylibre.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, yaojun@mucse.com
Subject: Re: [PATCH net-next v10 1/5] net: rnpgbe: Add interrupt handling
Date: Fri, 4 Sep 2026 14:54:10 -0700 [thread overview]
Message-ID: <20260904145410.67b6877f@kernel.org> (raw)
In-Reply-To: <F44E6669E6C9E7C4+20260831073608.401988-2-dong100@mucse.com>
On Mon, 31 Aug 2026 15:36:04 +0800 Dong Yibo wrote:
> +/**
> + * rnpgbe_int_single - MSI-X single-vector/MSI interrupt handler
> + * @irq: interrupt number
> + * @data: private data
> + *
> + * Return: IRQ_HANDLED
> + **/
> +static irqreturn_t rnpgbe_int_single(int irq, void *data)
> +{
> + struct mucse *mucse = (struct mucse *)data;
> + struct mucse_q_vector *q_vector;
> +
> + queue_work(system_percpu_wq, &mucse->mbx_work);
> +
> + if (test_bit(__MUCSE_DOWN, &mucse->state))
> + return IRQ_HANDLED;
> +
> + q_vector = mucse->q_vector[0];
> + rnpgbe_irq_disable_queues(q_vector);
> + napi_schedule_irqoff(&q_vector->napi);
> +
> + return IRQ_HANDLED;
> +}
It's not reasonable to have a single IRQ handle datapath and also
unconditionally queue a mbox work item. Just require at least 2 IRQs.
next prev parent reply other threads:[~2026-09-04 21:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260831073608.401988-1-dong100@mucse.com>
2026-08-31 7:36 ` Dong Yibo
2026-09-04 21:54 ` Jakub Kicinski [this message]
2026-08-31 7:36 ` [PATCH net-next v10 2/5] net: rnpgbe: Add basic TX packet transmission support Dong Yibo
2026-09-04 21:57 ` Jakub Kicinski
2026-08-31 7:36 ` [PATCH net-next v10 3/5] net: rnpgbe: Add RX packet reception support Dong Yibo
2026-09-04 21:57 ` Jakub Kicinski
2026-08-31 7:36 ` [PATCH net-next v10 4/5] net: rnpgbe: Add receive mode support Dong Yibo
2026-09-04 21:57 ` Jakub Kicinski
2026-08-31 7:36 ` [PATCH net-next v10 5/5] net: rnpgbe: Add link status handling support Dong Yibo
2026-09-04 21:57 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904145410.67b6877f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dong100@mucse.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=vadim.fedorenko@linux.dev \
--cc=yaojun@mucse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®