Re: [PATCH] [net-next, v2] selftest/net: skip srv6_end_dt[4/6]_l3vpn_test.sh if vrftable not available

[Andrea Mayer <andrea.mayer@uniroma2.it>]

On Thu,  3 Sep 2026 12:35:45 +0200
Alessio Faina <alessio.faina@canonical.com> wrote:

Hi Alessio,

Thanks for the v2. The check looks good to me. The comments below are
all on the commit message and on the subject.

> In case iproute2 is older than version 5.11.0, released ~Feb 23, 2021,
> the vrftable support is not available and the tests
> contained in the following 4 test files
>  - srv6_end_dt4_l3vpn_test.sh
>  - srv6_end_dt6_l3vpn_test.sh
> are failing in some kernel backports.

Two files now, not four.

> This is the result of one those tests in an unsupported environment:
> 
> \################################################################################
> \TEST SECTION: SRv6 VPN connectivity test among hosts in the same tenant
> \################################################################################
> \
> \    TEST: Hosts connectivity: hs-t100-1 -> hs-t100-2 (tenant 100)       [FAIL]
> \
> \    TEST: Hosts connectivity: hs-t100-2 -> hs-t100-1 (tenant 100)       [FAIL]
> \
> \    TEST: Hosts connectivity: hs-t200-3 -> hs-t200-4 (tenant 200)       [FAIL]
> \
> \    TEST: Hosts connectivity: hs-t200-4 -> hs-t200-3 (tenant 200)       [FAIL]
> \
> 
> To amend this, check the current running iproute2 supports the vrftable
> feature and, if not, just skip the entire test to avoid a failure.

IMO the sentence could say what the check does: it installs a route
with the vrftable feature, and skips the test rather than failing when
the feature is not supported.

> v2: - remove dx[4/6] tests
>     - test if vrftable is available in the installed iproute2 application
> v1: https://patchwork.kernel.org/project/netdevbpf/patch/20260824091537.2305107-1-alessio.faina@canonical.com/
>     - initial approach by testing DT[4/6] and DX[4/6]
>     - test if DT4/DT6 are available in iproute2
> 
> Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
> ---
> 
> [snip]

The changelog goes under the ---. checkpatch reports it too.

Since the commit message needs to be revised anyway, a few nits:

i)   The subject came as [PATCH] [net-next, v2] instead of
     [PATCH net-next v2]. And maybe you meant selftests/net: ?
ii)  "one those tests" -> "one of those tests" ?
iii) The backslashes in the pasted log could go, git does not remove
     them and they stay in the commit message.

Ciao,
Andrea