From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bradley Morgan <brads@mainlining.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Waiman Long <longman@redhat.com>,
Christian Brauner <brauner@kernel.org>,
Kees Cook <kees@kernel.org>, Andy Walls <awalls@md.metrocast.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jiri Slaby <jirislaby@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-media@vger.kernel.org, netdev@vger.kernel.org,
linux-serial@vger.kernel.org, linux-pm@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH v2 0/5] kthread: convert remaining users to kthread_create_worker
Date: Sat, 5 Sep 2026 19:10:56 +0200 [thread overview]
Message-ID: <2026090500-seventh-come-270c@gregkh> (raw)
In-Reply-To: <6F579B00-7B91-49F4-99FF-5F31E844355C@mainlining.org>
On Sat, Sep 05, 2026 at 01:55:35PM +0100, Bradley Morgan wrote:
> On 5 September 2026 12:19:54 BST, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >On Fri, Sep 04, 2026 at 10:13:32PM +0100, Bradley Morgan wrote:
> >> On 4 September 2026 22:10:32 BST, Jakub Kicinski <kuba@kernel.org>
> >wrote:
> >> >On Fri, 04 Sep 2026 16:56:30 +0100 Bradley Morgan wrote:
> >> >> On 4 September 2026 16:54:18 BST, Jakub Kicinski <kuba@kernel.org>
> >> >wrote:
> >> >> >On Fri, 4 Sep 2026 09:37:21 +0000 Bradley Morgan wrote:
> >> >> >> media: ivtv: convert to kthread_run_worker
> >> >> >> net: encx24j600: convert to kthread_run_worker
> >> >> >> tty: sc16is7xx: convert to kthread_run_worker
> >> >> >> cpufreq: schedutil: convert to kthread_create_worker
> >> >> >
> >> >> >Please send these 4 to appropriate subsystems
> >> >> >
> >> >> >> kthread: remove worker->task self assignment
> >> >> >
> >> >> >Then after the next merge window when trees converge send this one
> >out
> >> >>
> >> >> hi, I was hoping one person could merge it with acks from all
> >subsystems
> >> >
> >> >Not how this works.
> >> Ugh, I've seen it before happen.
> >>
> >> Look, fine, I'll do a V3 soon, WITH ONLY the subsystem changes, all
> >> separate, all sent over to their respective maintainers, then when all
> >> thathas been merged and there's the next merge window, then whatever,
> >I'll
> >> send then the kthread removal
> >>
> >> IMHO this is a massive annoyance though.. because what if one of the
> >> driverfolks doesn't wanna respond to me!?!
> >
> >Then, after trying for the normal way, you can make the driver change at
> >the same time. But to circumvent the "normal way" thinking it might not
> >work, is not the best thing to do.
> >
>
> Greg!
>
> Right, okay, Ill tell you more.
>
> For features being added, where many drivers from different subsystems get
> covered at once, what they tend to do is:
>
> A: send all patches, rely on all maintainers to merge their own crap, which is a mess
>
> B: Have a designated merger, who merges all the changes at once, no chance of regression because it's all bundled up.
>
>
> C: send drivers first, then send the feature. So then driver maintainers can merge their crap, then the main feature gets merged in merge window
>
> I prefer B, because it's easier that way, akpm is usually des merger hence
> I CCed him.
>
> Or tip tree?
>
> Honestly, if I had to be honest, C is a very annoying way, because of what
> I said above, if driver maintainer thinks I'm some newbie idiot or
> something, then what will I do? He won't merge it!
To quote a longtime kernel developer years ago, "Kernel development is
hard, let's go shopping."
Sorry, but yes, it can be difficult to touch cross-subsystem stuff like
this, always has been. Just be patient.
good luck!
greg k-h
next prev parent reply other threads:[~2026-09-05 17:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 9:37 Bradley Morgan
2026-09-04 9:37 ` [PATCH v2 1/5] media: ivtv: convert to kthread_run_worker Bradley Morgan
2026-09-04 10:44 ` Bradley Morgan
2026-09-04 9:40 ` [PATCH v2 2/5] net: encx24j600: " Bradley Morgan
2026-09-04 9:40 ` [PATCH v2 4/5] cpufreq: schedutil: convert to kthread_create_worker Bradley Morgan
2026-09-04 9:40 ` [PATCH v2 3/5] tty: sc16is7xx: convert to kthread_run_worker Bradley Morgan
2026-09-04 9:40 ` [PATCH v2 5/5] kthread: remove worker->task self assignment Bradley Morgan
2026-09-05 14:37 ` kernel test robot
2026-09-05 14:50 ` Bradley Morgan
2026-09-05 15:11 ` kernel test robot
2026-09-04 15:54 ` [PATCH v2 0/5] kthread: convert remaining users to kthread_create_worker Jakub Kicinski
2026-09-04 15:56 ` Bradley Morgan
2026-09-04 21:10 ` Jakub Kicinski
2026-09-04 21:13 ` Bradley Morgan
2026-09-05 11:19 ` Greg Kroah-Hartman
2026-09-05 12:55 ` Bradley Morgan
2026-09-05 17:10 ` Greg Kroah-Hartman [this message]
2026-09-05 17:56 ` Bradley Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026090500-seventh-come-270c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=awalls@md.metrocast.net \
--cc=brads@mainlining.org \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=dietmar.eggemann@arm.com \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=jirislaby@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®