From: Jakub Kicinski <kuba@kernel.org>
To: Kees Cook <kees@kernel.org>
Cc: syzbot+628f93722c08dc5aabe0@syzkaller.appspotmail.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Xuanqiang Luo <luoxuanqiang@kylinos.cn>,
Tim Bird <tim.bird@sony.com>, Zihan Xi <zihanx@nebusec.ai>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] llc: do not run the state machine on out of service connections
Date: Sat, 5 Sep 2026 12:28:08 -0700 [thread overview]
Message-ID: <20260905122808.1696a959@kernel.org> (raw)
In-Reply-To: <20260901210308.1173180-1-kees@kernel.org>
On Tue, 1 Sep 2026 14:03:03 -0700 Kees Cook wrote:
> + /*
> + * An out of service connection has no row in llc_conn_state_table[],
> + * so it cannot be driven by any event.
Networking comment format, assuming the comment is indeed necessary and
not pure slop.
> + */
> + if (unlikely(!llc_conn_state_in_service(llc->state))) {
--
pw-bot: cr
next prev parent reply other threads:[~2026-09-05 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 21:03 [PATCH net-next 0/3] " Kees Cook
2026-09-01 21:03 ` [PATCH net-next 1/3] " Kees Cook
2026-09-05 19:28 ` Jakub Kicinski [this message]
2026-09-01 21:03 ` [PATCH net-next 2/3] llc: report a closed connection for out of service sockets Kees Cook
2026-09-01 21:03 ` [PATCH net-next 3/3] llc: add KUnit tests for the connection state machine bounds Kees Cook
2026-09-05 15:58 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260905122808.1696a959@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luoxuanqiang@kylinos.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+628f93722c08dc5aabe0@syzkaller.appspotmail.com \
--cc=tim.bird@sony.com \
--cc=zihanx@nebusec.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®