From: Jakub Kicinski <kuba@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<horms@kernel.org>, <nb@tipi-net.de>, <kuniyu@google.com>,
<sdf@fomichev.me>, <liuhangbin@gmail.com>, <da-x@monatomic.org>,
<jeff@garzik.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3 2/2] 8021q: publish vlan_devices_arrays entries with acquire/release
Date: Sat, 5 Sep 2026 12:45:17 -0700 [thread overview]
Message-ID: <20260905124517.0e3daf69@kernel.org> (raw)
In-Reply-To: <20260902073334.397685-3-ruanjinjie@huawei.com>
Some nits for the future..
On Wed, 2 Sep 2026 15:33:34 +0800 Jinjie Ruan wrote:
> Replace the smp_wmb()/smp_rmb() barrier pair with
> smp_store_release()/smp_load_acquire() on
> vg->vlan_devices_arrays[pidx][vidx].
>
> vlan_group_prealloc_vid() publishes the array pointer via release;
> __vlan_group_get_device() acquires it before accessing the array,
> ensuring the allocated entries are visible.
>
> No functional change intended.
This phrase is usually reserved for patches which are pure refactor.
You are changing the barriers.
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Simon Horman <horms@kernel.org>
> Cc: Nicolai Buchwitz <nb@tipi-net.de>
> Cc: Stanislav Fomichev <sdf@fomichev.me>
> Cc: Hangbin Liu <liuhangbin@gmail.com>
> Cc: Kuniyuki Iwashima <kuniyu@google.com>
Please put the CCs under the --- marker.
> Assisted-by: DeepSeek:DeepSeek-V3
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
next prev parent reply other threads:[~2026-09-05 19:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 7:33 [PATCH net-next v3 0/2] " Jinjie Ruan
2026-09-02 7:33 ` [PATCH net-next v3 1/2] 8021q: Fix data race when publishing vlan net_device pointers Jinjie Ruan
2026-09-05 5:03 ` Kuniyuki Iwashima
2026-09-02 7:33 ` [PATCH net-next v3 2/2] 8021q: publish vlan_devices_arrays entries with acquire/release Jinjie Ruan
2026-09-05 5:10 ` Kuniyuki Iwashima
2026-09-05 19:45 ` Jakub Kicinski [this message]
2026-09-05 19:50 ` [PATCH net-next v3 0/2] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260905124517.0e3daf69@kernel.org \
--to=kuba@kernel.org \
--cc=da-x@monatomic.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jeff@garzik.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ruanjinjie@huawei.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®