From: Jakub Kicinski <kuba@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: <jhs@mojatatu.com>, <jiri@resnulli.us>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <horms@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3] net: sched: act_gact: use acquire/release for tcfg_ptype
Date: Sat, 5 Sep 2026 13:42:21 -0700 [thread overview]
Message-ID: <20260905134221.233ae6b5@kernel.org> (raw)
In-Reply-To: <20260902071659.395509-1-ruanjinjie@huawei.com>
On Wed, 2 Sep 2026 15:16:59 +0800 Jinjie Ruan wrote:
> @@ -160,7 +155,8 @@ TC_INDIRECT_SCOPE int tcf_gact_act(struct sk_buff *skb,
>
> #ifdef CONFIG_GACT_PROB
> {
> - u32 ptype = READ_ONCE(gact->tcfg_ptype);
> + /* Pairs with smp_store_release() in tcf_gact_init() */
> + u32 ptype = smp_load_acquire(&gact->tcfg_ptype);
>
> if (ptype)
> action = gact_rand[ptype](gact);
Clashiko points out that you are turning what used to be a conditional
barrier into one that's always obeyed, even if ptype is 0.
--
pw-bot: cr
prev parent reply other threads:[~2026-09-05 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 7:16 Jinjie Ruan
2026-09-02 14:19 ` Jamal Hadi Salim
2026-09-05 20:42 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260905134221.233ae6b5@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®