From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5ED9242925; Sun, 6 Sep 2026 00:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788654771; cv=none; b=IfBlnmZjQ5FkbU5RwD3AJB7kx4qJ8EWos707pCtJPmi7jHFfEXvsW89ICklZ/n2133MRRPAgMIZERiau7ejfqcHpLdy59CA3JQDv1M8OFIPxeTiEZbewRroOpccnhz+7lBhbc+wrMSEU7C66o7N9rABRzHcy4lm7YCBUklE0Df8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788654771; c=relaxed/simple; bh=Yw6hvHNWT3wfKY4Lya23TuKrGdA68e5Y9lvf89DsNQo=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=X8Y5VHVymSafwuwjwZ+VsOqmItZhIbfmmpmSwSVGXpUeQb0hL6iWydMMIum331pZlwn4vvQVuebigHJYTe/mbkPertunPtKA3R+brwHQw1G6JlgRUkjnLumgLcncyCdxO1FASHRZK8pYoox0DGn0X+asYY2YbheeBnAX7bWvtgs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=WgSsm7Ob; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="WgSsm7Ob" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBF841F00A3D; Sun, 6 Sep 2026 00:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1788654770; bh=JzguznGN4wZaJ4BaohUL/D8OCMllkrYSCH0UgmH3tU0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=WgSsm7ObXrMrJfIn8wocZvVmk1viVsJ8i/DGwFzwXHn7BRCWaJrz5waexMh61wfEZ wOeNPp7eJW0KXAVEi1Nn5VEBdxXIymbBCxZnqcn26qOkA5ue3hfCB14lzppG13QxeZ /MOIRI15EcghSoEiYeyN7l8hDKigwnfEu/K10i1c= Date: Sat, 5 Sep 2026 17:32:49 -0700 From: Andrew Morton To: Sarthak Sharma Cc: David Hildenbrand , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , Shuah Khan , Jonathan Corbet , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Mark Brown , Anshuman Khandual , Muhammad Usama Anjum , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 0/6] selftests/mm: separate GUP microbenchmarking from functional testing Message-Id: <20260905173249.00f41b2a88abb0aefd217e94@linux-foundation.org> In-Reply-To: <20260904123631.198697-1-sarthak.sharma@arm.com> References: <20260904123631.198697-1-sarthak.sharma@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 4 Sep 2026 18:06:25 +0530 Sarthak Sharma wrote: > gup_test.c currently serves two separate purposes: benchmarking > (GUP_FAST_BENCHMARK, PIN_FAST_BENCHMARK and PIN_LONGTERM_BENCHMARK) and > functional testing (GUP_BASIC_TEST, PIN_BASIC_TEST and > DUMP_USER_PAGES_TEST). Keeping both in one program makes the functional > tests harder to run and report individually, while run_vmtests.sh has to > invoke the program repeatedly with different options. > > Separate these roles into tools/mm/gup_bench for benchmarking and > tools/testing/selftests/mm/gup for functional testing. Move the shared > file and hugepage helpers to tools/lib/mm/ so both programs can use them > without duplicating the implementation. Thanks, I've added this series to mm.git's mm-new branch for testing and hopefully further progression.