From: Abhin Parekadan Jose <abhinjoses@gmail.com>
To: bhelgaas@google.com, lukas@wunner.de, mst@redhat.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
ilpo.jarvinen@linux.intel.com, kees@kernel.org,
xueshuai@linux.alibaba.com,
Abhin Parekadan Jose <abhinjoses@gmail.com>
Subject: [PATCH RFC 3/3] misc: Add edu_srpoc surprise removal POC driver
Date: Sat, 5 Sep 2026 18:39:00 +0000 [thread overview]
Message-ID: <20260905183905.997833-4-abhinjoses@gmail.com> (raw)
In-Reply-To: <20260905183905.997833-1-abhinjoses@gmail.com>
A test driver for the QEMU edu device that reproduces the surprise
removal hang described in MST's RFC v5 thread.
- hacked in a reg to the edu device on qemu to raise a delayed irq
- This driver writes to that reg in remove and waits for the irq to be
handled. This simulates del_gendisk() blocked in
blk_mq_freeze_queue_wait()
Assisted-by: LLM
Signed-off-by: Abhin Parekadan Jose <abhinjoses@gmail.com>
---
drivers/misc/Makefile | 1 +
drivers/misc/edu_srpoc.c | 169 +++++++++++++++++++++++++++++++++++++++
2 files changed, 170 insertions(+)
create mode 100644 drivers/misc/edu_srpoc.c
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index e8d8d5d88c0d..1479bf19c646 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -9,6 +9,7 @@ obj-$(CONFIG_AD525X_DPOT_I2C) += ad525x_dpot-i2c.o
obj-$(CONFIG_AD525X_DPOT_SPI) += ad525x_dpot-spi.o
obj-$(CONFIG_ATMEL_SSC) += atmel-ssc.o
obj-$(CONFIG_DUMMY_IRQ) += dummy-irq.o
+obj-y += edu_srpoc.o
obj-$(CONFIG_ICS932S401) += ics932s401.o
obj-$(CONFIG_LKDTM) += lkdtm/
obj-$(CONFIG_TI_FPC202) += ti_fpc202.o
diff --git a/drivers/misc/edu_srpoc.c b/drivers/misc/edu_srpoc.c
new file mode 100644
index 000000000000..f536bc4aa253
--- /dev/null
+++ b/drivers/misc/edu_srpoc.c
@@ -0,0 +1,169 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * edu_srpoc.c Surprise Removal POC driver for the QEMU edu device
+ *
+ * In remove(), schedules a delayed interrupt on the edu device and
+ * blocks waiting for it to complete. This simulates del_gendisk()
+ * blocked in blk_mq_freeze_queue_wait() on slow in-flight I/O.
+ *
+ * Surprise-remove the device during this window to reproduce the hang.
+ *
+ * edu BAR 0 registers used:
+ * 0x08 Factorial: write N to compute N! asynchronously
+ * 0x20 Status: write EDU_STATUS_IRQFACT to enable IRQ on completion
+ * 0x24 IRQ status: bit 0 = FACT_IRQ, bit 9 = DELAY_IRQ
+ * 0x30 Delayed IRQ: write N (ms). Hacked in this functionality(not upstream).
+ * 0x64 IRQ lower: write bitmask to ack
+ */
+
+#include <linux/module.h>
+#include <linux/pci.h>
+#include <linux/interrupt.h>
+#include <linux/completion.h>
+#include <linux/delay.h>
+
+#define PCI_VENDOR_ID_EDU 0x1234
+#define PCI_DEVICE_ID_EDU 0x11e8
+
+#define EDU_REG_FACT 0x08
+#define EDU_REG_STATUS 0x20
+#define EDU_REG_DELAYED_IRQ 0x30
+#define EDU_REG_IRQ_STATUS 0x24
+#define EDU_REG_IRQ_LOWER 0x64
+
+#define EDU_STATUS_IRQFACT 0x80
+#define EDU_FACT_IRQ BIT(0)
+#define EDU_DELAY_IRQ BIT(9)
+
+struct edu_dev {
+ struct pci_dev *pdev;
+ void __iomem *regs;
+ struct completion irq_done;
+};
+
+static irqreturn_t edu_irq_handler(int irq, void *data)
+{
+ struct edu_dev *edu = data;
+ u32 status;
+
+ status = ioread32(edu->regs + EDU_REG_IRQ_STATUS);
+ if (!status)
+ return IRQ_NONE;
+
+ iowrite32(status, edu->regs + EDU_REG_IRQ_LOWER);
+
+ if (status & (EDU_FACT_IRQ | EDU_DELAY_IRQ)) {
+ complete(&edu->irq_done);
+ }
+
+ return IRQ_HANDLED;
+}
+
+static void edu_disconnect(struct work_struct *work)
+{
+ struct pci_dev *pdev = container_of(work, struct pci_dev,
+ disconnect_work);
+ struct edu_dev *edu = pci_get_drvdata(pdev);
+
+ if (!pci_test_and_clear_disconnect_enable(pdev))
+ return;
+
+ if (!edu)
+ return;
+
+ dev_info(&pdev->dev, "disconnect_work fired — unblocking remove()\n");
+ complete(&edu->irq_done);
+}
+
+static int edu_probe(struct pci_dev *pdev, const struct pci_device_id *id)
+{
+ struct edu_dev *edu;
+ int err;
+
+ edu = devm_kzalloc(&pdev->dev, sizeof(*edu), GFP_KERNEL);
+ if (!edu)
+ return -ENOMEM;
+
+ edu->pdev = pdev;
+ init_completion(&edu->irq_done);
+
+ err = pci_enable_device(pdev);
+ if (err)
+ return err;
+
+ err = pci_request_regions(pdev, "edu_srpoc");
+ if (err)
+ goto err_disable;
+
+ edu->regs = pci_iomap(pdev, 0, 0);
+ if (!edu->regs) {
+ err = -ENOMEM;
+ goto err_release;
+ }
+
+ pci_set_master(pdev);
+
+ err = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_MSI | PCI_IRQ_INTX);
+ if (err < 0)
+ goto err_iounmap;
+
+ err = request_irq(pci_irq_vector(pdev, 0), edu_irq_handler,
+ IRQF_SHARED, "edu_srpoc", edu);
+ if (err)
+ goto err_free_vectors;
+
+ pci_set_drvdata(pdev, edu);
+
+ INIT_WORK(&pdev->disconnect_work, edu_disconnect);
+ pci_set_disconnect_work(pdev);
+
+ dev_info(&pdev->dev, "edu_srpoc probed\n");
+ return 0;
+
+err_free_vectors:
+ pci_free_irq_vectors(pdev);
+err_iounmap:
+ pci_iounmap(pdev, edu->regs);
+err_release:
+ pci_release_regions(pdev);
+err_disable:
+ pci_disable_device(pdev);
+ return err;
+}
+
+static void edu_remove(struct pci_dev *pdev)
+{
+ struct edu_dev *edu = pci_get_drvdata(pdev);
+
+ iowrite32(EDU_STATUS_IRQFACT, edu->regs + EDU_REG_STATUS);
+ iowrite32(600000, edu->regs + EDU_REG_DELAYED_IRQ);
+
+ dev_info(&pdev->dev, "Waiting for IRQ in remove()\n");
+ wait_for_completion(&edu->irq_done);
+ dev_info(&pdev->dev, "Unblocked, cleaning up\n");
+
+ pci_clear_disconnect_work(pdev);
+ free_irq(pci_irq_vector(pdev, 0), edu);
+ pci_free_irq_vectors(pdev);
+ pci_iounmap(pdev, edu->regs);
+ pci_release_regions(pdev);
+ pci_disable_device(pdev);
+}
+
+static const struct pci_device_id edu_ids[] = {
+ { PCI_DEVICE(PCI_VENDOR_ID_EDU, PCI_DEVICE_ID_EDU) },
+ { 0 }
+};
+MODULE_DEVICE_TABLE(pci, edu_ids);
+
+static struct pci_driver edu_driver = {
+ .name = "edu_srpoc",
+ .id_table = edu_ids,
+ .probe = edu_probe,
+ .remove = edu_remove,
+};
+
+module_pci_driver(edu_driver);
+MODULE_AUTHOR("Abhin Parekadan Jose");
+MODULE_DESCRIPTION("edu surprise removal POC driver");
+MODULE_LICENSE("GPL");
--
2.51.1
prev parent reply other threads:[~2026-09-05 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 18:38 [PATCH RFC 0/3] PCI: pciehp: Report surprise removal during safe removal Abhin Parekadan Jose
2026-09-05 18:38 ` [PATCH RFC 1/3] PCI: Report surprise removal event Abhin Parekadan Jose
2026-09-05 18:38 ` [PATCH RFC 2/3] PCI: pciehp: Report surprise removal from pciehp_isr() Abhin Parekadan Jose
2026-09-05 18:39 ` Abhin Parekadan Jose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260905183905.997833-4-abhinjoses@gmail.com \
--to=abhinjoses@gmail.com \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mst@redhat.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®