From: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Donggeun Yoo <donggeunyoo.kernel@gmail.com>
Subject: Re: [PATCH] dma-mapping: don't trace the DMA address when the allocation fails
Date: Sun, 6 Sep 2026 04:16:34 +0900 [thread overview]
Message-ID: <20260905191634.179897-1-donggeunyoo.kernel@gmail.com> (raw)
In-Reply-To: <b36f40ac-cd77-a480-d558-139334334b16@linux.dev>
On 9/5/26 14:37, Sean Anderson wrote:
> Ah, I see what you mean. TBH I would just do something like
>
> cpu_handle ? *dma_handle : NULL
>
> to make it clear what we're doing
It would have to be 0, dma_handle being a dma_addr_t, and
debug_dma_alloc_coherent() reads *dma_handle too -- it drops the value
when virt is NULL, but the read is still there -- so the conditional ends
up written three times.
68b6dbf1f441 gave dma_alloc_pages() and dma_alloc_noncontiguous() the
if/else split rather than a guarded argument, and I kept dma_alloc_attrs()
in that shape so that the three read the same way.
I don't feel strongly about it. Say the word and I'll respin with the
conditional inline.
prev parent reply other threads:[~2026-09-05 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 7:19 Donggeun Yoo
2026-09-05 12:57 ` Sean Anderson
2026-09-05 17:26 ` Donggeun Yoo
2026-09-05 18:37 ` Sean Anderson
2026-09-05 19:16 ` Donggeun Yoo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260905191634.179897-1-donggeunyoo.kernel@gmail.com \
--to=donggeunyoo.kernel@gmail.com \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®