From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C7FE22FDE6 for ; Sat, 5 Sep 2026 19:37:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788637033; cv=none; b=IaR7U8ZkORq5qBhPkDpONXlQisk5H08p93TaY49dWdijHYIQLDJTHbBhVADz0LIRNVm5DqSP0RRdMjjG7YpytpDH5GOLsENZKFVofJg7a2XzNLdHgQG1WFHqY4POmmWjJO46kJz0Rhzq/HrgHyRUWnSRCYHvG/lfDCRUk/4VDH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788637033; c=relaxed/simple; bh=xZ6KsdW5f2NpTo9qehbK8CWOfXcHtshoKlG78wErm7M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=j/a5F45w9X7OOK/rb5ncNzl9xWUF9I0QclXE1TNv6v3ObF/DKYkppY/Suta3iv57Ya6yURf8uQ2g2Lu/zDUlhFmMbNXXccQuke/ZLzgxf+Riccxvhw0jvkVXj8fM+JQ8tbSY8B9sw3qM8DR4xLEziXMBoxD90YR3p+Z5bFVmjHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TJ+aFrp3; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TJ+aFrp3" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38a0c7e841fso2759298a91.2 for ; Sat, 05 Sep 2026 12:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788637031; x=1789241831; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=0xM5jhzzXry0h+e/i2joKohtDwwRTLaxUZrU8veNd6E=; b=TJ+aFrp3VsV2zLVXzcf4EdoUGe6+SnMTxSvIgYX7v6NrBqAxHYwVkD906Q5HKXZGvj Dl7EI6kqBky3J347SaClBBkMMZC+5V2hhaQzthjuzMQYiM5XYUTisooplKA8Is+RTSBv RD3bL/aHnbLd1maX91Hww/15kWGuo0sdDUAle0uGegdhlp5yhBnVB1e5p3lHMZX3uJRh OnmTCKM15AHK5Ci1Jl96VRZLEqKp6OZ3CZuFvQEzj4xIImMHrUc2VGyQ3OJVshFgUi/l dvloS4KogkUs6ISr+mAz0hgfUioEYBT/akcJ7DW8Ab4yMU4j7zjXDpBj6fbiHavj8bb8 HaSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788637031; x=1789241831; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0xM5jhzzXry0h+e/i2joKohtDwwRTLaxUZrU8veNd6E=; b=Y/obeqVm+Ju/2jZg4ha00VG+kvHQaxATqrvoc7qVYbk6ex9wLOUESU+5ntGd/8QUvX YFJuUxzkLg9egCdtx5DZLrdtF0xY5/JRd/ZJAfAJzx5lI0CvXwO51Fu2F3Z7v3jkI/VS aAGhpfLDekx8GuH++yjMhs7ScC12cRrQSkGAJ057G87q9glqNYvMJbjZ7QyrDBPy/MCp WDgwfuZrEziKxCGiIwwgHZp2soSFAMB8FE62X5EzHl60z2/dMfsJzBWn8VM3WlS7k82G oizXzUaayga/ZDBYVhQ0fzLMgmDH6jqv9MrXDbkxB+nxooV+ajNz9/mwr9ph0csMevvb HNdQ== X-Forwarded-Encrypted: i=1; AKwUvBxWHog7x2I3Iz7EnK0Ix1AaqgShV1EOi9p45bXTnIQ8jUFSTi8GcT6vhT3AmY+xe6/hQHPRwRh5Ea375LI=@vger.kernel.org X-Gm-Message-State: AFuF++nEOgpzuLGR8cInm3D4E+AdjvwnKwSKl+oziV/3E+NNpoJ1Yqmk 6IeKRrc+v8NqCo7IRJ0VE55tG1NGBSaoTKSRzvLNJjwL+AV6mLjmY+A9 X-Gm-Gg: AYBFou3ZdhwGOD5q3nPliDHz11wSgud41efdZIlw98b3Gv+IaEk/BP/l8BdZtTQ5zvh pTI2sMCQRet1pLUXZWcWUVBKGKqPoTO7ES/BfXEIYtosedjLhYUULY1qnjswzTKK7Pq1YD3ywqy XTZRMGdl+nDGeVnewOKQ06DLX+qb27ujQLucq7hp9kJEDuKgGfpqkoFy+thUM1QrtWzZ4Bl8S03 mIaRvqP47xw1dHFXWn9coMpbjjNjq6DSTg6G41PMpCkCVG9tWakYIjxJWt2xcDzlzaW/mg9Js4b te/QqUdkN8GiH8YI6ND4SBP46hlhW3DipUYAXTHqLdUzQONQ01XJApggj4y+ltV92aeQe9vbpi+ L4Py9/6E0yuDUgsTNs5X0TnlNbCXCM4uie7uH3vEUiAhGF2wHgM3t28kxReBBr26DddYY3ID803 EtmEse/dxf3DIxbPpV3Gh0iiCnKv0P90TLjX0TKgUooB6+PXht5A== X-Received: by 2002:a17:90b:2f46:b0:396:6344:3b63 with SMTP id 98e67ed59e1d1-39b260de5c6mr22999111a91.2.1788637031444; Sat, 05 Sep 2026 12:37:11 -0700 (PDT) Received: from evangelion-g ([2a09:bac5:40e2:a82::10c:6b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08bcc081sm17597757a91.6.2026.09.05.12.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2026 12:37:10 -0700 (PDT) From: Ayush To: Thomas Winischhofer Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Ayush , syzbot+3bc656a9271e7c8a5c6b@syzkaller.appspotmail.com Subject: [PATCH v1] USB: sisusbvga: avoid initializing device in open Date: Sun, 6 Sep 2026 01:06:34 +0530 Message-ID: <20260905193634.160600-1-ayush37735@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The USB core holds minor_rwsem while invoking a USB character device's open callback. sisusb_open() can currently initialize the device while holding sisusb->lock, and that initialization performs synchronous USB I/O. High-speed devices are already initialized during probe. Treat a probe-time initialization failure as a probe failure instead of retrying initialization from open, so the open callback no longer performs blocking device initialization. Reported-by: syzbot+3bc656a9271e7c8a5c6b@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3bc656a9271e7c8a5c6b Signed-off-by: Ayush --- drivers/usb/misc/sisusbvga/sisusbvga.c | 29 ++++++++++++-------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/usb/misc/sisusbvga/sisusbvga.c b/drivers/usb/misc/sisusbvga/sisusbvga.c index 3e75a7c24828..6723a65b12b8 100644 --- a/drivers/usb/misc/sisusbvga/sisusbvga.c +++ b/drivers/usb/misc/sisusbvga/sisusbvga.c @@ -2223,20 +2223,10 @@ static int sisusb_open(struct inode *inode, struct file *file) } if (!sisusb->devinit) { - if (sisusb->sisusb_dev->speed == USB_SPEED_HIGH || - sisusb->sisusb_dev->speed >= USB_SPEED_SUPER) { - if (sisusb_init_gfxdevice(sisusb, 0)) { - mutex_unlock(&sisusb->lock); - dev_err(&sisusb->sisusb_dev->dev, - "Failed to initialize device\n"); - return -EIO; - } - } else { - mutex_unlock(&sisusb->lock); - dev_err(&sisusb->sisusb_dev->dev, - "Device not attached to USB 2.0 hub\n"); - return -EIO; - } + mutex_unlock(&sisusb->lock); + dev_err(&sisusb->sisusb_dev->dev, + "Device not initialized\n"); + return -EIO; } /* Increment usage count for our sisusb */ @@ -2880,9 +2870,16 @@ static int sisusb_probe(struct usb_interface *intf, if (dev->speed == USB_SPEED_HIGH || dev->speed >= USB_SPEED_SUPER) { int initscreen = 1; - if (sisusb_init_gfxdevice(sisusb, initscreen)) + + if (sisusb_init_gfxdevice(sisusb, initscreen)) { dev_err(&sisusb->sisusb_dev->dev, - "Failed to early initialize device\n"); + "Failed to early initialize device\n"); + sisusb->present = 0; + usb_set_intfdata(intf, NULL); + usb_put_dev(sisusb->sisusb_dev); + retval = -EIO; + goto error_4; + } } else dev_info(&sisusb->sisusb_dev->dev, -- 2.53.0