From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 843262FE56A for ; Sun, 6 Sep 2026 14:46:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788706004; cv=none; b=ZaX97PGuOV/Qa9MtSV0KbUEMtA0WxnNt3wfNwOpiKQDT1iwW0zQ26xm/4b48fd12yILKLnHYJHMuTdHAzOzTZ/Ftw/6BGFY3pCzgCmap94rm92KRVAnG/38y/HB18aV9X8xrRFLERzEr/5jo5OkYfofBDilAFZyfo+E2C7UDDfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788706004; c=relaxed/simple; bh=AkmsPhY2nykw/qElY1cGWx8CQD8WQMtwPEwX3DiduLA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=V0SUvy3WJ7mCzbrtUMznWaIROePbjaGQhLsDNQjNtGJHmRzVs5zhuqtIkMQk1U6KpoRFIO5kyCqDHNos3qgZYfhP9al1S99kDCPyup+TcUmfd3kIIx1T6gqurzmAiBjKXAwryG3f9a4kx6wuf8uJ+wRs7w3tUlZ1+8Ds4LtaQv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=soUMJy+/; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="soUMJy+/" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2d01663d816so18064545ad.1 for ; Sun, 06 Sep 2026 07:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788706003; x=1789310803; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=I/NA40pHs0mAdUAHdhoal9SiaLl11w46qTtr/hZ4eJU=; b=soUMJy+/Bmn503vigVXy7VIsxAQIsXViLhuRIIXzsR5ZEHFp28hVtPq2eg/Dw9LQhg hRW3g41vncs14wY8iGd6ErP+NWQT0px+wm/p0U7w3XUcgym97jlKu3DtPk/3GIvFOsJz /e3x/jAtn1SP4zL1xprkBzdDebotthlN9IXCpZvpVFr1NvNrCf3KFmE8Fsa6I9cxDiA/ e/CTs+fA2ISbOkETMX99bc4uV84pkMvXbS1GHfMutG3xODKO3axc4kV/WkGR1ZkPivae UJVmBwr0jgNPn1r4pOALNKWOe4sF2dNom/1pw2HNLwPqBkluDxR1obRZ/MJbDD0ZnUR+ p7Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788706003; x=1789310803; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I/NA40pHs0mAdUAHdhoal9SiaLl11w46qTtr/hZ4eJU=; b=jzedtpUsv5ijSx9sFnFsj36o7RCr8+LJV9m2s2b/WyyrJ0cJQfmOPVWmjaojL49bij koicf58QRuoaDV1PE8xkWMm4ruHDhy7sbWMIWGp0Y56owWDvbm3We3uycSxeBuYkr/pa Ctwy+U3st+pPacdTzbTE7pl2MyGkkqa5NXwSC7MUXua58m7EBf+zyn6iyWyKo/Xn7bA4 oLxlMbZV9XaEyBrhiPvAb2CRCXwc1/WAfUMt940pkns5d8nEhZR6cLc9zP73ZeHOEgqM yTsqqwosZOOHnfJMjQE8o1nFVJerYbPosZF1ZvQJssJZhupWd9VsPZBFJ0FHpfDfFsqh zzqQ== X-Forwarded-Encrypted: i=1; AKwUvBz9v9c7FNeMvS4pVRNIwRleLfS2pNN+btq5zec84ubhzeb6qAHFWmeARNA77Q62YVe/wkmoScYFw2ipX5M=@vger.kernel.org X-Gm-Message-State: AFuF++l8DmPQAlb0opvM8f9b3jHdyV30yvVIdz6ss4OMmD+Zzu5QojUr GqY3H0I01kJZSXaNQ5ag2aTqp8IR+PrSWfHlGQA+tuxrUyzcS4fp0UJd X-Gm-Gg: AYBFou1NEpV9VVT/uQvL31VrOS5NNchC3GiT0DHKyK2I+NLptpqlrtuap3c80BOJ+hP 23V6Z2vLR7C3RTAUFZohNG7TE7qB7gBBvnl5YQCcHOaTaY8OrGZYhbfzOfCb4Zdn2S1zWRtewcy +eAAoji1+ohSgOoQvTlVHr+duZMbC+qmxAdqI8DhUzBSOQFD39PcFHMXyaARcgcobbYNBlJ3sw2 0c9rrnK/VrWH/zlToxeM4Vs2oFxsFfJcxPSfvp2BbFvMiBhetIPLCGWkmPz3MBlisv14q6nHNFS G/QMbSYtuk8mXaDDTjN+z+GuVGfkfwxMDONFk5o3qHpIFJ921HhvIaY3GEq1C4Ue0YuW3O+OL4V +KmoBs8HIbplYGZAo+8/jY3HkdfDX1bdK6NusnQVWc0VVaCYZna+3zwCbcWvkzChM28nAsT1Rpr cLjSUugW7p3WebSABJnYBDwWUjmkG0oI6I6PuCNWqYfdpxx9G0dtP/LRYtvmZtMumwsTfiGzyZL /epoWQSFZGxgdznXNghIKxNK6RDMtsQO1Sp X-Received: by 2002:a17:90b:560e:b0:38e:2e86:ed02 with SMTP id 98e67ed59e1d1-39b261e7931mr27948816a91.14.1788706002833; Sun, 06 Sep 2026 07:46:42 -0700 (PDT) Received: from deepanshu.. ([2405:201:682f:383f:111b:b40c:2146:f791]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08d0d7e8sm22758239a91.16.2026.09.06.07.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Sep 2026 07:46:41 -0700 (PDT) From: Deepanshu Kartikey To: cem@kernel.org, djwong@kernel.org Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+ccdf3469f5f653bff7ac@syzkaller.appspotmail.com Subject: [PATCH] xfs: take hm->lock in xfs_ioc_health_monitor() before insert Date: Sun, 6 Sep 2026 20:16:29 +0530 Message-Id: <20260906144629.17009-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __xfs_healthmon_insert() asserts that hm->lock is held (lockdep_assert_held), but xfs_ioc_health_monitor() called it right after allocating hm, before ever taking the lock, triggering a lockdep warning. Take hm->lock around the call. Fixes: b3a289a2a9397 ("xfs: create event queuing, formatting, and discovery infrastructure") Reported-by: syzbot+ccdf3469f5f653bff7ac@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=ccdf3469f5f653bff7ac Signed-off-by: Deepanshu Kartikey --- fs/xfs/xfs_healthmon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/xfs/xfs_healthmon.c b/fs/xfs/xfs_healthmon.c index 3ae5f4496ad1..2f762f90d329 100644 --- a/fs/xfs/xfs_healthmon.c +++ b/fs/xfs/xfs_healthmon.c @@ -1219,7 +1219,9 @@ xfs_ioc_health_monitor( } running_event->type = XFS_HEALTHMON_RUNNING; running_event->domain = XFS_HEALTHMON_MOUNT; + mutex_lock(&hm->lock); __xfs_healthmon_insert(hm, running_event); + mutex_unlock(&hm->lock); /* * Preallocate the unmount event so that we can't fail to notify the -- 2.34.1