From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 846DD3C09ED for ; Sun, 6 Sep 2026 18:17:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788718630; cv=none; b=tsvOepShV/GeLgJZLHSZ0McpkEGYKFIu+YG4TOlUFtpfhK0GVQjg7N1vY+a0IqyTuicv/YFCQo08YF+cMVJ6qXNC53ig/P0A6jTBu8qqe01KP3fnSSahp+SwrBLWmjScAVdnPRH+2x/fUqpiKPhLM0ku59SyQdl5gcDYppD/5bs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788718630; c=relaxed/simple; bh=zE/2hqn4I9P57cCKdIKN6nY4HEnzOsNL+Lxb4BdK5Vk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=plEC5ZZ0yqBDhii1W6Ct6nTEp0D+6uMfwLCYiKKNxBQoyulEM5g7qpdQzdYl40133iS1T1GYVHqOb5o7CDmtEJxR8zd6PmMs7nt5YijgdECknzH1QQW7AYeQTyhZhdard/d7tBiYtDhWW+hCkSVPrr3QJ52PZYrR2K6FIBpTm00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K+o5tDm+; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K+o5tDm+" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-48435bcf9d9so189891f8f.1 for ; Sun, 06 Sep 2026 11:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788718625; x=1789323425; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=R/mSQMe/ffg+AP+VO4769NtESa1TU8r20BVXKonSb5k=; b=K+o5tDm+s9drKsg+ic/JvPkVIPEltlhZlGhLNY3dXQumcoqVAeOn6hL4zwTjQivGro Dcdk9YEf6K2yA2iF1kb615YITnEuzz43ghFR/x+dKWPRcaoGAhka+nE1M6ynpaCR1Tyg E0O25V7Iklcg03P+D2VjvO0tHN9CBZSdVr8dVR+JwCCq/+b6szLM4FqizQkm2hhKZRxW 8SW3eh8Tvdo6xA72XqGhDzZfshvENnuUuJLncC+0MECM2fF5d+PL1JZA9Aly5WlN8QJ8 NcCZu/UEMET+PHJKtAgyMX3OPtKf96LvCJ2aiYCgFzMFZVWQDKtjQ9vlo/3/t1bujd/A Oi4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788718625; x=1789323425; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=R/mSQMe/ffg+AP+VO4769NtESa1TU8r20BVXKonSb5k=; b=gTMsOAkZfH8WJsff2AI1HuD8knPCuA3P2SI2O1Kh10Tkpj6WvuswIH1e8bRcby8ONU wz1kcwqTNE11ZaLb8mL3GrVRz5i9Mbh8UnfquxXmIt+HnQku8AIdGEmwUcJXIWIgOE39 FXMVd2OiTPaG/l4Ss4+gUsig5HizmTlDHsKAIrHDEFCXTkGXeBVXLg9WT8xhy/+293o0 YjUH19yYq1B1U9d7RjigAcAXt5QgHnnOAItBiL8w690PTWQQhdjSEqax0SXldz9CD2Bn 1kWkGZkRacBLNI3xUXmKmVXA+pp2/NyGsqrddRPP2xM/RsEnXAflwzUioSb43jB+Li0s QpAw== X-Forwarded-Encrypted: i=1; AKwUvBz95IZf5jcY3ArZY2SsQnexGm0LbPzE+uQAYAegCK/zUsNkBEIKA0KkwpTpQDd4h84S44qnzvcMPs53C6w=@vger.kernel.org X-Gm-Message-State: AFuF++kuppxv4a56xrzBhcZIrq4B+Mzw91nP6kX6SBJ9wJt3uFiAFsGa s46WOWeqLW189jBdM0Sg7bdR5EJbsjIBeASd7sHvgblg6GxP4mLDT0bN X-Gm-Gg: AYBFou2FjxSefwAiTQctxckZWW+PwGZPy6OiAiNPGtJTcU4O6+Slootlp2kj0Fx2mAP 1isQYguH+HV7lRyVRJvrr08MvDuiqc5op6LSPQK8mx4/nZQTcdGYfFrLsdcqIKUqPa5A1HtXaGq KAQ+5CoNaryR7maAGH2ivfQ2IystEVczlinx+ijPax/SnMVODtshaPKV/xsEZYYTAWmhCsWxh42 j3kRo9qq6Y5u1qO20D2GmG5soulWn57XspfycWa6MzAJZ1O9H3pY8lUEhzxK3TgPWQcYEyR9YKW 0VC7qqEFUjrj/fk6RWKPH19sfnKeZznH/ABM2jNvUf68vfTHnasyq49vhqiCeS2VevYAb3dUHYe YUO4P3/Nb536oDEgLjOauAyl24XFUZqu+4rRTIPSX2iWoWM0ViNHh0bQNBfN0yHQjN+exrHCN02 KBpqdBBZse1PFNJof2LX662CBsCrsegywqolHQgw9DLu+KMaGK6mnGwQioWoQ2Wsip5NjaKnvyG 29Ykl5BXXtrYEkdDKUZr8nLiD1UHM1qyqCStHa91PhDtCKs8hBF9ji4631tpunBQLEuy0chklMn ZsA= X-Received: by 2002:a05:600c:c494:b0:49b:916a:e553 with SMTP id 5b1f17b1804b1-49d010c2a57mr100932445e9.0.1788718625331; Sun, 06 Sep 2026 11:17:05 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B886400ACFAF9D8E9019935.dsl.pool.telekom.hu. [2001:4c4e:1b88:6400:acfa:f9d8:e901:9935]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf75ce49esm433916725e9.1.2026.09.06.11.17.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Sep 2026 11:17:04 -0700 (PDT) From: Igor Paunovic To: Heiko Stuebner Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Cristian Ciocaltea , Ondrej Jirman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Igor Paunovic Subject: [PATCH] arm64: dts: rockchip: fix hym8563 interrupt pin on Orange Pi 5 Plus Date: Sun, 6 Sep 2026 20:16:22 +0200 Message-ID: <20260906181622.11991-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The interrupt line of the hym8563 RTC on the Orange Pi 5 Plus is routed to GPIO0_C6, not GPIO0_B0. The vendor device tree uses RK_PC6 with a pull-up for this pin; the mainline board file uses RK_PB0, which is not connected to the RTC. As a result the alarm interrupt never reaches the SoC, so the RTC alarm cannot wake the board: rtcwake enters s2idle and the board never returns, which looks like a hang. This was verified on the board by enabling the alarm interrupt (AIE with AF already set, so INT# is asserted) and sampling the EXT_PORT register of all five GPIO banks: GPIO0_C6 is the only pad that follows AIE (high with AIE=0, low with AIE=1, across repeated cycles), while GPIO0_B0 stays high and its interrupt counter stays at zero. Switch the interrupt and its pinctrl entry to GPIO0_C6 and use a pull-up, as the vendor tree does for this open-drain line. With this change the alarm interrupt fires while the system is running and the RTC wakes the board from s2idle ('PM: Triggering wakeup from IRQ 52'); before it, rtcwake never returned. Fixes: 236d225e1ee7 ("arm64: dts: rockchip: Add board device tree for rk3588-orangepi-5-plus") Cc: stable@vger.kernel.org Assisted-by: LLM checkpatch dtbs_check Signed-off-by: Igor Paunovic --- Notes for reviewers (not part of the commit message): Measured on an Orange Pi 5 Plus with the vendor-style method described above (GPIO0 EXT_PORT sampled while toggling the alarm interrupt enable); the vendor device tree for this board uses RK_PC6 with a pull-up. With the fix the alarm IRQ fires at runtime and the RTC wakes the SoC from s2idle. Note that on this board the resume itself can still stall later in the USB 2.0 host controllers (a separate, unrelated issue being looked at); it does not affect this fix. arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts index 145986695720..572b892e4066 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts @@ -189,7 +189,7 @@ &hdptxphy1 { &hym8563 { interrupt-parent = <&gpio0>; - interrupts = ; + interrupts = ; pinctrl-names = "default"; pinctrl-0 = <&hym8563_int>; }; @@ -298,7 +298,7 @@ hdmi1_tx_on_h: hdmi1-tx-on-h { hym8563 { hym8563_int: hym8563-int { - rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; + rockchip,pins = <0 RK_PC6 RK_FUNC_GPIO &pcfg_pull_up>; }; }; base-commit: 1fc5a74b108fc90951890ec513ac81869f5eaff1 -- 2.43.0