mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Colin Huang <colin.huang2@amd.com>
Cc: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Grant Peltier <grant.peltier.jg@renesas.com>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Colin Huang <u8813345@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas RAA229639 and RAA229640
Date: Mon, 7 Sep 2026 18:00:56 +0100	[thread overview]
Message-ID: <20260907-chimp-pectin-20f4ea3b772c@spud> (raw)
In-Reply-To: <20260907-add-raa229639-and-raa229640-v1-1-8f7218cba85d@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

On Mon, Sep 07, 2026 at 03:03:29PM +0800, Colin Huang wrote:
> From: Colin Huang <u8813345@gmail.com>
> 
> Add Device Tree compatible strings for Renesas RAA229639 and
> RAA229640 PMBus devices.

Driver change suggests fallback compatibles could be used.
Why aren't they? If they can be, add them. Otherwise, explain why not in
your commit message.

pw-bot: changes-requested

Thanks,
Conor.

> 
> Signed-off-by: Colin Huang <u8813345@gmail.com>
> ---
>  Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> index 8216cdf758d8..3537c7ddfb09 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> @@ -60,6 +60,8 @@ properties:
>            - renesas,raa229001
>            - renesas,raa229004
>            - renesas,raa229621
> +          - renesas,raa229639
> +          - renesas,raa229640
>  
>        - items:
>            - enum:
> 
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-09-07 17:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  7:03 [PATCH 0/2] Support " Colin Huang
2026-09-07  7:03 ` [PATCH 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas " Colin Huang
2026-09-07 17:00   ` Conor Dooley [this message]
2026-09-08  6:31     ` Colin Huang
2026-09-08 16:57       ` Conor Dooley
2026-09-07  7:03 ` [PATCH 2/2] hwmon: (pmbus/isl68137): " Colin Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907-chimp-pectin-20f4ea3b772c@spud \
    --to=conor@kernel.org \
    --cc=colin.huang2@amd.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=grant.peltier.jg@renesas.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    --cc=u8813345@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®