Re: [PATCH v10 1/2] dt-bindings: mfd: x-powers: Add AC200

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]

On Mon, Sep 07, 2026 at 11:34:05AM -0600, James Hilliard wrote:
> On Mon, Sep 7, 2026 at 11:19 AM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Sun, Sep 06, 2026 at 04:30:46PM -0600, James Hilliard wrote:
> > > The AC200 is an I2C-controlled mixed-signal companion IC containing
> > > audio, video, RTC and Fast Ethernet PHY functions.
> > >
> > > Describe the parent device and its shared input clock together with the
> > > audio codec and TV encoder child nodes. Keep their analog supplies on the
> > > function consumers and describe the TV encoder display graph and optional
> > > bandgap calibration cell.
> > >
> > > Add the shared interrupt-controller properties and interrupt numbers used
> > > by the TV encoder. The Ethernet PHY is represented by a PHY package on its
> > > MDIO bus, with a phandle back to this device for access to the package
> > > control registers, so it does not require an MFD child node.
> > >
> > > Keep the INTB connection and TV encoder interrupt optional, including when
> > > the TV encoder is enabled. Cable detection status is readable over I2C
> > > without an interrupt. If a TV encoder interrupt is described, require the
> > > parent interrupt domain and its upstream connection. Include examples
> > > with and without INTB connected.
> > >
> > > The input clock must run at 24 or 27 MHz when the Ethernet PHY is used,
> > > matching the rates encoded by its documented clock selector.
> >
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> >
> > This should have been dropped when you merged the patches.
> 
> Oh, forgot to do that.
> 
> > Not sure why you sent v10 without waiting for a reply from me on the v9.
> 
> I had figured I had enough pending fixes(i.e. sashiko reported issues and
> combining the patches) that it made sense to spin an updated series.

Please don't, it leads to fragmented discussions and missed comments.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]