From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013007.outbound.protection.outlook.com [40.93.196.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D52F727FB18 for ; Tue, 8 Sep 2026 02:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.7 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788836219; cv=fail; b=dg5LYq0k70Ie3kx5lCKYY3zZ/qlR4B9aqVZKiMJG1okqZd78sbscskrNbFsSVb0h1X82tJu21YpZn+HBAySsSBNBLXdjYjJdBPj3kc7tp2bIQmWoTIYtU6iDh6M6F0keeZrDxL0/DJsdxVOwgTu3RKRCkuKjUrpDqdB9fWvary0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788836219; c=relaxed/simple; bh=w9Ohb5mo1+AyflUcAN7LYLdvevdRNQaZsGebZJ5kAlk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=PZDkWpwKYVvVlWM1kZLKIAv4znAdPekNqYl7ZEI26CmPqXS/HIJ+CKhsDxZMOI1lpcZFqkrWqSJ1xU8lOAfyAJjgBlnF+yEVCbInk+RO+9zbkeHKF57xhTgXI2091UWEAdleFsBreIg3piej+T9D6Rvg+op19YzQnpIhNAhW2Vo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=EARkzWTx; arc=fail smtp.client-ip=40.93.196.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="EARkzWTx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qb5YnqaXickL/Z1I4J8SBo3ow7zXXdF21YXsTqNrtsBoWx7eQfkU7wgbixrmRQsfbtc/IlOqfm7802bMaxkB5oEJ5GZrB4qB2iE1LKTT8viwsA/cfmlgGBsln0RKIxyFOM9GVt2vaXGkt+otVqzPR3yMc9jXzeAAfrXqPrXwYYQz9AaiL5tksm0v9hojjiC+fGV/rPK9A1Zv/o7dJqA9H1KL0Gk7gjen5TQ+ZWB6ulrQj/cDOdLpyVo64rKrZJPez7iXMhTYlhh7+njOjU7dDLnrReQB28cpTlbnrHMPSE9AvjTj8bFdrpXjoupa7aoznXg2QmfcHbSKVpeZtD07XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OPJDDJcKa9lvexi7Wypu3m0WvDuY+EowhGLAL4uORvw=; b=EXmF0MBmnX6VwQ09TOC/Fszt1RVG+oW3l3/LIW/L3QNm8nqXIGX570d6AxAKxkoa96JQEi83DHp+Loskrg26Ev0fkYJ+kFwx1fav9hMna62MnXV6TEHsCqwwsvtlyMqQuu42oJ0S2f8xFJh4UU+meqyn9chbDj5QtuiNIyGqlmw2qK/y3wpoL4+EUErb120YuxKTN7dCXYgx8WKOQWIXS40zUeDjrFxgpDcpgl1pWseGPTduz0aMA2xuGNIO3LhQwFlz6BAivGOEriTuzJd2v97y5pHjVw63roevguJ2nSBWi8NAAVu83LXFbIwi1St37QaBB/tMQ/DJ3xGso/Sl4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OPJDDJcKa9lvexi7Wypu3m0WvDuY+EowhGLAL4uORvw=; b=EARkzWTxbjGbUg68P+hRHi3O1NbHrC2dhgZs+vOzQApEzmFnDF9mCDUZ7k3aFF7PRV96WZNzLeglEaoJy0tMFXeV0IKdt0s0fqiIvuvCYnsM35xCjjGhjrETmR1gJyrDk7UhEw3tTGxoVEk/IxJYYidgqusa12jdBn3v4KPIy+59OKljsYtfLe1jmI8FsmzyEjtL6QzJ1OGAzPQcpqjbYfWg9moErYLdR4eVcWwoFdazc1g2+BholwXA0wy0e5S72zfCwGDkkLpnaVh0aoh58Sc5EiT7wAu1Hwf5MqNQwvQTwFsoN8ILiYqX2fUOpsLjctdtHOcaNDF/jB0W4Sj85A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by DM6PR12MB4435.namprd12.prod.outlook.com (2603:10b6:5:2a6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.15; Tue, 8 Sep 2026 02:56:35 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0382.014; Tue, 8 Sep 2026 02:56:35 +0000 From: Zi Yan Date: Mon, 07 Sep 2026 22:56:13 -0400 Subject: [PATCH v3 06/14] f2fs: stop using PG_private Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260907-remove-pg_private-v3-6-6ae22f9d9272@nvidia.com> References: <20260907-remove-pg_private-v3-0-6ae22f9d9272@nvidia.com> In-Reply-To: <20260907-remove-pg_private-v3-0-6ae22f9d9272@nvidia.com> To: David Hildenbrand , "Matthew Wilcox (Oracle)" , Andrew Morton , Muchun Song , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Gregory Price , Ying Huang , Alistair Popple , Johannes Weiner , Qi Zheng , Shakeel Butt , Kairui Song Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net X-Mailer: b4 0.15.2 X-ClientProxiedBy: YQBP288CA0035.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:9d::12) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|DM6PR12MB4435:EE_ X-MS-Office365-Filtering-Correlation-Id: 53a18082-af24-4e07-d94c-08df0d54cb45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|23010399003|1800799024|921020|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: WH+/tsI8ILKP3E30KxAtGmboAXDp84snsAsWiw7brcVsY2AX5KhUKpsH9yNckEgIHinVu5jThRUkVeSIG33H+gEBqLFZ2fs/TCA4TMVVUOCw2E/G3Re7nCp8ErFClFLsUme5AaSmR19qLV/3YCwfAvFW/HxsGATXrJC1x8DximiN9mY81AD68SGfUB48KSgO0VbUwVMLIv4GCN7i6u28iU4kM7u/N4iQxFzL2v3q3hVGzBfiPXV/Bg0q3OxtuImi0HTe8QpeopcgKfNDFv07AZGiFKI8HqITx7hDpMBrI9fjj/uoUSY+W7Vty8CloD5LSN+lYJBIhCW48HLTQaP/ebwodFAfEcD7IPyU9q2FGE1Qb3sB0WLtEvqgW4v7A2WkVxKk4JAuUz9N/0HO2r+4dwQ9a4C8BQth2/c+epceCUfJ65pV+PMovLfahmEFnbvse8XXH4jICAmYE6DEy7fm3uyyIg4TsLO2QmPNjuyO3goIGNKRtp7q+5lmaoCDpwZl1LnOk/z60mGMrNZrEEDmWbfxSBojsd515Balz1JhqgboB8iX+pXZVVXz9xX/79wUOOXhNtO8dWSTDfbboBTBjQZ5brpRJX4Gys5bBIfQpTCB2NaH0/CmbwKWJubdRxIm+wYpqlrtmM+c0+z1ZzYoCwfQDTXS1vzel6e3TJ/m7r6SgxR7FiWzvfvUgpf6rmK2TjN8aZ9phQiCi+t72kztxA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(23010399003)(1800799024)(921020)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFVNZ1hpZGJRcTJkVWYxSk5UVkdaelk4L1RCV0FiSjUvTFI3RllYakNocThz?= =?utf-8?B?d0UxZjJVRm02cjIvaHUxUjJ3K3RnQlBqbFprNFl6VnVqQ0JBVWcrdXJTUklE?= =?utf-8?B?OHVtR3RhQmovaFg0dmFGalBXNklJcUhjVWtiTE5FMkppZSttUWppUjVTRDFU?= =?utf-8?B?WFVRUGViZWkzNFZKdzRwblVnaGVHQW94MVlZWDdhK3FjVUVXK3U0bFFXaXVF?= =?utf-8?B?ZTB1ZjNjczc1TTAxRGtldnpOTVQ3emRtbXhRYjR6ZnYzK0dJak5vRVZaK0ZQ?= =?utf-8?B?cDJVS3pkNi9UeFhGRkFVWWkzQjN0ckExYnkrOWxzNEF4WDBORDNBSjFzVFZG?= =?utf-8?B?dHJYVTZDNFI4V2NOVERib0NxYnIyQ0laMXlqcDdYRmpqY2JHMzgrOXFoZHVZ?= =?utf-8?B?ejBkRWhRUGkySVBQZWQ2RUUvd1NHQTIzUU9SZVRjQ2pSL0JNWHhUd3l2N0Y5?= =?utf-8?B?dWdSQXUxcmFsRTlTcnR4NHFzZzVxZVpHdlhaVnNRWS9vR25ObHY3Mms5TVBj?= =?utf-8?B?K21nZkw3R0x0Mkc5TVZtRmxuMU84dlFpY0xBN2xXeEt0S0ZBT1htaDlNaTFK?= =?utf-8?B?U25HUFYxNmRSQ0xmdW0yWGJsK2Q1WnZsaitPNHNjNzJKYUoxbldiRWRzeGVI?= =?utf-8?B?SkRQV1FLdXpXMEFock1sNEVJS3V5MjZBUGU3T0FKUEdNRVVDUHE2c3k2SHRx?= =?utf-8?B?REV5OFB2WXA3bm02TG9xWGxiSVIySjJsN21vNmdDYXorTm8wNXp0NlVudmFZ?= =?utf-8?B?QmV2RWpZTlVxWlVvaUQ2YjBhb0RZS21FaXpqdlR5SmNmVUV6dzlBOHRIRFJS?= =?utf-8?B?OUNyTTFsaS93Y1ZRWWd5b09RS1ArMG1hVzkzSUR0bU96VzBvVE9JWXpYdDls?= =?utf-8?B?eE1MV1Rzd21VVCtNYlJWVnJuVks3SXNWU1dpWUJIWGNJSmd4ZkFPTDhQN2Fu?= =?utf-8?B?V0NpZUpaemFRSTNXREg4b21vRzVvUWg1Z3UvaFZKZUp6aWFrQUxoWE9VWnRP?= =?utf-8?B?RjFLMXJ6Nk41cWdPcjFhempmRXp5Ynp6Nmg5UlBlVWRRWldFK3h4ejZkZUZr?= =?utf-8?B?SVpzRWpuYS9BWFkxUjEvM2NSbWhoMGluSTc4Sk1QeWZVb1VBRVZiZE1Lbkhx?= =?utf-8?B?WUtOUUQ1U0tRSWZiamU0eW5hcStOU1dMQko5d3BwTE9FTUVIM1N0OVNBVVFs?= =?utf-8?B?SSt6RW91RWg1Wm1jTnFmVndZRmtxN1ZxeWNhZnNUUDVVU3N4WTBPSkZUaTdv?= =?utf-8?B?Zlg4ampybms2ekhJZjN5U0ZJTGVxNFg3RHlTSmZVZHRNdnZkWUtPTTdoNTNX?= =?utf-8?B?TVBKKzFPZWsxVFh3VWg5MEgva2lIVFZ6UzFkLy96aDZ2SGd0Rm9zdlRSc0ov?= =?utf-8?B?SDZoeVRYRkVKWWZ6WWVyTEpEbm43MjJqSitsQmRHM2t5Rnd4L2ZiZ2FwTm5k?= =?utf-8?B?MkxyQjFkRFU0Q0xIR0p1cmpuUW00MEIrNjcyblQvYmFid0FJTUxaNUNSSmdW?= =?utf-8?B?QVJORVZtamhTUDhkdDRJN00zQ2pwZnZ0OUJZNjV2blFOVVR4M2RTU0dhTkty?= =?utf-8?B?VFNIZ1lTWit6Zmd6cHhSR25odEszU2VCemk1ZXl0ZVZ2bnJlQ1Fmam1kMFh1?= =?utf-8?B?aTM2QlFpNzV3RHBodUFJcTJCVmE3MEI1Y2dCb1NUM2F2MXl6b0lQdEpjWDFJ?= =?utf-8?B?Q2tMclFFRW5OYzdFc29mcXpTQVRTZHQrZ04yem5PeFQxbTkrL0FmZlZBZWNk?= =?utf-8?B?cllGZWZxRkxLUXFpVHBuRlJEZ2RiUDQ4WnNUWWN5QXRJSWlpYjRnYzExS0gx?= =?utf-8?B?Nm4rRjVKNFFzclNwcW1BeDk4N2xLSHNralV4K2t5QUQ2SnVDcytzMHBIa0Vz?= =?utf-8?B?OWVVRW9FczRyelkwOE1tYjQ3L251ZENLMFlENXVCUS9IRmdHRFhuU0NCZkVH?= =?utf-8?B?eTJUVURuMjV2YnVITGlGdE52SFdKZ3hwcjUraTkzbk9IYkFYOXB0SkJtTlp2?= =?utf-8?B?MCt4bVcxZkFYS2c4MVBhMVI2RWN5RWNQM0U5UTRyWFcvUEtybG52UmZJR0do?= =?utf-8?B?bE9BNXZQUDFrRTEwaUdTek5pRms0bzBtelliVzcwc1NuRWV5L3czdXhzUWIw?= =?utf-8?B?cW4zUFE5RktnMm00S0d0T1N4Mkwwa2lVZUFDZ0o3ZlpXRThZamIwVldaL0NJ?= =?utf-8?B?N203SWRIbncydnVmUVJxeVRGZlJvcXdoZm1wRzE2blBNOEo3NTVZdlRCVVgy?= =?utf-8?B?NjJsa2V5VkwzWlBLUWhlZEtXQ2ROOGNDMFo5eXg4RnArQzA3OFBMaVJPbFFq?= =?utf-8?Q?6a6oikmQZwlzpj26AU?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53a18082-af24-4e07-d94c-08df0d54cb45 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2026 02:56:34.9450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r1/oAVdGIBZnEmvFucxy22m+HPnBjiPoDyjG9wZpwPel4Eu0JDQGcwNoMfUV0Z7w X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4435 f2fs sets its PAGE_PRIVATE_* flags in page->private and checking page->private != NULL is equivalent to checking PG_private. Change PagePrivate() to page_private(). Meanwhile, in set_page_private_##name(), page->private is first set to 0/NULL before an PAGE_PRIVATE_* flag is set, but it can cause confusion when PG_private is removed and page->private != NULL is used instead. Change it to initialize page->private to PAGE_PRIVATE_NOT_POINTER instead and retain the original semantics. It prepares for a future commit that removes PG_private. No functional change intended. Assisted-by: Claude:claude-opus-4-8 Assisted-by: Codex:gpt-5 To: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Acked-by: Usama Arif Acked-by: Chao Yu Signed-off-by: Zi Yan --- fs/f2fs/f2fs.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 9940a6cecf1a2..2f7ab5888b078 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -2691,7 +2691,7 @@ static inline bool folio_test_f2fs_##name(const struct folio *folio) \ } \ static inline bool page_private_##name(struct page *page) \ { \ - return PagePrivate(page) && \ + return page_private(page) && \ test_bit(PAGE_PRIVATE_NOT_POINTER, &page_private(page)) && \ test_bit(PAGE_PRIVATE_##flagname, &page_private(page)); \ } @@ -2710,9 +2710,9 @@ static inline void folio_set_f2fs_##name(struct folio *folio) \ } \ static inline void set_page_private_##name(struct page *page) \ { \ - if (!PagePrivate(page)) \ - attach_page_private(page, (void *)0); \ - set_bit(PAGE_PRIVATE_NOT_POINTER, &page_private(page)); \ + if (!page_private(page)) \ + attach_page_private(page, \ + (void *)BIT(PAGE_PRIVATE_NOT_POINTER)); \ set_bit(PAGE_PRIVATE_##flagname, &page_private(page)); \ } -- 2.53.0