From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F08D51E45B; Mon, 7 Sep 2026 17:15:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788801355; cv=none; b=B/1Hjxa2Gisko2PYctRYFBOvSMe+JBe8chzTlxafDbBdIYRBc4QElgA1NhfNV0BUU3smLDrgfB696daSvY8yAdt28FdCqkPacEkoWCvnbAodPdIDdqujrTE7FMdo9R83+fc78kBVG39YVhBC9CeFNIDHXDhfRd/ha0wj5L/1BlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788801355; c=relaxed/simple; bh=R6gktSXUxwaW/Wet8OPmXnwhUjUi8rMRwxy1wRY2W/U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DTBO6dtopchNeBlKkqWz+roxOca83Z7bxcksLi2dEzwD0K9ENY06umiRGT1CGNcHw96RkRCiGyusxvpBVMz8azwjXe8c7RbJTe3TLwopxEbb/sDcURAYpXAwYpmR01P8OREXlg7oQK/YBHkKrBcGj9hPdUq8u69J6QEKAcYRag0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HYUjqUgx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HYUjqUgx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2D101F00A3A; Mon, 7 Sep 2026 17:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788801354; bh=/6WNjLUgGSlgZ9oyOR9b9/1tR3h0n4d4XABzYhhKEbc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=HYUjqUgxsZNduYEdJK6kEyRDkUmSH0CzGCWxloPrQNGJcldXo86jD4NX8W1RPsL+y rpDVTeOdq8NYigSjfRmBSV8dqV3dnVlf4QPIAtWDjVzu+lWOtl2cb4JO3K/2OeM1T8 6MF1ngnqHCjxySS3BhD228/dRAjqw99brCpYOPuRLJD/FyXaxs/yB+i+m9RaIcH7jM Ctn5kO3n5gC5GgU/vvhGGEVlsP7EO5CbchhDYYq8bQvMQPdbr6tuzwutnllujKXAVG sv26HORiUm4FWMZmBNuHUYstNErf97ckz6PIC2rXalarg3OB0lIY3yHYM36OEAzovb 5Cm9gcRziiEFQ== Date: Mon, 7 Sep 2026 18:15:49 +0100 From: Conor Dooley To: Jelly Jia Cc: vkoul@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, Frank.Li@kernel.org, robin.murphy@arm.com, cix-kernel-upstream@cixtech.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/5] dt-bindings: dma: Add CIX Sky1 DMA-350 integration Message-ID: <20260907-retorted-unfasten-e985a6d4f26f@spud> References: <20260907033404.596839-1-Jelly.Jia@cixtech.com> <20260907033404.596839-4-Jelly.Jia@cixtech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pAQ/rgvGyemObrmX" Content-Disposition: inline In-Reply-To: <20260907033404.596839-4-Jelly.Jia@cixtech.com> --pAQ/rgvGyemObrmX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 07, 2026 at 11:34:02AM +0800, Jelly Jia wrote: > Document the CIX Sky1 integration wrapper around an Arm DMA-350 controlle= r. >=20 > The wrapper owns SoC integration resources. The child node describes the > generic Arm DMA-350 IP. >=20 > Signed-off-by: Jelly Jia > --- > .../bindings/dma/cix,sky1-dma350.yaml | 102 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 103 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/cix,sky1-dma350= =2Eyaml >=20 > diff --git a/Documentation/devicetree/bindings/dma/cix,sky1-dma350.yaml b= /Documentation/devicetree/bindings/dma/cix,sky1-dma350.yaml > new file mode 100644 > index 000000000000..e533f355d135 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/cix,sky1-dma350.yaml > @@ -0,0 +1,102 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/cix,sky1-dma350.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: CIX Sky1 DMA-350 Integration > + > +maintainers: > + - CIX Kernel Team > + > +description: > + The CIX Sky1 DMA-350 integration driver owns SoC resources around an > + Arm DMA-350 controller, such as clocks, resets, interrupt routing, and > + optional reserved memory. Reserved memory is described on this parent = node > + and assigned by the integration driver to the child DMA-350 device. Th= e child > + node describes the generic DMA-350 IP. I cannot really speak to whether this is a correct thing to do with a dma-350, but it seems to me like something that should be resolved with a device specific comaptible in the dma-350 node. Someone more familar with the IP will have to comment on that. However I would like to know how this impacts the existing dma-350 in he sky1 devicetree. > + > +properties: > + $nodename: > + pattern: "^dma@[0-9a-f]+$" > + > + compatible: > + const: cix,sky1-dma350 > + > + "#address-cells": > + const: 2 > + > + "#size-cells": > + const: 2 > + > + ranges: true > + > + dma-ranges: true > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + cix,irq-router: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Syscon phandle for the Sky1 subsystem register block that routes > + DMA-350 channel interrupts to the AP interrupt controller. > + > + memory-region: > + maxItems: 1 > + description: > + Reserved memory pool assigned by the CIX Sky1 DMA-350 integration = driver > + to the child Arm DMA-350 device. > + > +patternProperties: > + '^dma-controller@[0-9a-f]+$': > + $ref: arm,dma-350.yaml# > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + - ranges > + - dma-ranges > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + / { > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + interrupt-parent =3D <&gic>; > + > + gic: interrupt-controller { > + #address-cells =3D <0>; > + interrupt-controller; > + #interrupt-cells =3D <4>; > + }; > + > + dma@7010000 { > + compatible =3D "cix,sky1-dma350"; > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + ranges =3D <0x0 0x0 0x0 0x07010000 0x0 0x10000>; > + dma-ranges =3D <0x0 0x20000000 0x0 0x07010000 0x0 0x00100000= >; > + clocks =3D <&clk 9>; > + resets =3D <&rst 15>; > + cix,irq-router =3D <&audss_cru>; > + > + dma-controller@0 { > + compatible =3D "arm,dma-350"; > + reg =3D <0x0 0x0 0x0 0x10000>; > + interrupts =3D ; > + #dma-cells =3D <1>; > + }; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 3a19da74d00c..feff8f9ecb2b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2825,6 +2825,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated = for non-subscribers) > S: Maintained > T: git https://github.com/cixtech/linux-mainline.git > F: Documentation/devicetree/bindings/arm/cix.yaml > +F: Documentation/devicetree/bindings/dma/cix,sky1-dma350.yaml > F: Documentation/devicetree/bindings/mailbox/cix,sky1-mbox.yaml > F: arch/arm64/boot/dts/cix/ > F: drivers/mailbox/cix-mailbox.c > --=20 > 2.54.0 >=20 --pAQ/rgvGyemObrmX Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCap7xRQAKCRB4tDGHoIJi 0s8sAP0ShvS8XTkv9z2od3D9RTwQHw2GOsnTrHr2a6a4pSVQvAEAgfpEvw5+gWL+ 5eyH2n1reCdSt9+M661Y/Dq7KvGk3AI= =Mrbc -----END PGP SIGNATURE----- --pAQ/rgvGyemObrmX--