From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DC7148033F for ; Mon, 7 Sep 2026 11:28:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788780529; cv=none; b=TshN2eMIkApsAGbJWwN/nnJ/IatKThhwgBrW18MX0VFApL4u9KgeAcOca1orX957nfDj8YkH549tWg3uRd/6O1dNt7F/hheXv90V+gBbACbP6Phi7rrUSQ2HaK6oxKdV4XsbDwq4UWEYBcLJ748F2Qy6iqpwSKjxpLZxbAOqhz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788780529; c=relaxed/simple; bh=LaiGVpiakqZde4+FkOOw611byumGIZnyl3vENEg+LRM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CTm3UgOdV//IZSVJJw3LWwwY5t0EMJF214hz3XCW/rXp8nP1XM8GqVb8nOeBZnevARi08tlzIuYvckFvQkAV7S6S6AWadWOV+mF4DQzmm1nZwLFS8CF7vKE1JsnqRCDocF1sIeu6a9nMxnnLAKNMfdjIxuXwwrML0vxH28QH4O4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=h18REb8T; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="h18REb8T" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 94F5C2E9; Mon, 7 Sep 2026 13:26:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1788780419; bh=LaiGVpiakqZde4+FkOOw611byumGIZnyl3vENEg+LRM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=h18REb8Tsb2EYJs7T/DR1Unx9xAxKVGgBS+YBtnamJiVA5vow6tul82zIWUYm1vmE PFfimVk4d3C3wi0HxqlriGT+5G4h1WCGPaglGtjh9B4hx6fqqlEzUw50CcmdCWMKdj kjqP9GO2fa8027o6ZX0LFLk91eWV/8SLDHlxC0kE= From: Tomi Valkeinen Date: Mon, 07 Sep 2026 14:28:06 +0300 Subject: [PATCH v4 11/13] drm/bridge: tc358762: Drop drm_bridge_funcs.mode_set Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260907-tc358762-fixes-v4-11-e3fc3ab5cd83@ideasonboard.com> References: <20260907-tc358762-fixes-v4-0-e3fc3ab5cd83@ideasonboard.com> In-Reply-To: <20260907-tc358762-fixes-v4-0-e3fc3ab5cd83@ideasonboard.com> To: Marek Vasut , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tomi Valkeinen X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3085; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=LaiGVpiakqZde4+FkOOw611byumGIZnyl3vENEg+LRM=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBqnp/VAopH2tfY7Rh+Ikeuho8/i/UE/jTyJb9zw DHL5rpaInSJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCap6f1QAKCRD6PaqMvJYe 9fWBD/9U82FRgXDM0ZQwfUyspYb0G95t8PWfXDugGxaAKQjJpo2WMyJ5PXa2CKTwSvmyADd0oZf 7Jo9dFk+tHhDPP/fOQDVAqkUUZaFK/oSzjOV+S7HgUN6tivMmfLoQuBiWl9vsdeMHXawWh2GSka s7ilxXgvMcfKhn6HEMMnQBbt5PkDgf2nhVFcrjnJAwVdW9NaJqvttqNgQghQQ623EUUpoi2olPu x/L/eQkGK43ZpQtsbKK425MLPqsrfM5ENr0ZpGHEuIpESaPB9vttKF8kQDXL9unekn1tO6JT71L towhL47D7sl81TxHKLX3irszdsk4E9v7nG18tDB6S4XVOBUu6fi2/kpaSpe08BD/oJIL5aKS3tV gKb3tlPeUxrZwfFYH66D0ew7UDcLanbRmc8JBz0L72egpHII3KdIX8Rna3oAyyY+k5o5x9jM+d1 B+SZzBL9spR/PH0RxsYNDY+Gs9bKCF/Le4BLXNnkYQ1hz/R4Eg1z3QK6qj2ObrmmlscqGYnlaKL /QtqhTertSUj2sYNoDL5LLwkAi1h04eGqt2/abBC22AQ/ttHX0a4EXFaJFIv21PLR0Aa7OMh+B5 rymRpnvdNIjpeexoNSi1bZGEWNqqQ8aOns5/NefLuHoRQuMNUb1wWvyPTPeQcerT5womDIcK4CW uyFdnSycaeW6uwg== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 drm_bridge_funcs.mode_set is deprecated. Drop it and get the drm_display_mode from the atomic state. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358762.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c index ff7913441752..ad3a2620ce47 100644 --- a/drivers/gpu/drm/bridge/tc358762.c +++ b/drivers/gpu/drm/bridge/tc358762.c @@ -98,7 +98,6 @@ struct tc358762 { struct regulator *regulator; struct drm_bridge *panel_bridge; struct gpio_desc *reset_gpio; - struct drm_display_mode mode; bool pre_enabled; int error; bool use_vtg; @@ -186,9 +185,18 @@ static void tc358762_enable(struct drm_bridge *bridge, struct drm_atomic_commit *state) { struct tc358762 *ctx = bridge_to_tc358762(bridge); + struct drm_connector_state *conn_state; + struct drm_crtc_state *crtc_state; + struct drm_connector *connector; + struct drm_display_mode *mode; u32 lcdctrl; int ret; + connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder); + conn_state = drm_atomic_get_new_connector_state(state, connector); + crtc_state = drm_atomic_get_new_crtc_state(state, conn_state->crtc); + mode = &crtc_state->mode; + /* * DPIENABLE has reset default of 1. Make sure we don't output on * DPI until we have finished the coniguration. @@ -213,7 +221,7 @@ static void tc358762_enable(struct drm_bridge *bridge, if (ctx->use_vtg) { struct videomode vm = { 0 }; - drm_display_mode_to_videomode(&ctx->mode, &vm); + drm_display_mode_to_videomode(mode, &vm); tc358762_write(ctx, LCDC_HSR_HBPR, vm.hsync_len | (vm.hback_porch << 16)); @@ -237,10 +245,10 @@ static void tc358762_enable(struct drm_bridge *bridge, lcdctrl |= LCDCTRL_DCLK_POL; - if (ctx->mode.flags & DRM_MODE_FLAG_PHSYNC) + if (mode->flags & DRM_MODE_FLAG_PHSYNC) lcdctrl |= LCDCTRL_HSYNC_POL; - if (ctx->mode.flags & DRM_MODE_FLAG_PVSYNC) + if (mode->flags & DRM_MODE_FLAG_PVSYNC) lcdctrl |= LCDCTRL_VSYNC_POL; tc358762_write(ctx, LCDCTRL, lcdctrl); @@ -265,15 +273,6 @@ static int tc358762_attach(struct drm_bridge *bridge, bridge, flags); } -static void tc358762_bridge_mode_set(struct drm_bridge *bridge, - const struct drm_display_mode *mode, - const struct drm_display_mode *adj) -{ - struct tc358762 *ctx = bridge_to_tc358762(bridge); - - drm_mode_copy(&ctx->mode, mode); -} - static const struct drm_bridge_funcs tc358762_bridge_funcs = { .atomic_post_disable = tc358762_post_disable, .atomic_pre_enable = tc358762_pre_enable, @@ -282,7 +281,6 @@ static const struct drm_bridge_funcs tc358762_bridge_funcs = { .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, .atomic_reset = drm_atomic_helper_bridge_reset, .attach = tc358762_attach, - .mode_set = tc358762_bridge_mode_set, }; static int tc358762_parse_dt(struct tc358762 *ctx) -- 2.43.0