mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Catalin Cereanu <catalin.cereanu@cs.upt.ro>
To: Corentin Chary <corentin.chary@gmail.com>,
	"Luke D . Jones" <luke@ljones.dev>,
	Denis Benato <denis.benato@linux.dev>
Cc: "Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] platform/x86: asus-wmi: no kbd backlight on Zenbook S 16 UM5606WA
Date: Mon,  7 Sep 2026 03:06:31 +0300	[thread overview]
Message-ID: <20260907000631.18373-1-catalin.cereanu@cs.upt.ro> (raw)
In-Reply-To: <20260906235355.13404-1-catalin.cereanu@cs.upt.ro>

Following up on my own RFC: after sending it I came across prior art for
the first of the three questions I raised, which makes that part much
less open-ended than I posed it.

The FA401 series has the same shape of problem with a different device -
WMI device 0x00100057 is not reported by DSTS even though the EC does
support it - and that was handled with a DMI quirk ORing a quirk_entry
flag into the availability test rather than trusting the probe:

  https://lore.kernel.org/platform-driver-x86/20260902174718.16228-1-idotohors@gmail.com/

If the same approach is acceptable for the keyboard backlight here, the
equivalent would match DMI_SYS_VENDOR "ASUSTeK COMPUTER INC." and
DMI_BOARD_NAME "UM5606WA", and do roughly:

    static struct quirk_entry quirk_asus_um5606wa = {
            .kbd_backlight_available = true,
    };

with, in asus_wmi_led_init():

    asus->kbd_led_avail = !kbd_led_read(asus, &led_val, NULL) ||
                          asus->driver->quirks->kbd_backlight_available;

That would restore sysfs brightness control, since the DEVS setter at
0x00050021 works regardless of what DSTS reports.

It would not restore the Fn+F4 key, which stays gated on KBLC in
firmware, so questions 2 and 3 in the original mail still stand as
written.

Happy to send this as a proper patch if the shape looks right.

Thanks,
Catalin Cereanu

      reply	other threads:[~2026-09-07  0:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-06 23:53 Catalin Cereanu
2026-09-07  0:06 ` Catalin Cereanu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907000631.18373-1-catalin.cereanu@cs.upt.ro \
    --to=catalin.cereanu@cs.upt.ro \
    --cc=corentin.chary@gmail.com \
    --cc=denis.benato@linux.dev \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®