From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C69683AE194 for ; Mon, 7 Sep 2026 06:28:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788762522; cv=none; b=pdUyk2lIGWtfwzPscLfsQndbogBCymB4Tv37U79XZc3jM2LVTkJ2y7LhifJA3qjXQfasLVMOrWLhZOQVhLRwUksTNh8RlRZa5ztLO0vxCDRtOylphPhV/G0AjYqug7n5aSlAxhh86yNtYCmuBNBHibhMrGwy+nXwdklHDCgGRtQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788762522; c=relaxed/simple; bh=HQVLVPzjRG5hh8fZIGmX/p3UNdpvdNQwjepL5vkjQ24=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h2RGmMisDxxOjmzMeUMvMVrGihoc48iV2sSKhK4BnskGlg8FWXmAZLb9RGN7Mi+b6OtsQMNnJTrjF7bk34crU5wSj2rm+WLAmq23zYyH7ePwynXWNlbsOfjstZ8zKNzQSU1RQ+zMZpkBhq7RbwNhMgVvfFkQ0ZXfOI4zeMRlk38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RwrocECK; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RwrocECK" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-39647184c73so3809167a91.1 for ; Sun, 06 Sep 2026 23:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788762518; x=1789367318; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=M1wSKmw/x+Nhq5u1uQ+7oGEZmPqsD7MFhh/OKQ0EiNE=; b=RwrocECK6AEI5KhukKMsJQCOLIy9i1qVT7yV9iYiUpxeg3xQhhEGodkJ7Yw8Mp6q14 CzMOm6253xf0zLwIUAhHIy9rX9n4AsC8hY8LmIail2CCwU5LkWCmATG9enClviPymLjb VElL718wfIcogc4u8XH6tfbN4dRGwxAd0v5UadYglREbGEcmeP9qw3/fivdnJ9vqctEG rwjL3rLMRxDGidXib13Fgkwc8zNEWTqIoKxB2eoIGGeJVEOoGFDJTi1aEWsA21Olx61E 1oRVvZLO4z5xF6fraLmQ6SyxNDJTsfTPBG9vQ8O70xoHuoaHp6w2OdzZwRzV3erX9mBy 0uZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788762518; x=1789367318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=M1wSKmw/x+Nhq5u1uQ+7oGEZmPqsD7MFhh/OKQ0EiNE=; b=VzqPjJ8MhaDbexItlCo8mSPld+55PAMO3TeHyxP14I8KidshzqdLB0zVHGyUuvOK4D 6SUxqAtrXKx66fDlqRF62ewVd0PwjxwDNBFsbq6NL0QNTSTlRh3Z2OGdLza+e6JLrn7L DwqamOqUn/PkaAw7SuSd9LJIdJGd8HKR/Ysjt8zu+YzMgK3iopiH1xautfYl1j9DMV/4 x7N+oQe3ve7+xatcqUEhsOOtBejoR4xW02lKZar9IAk/EArycC+u/ZAgdJfk/D8SCBLf bApooxdPEMWnggkTlanTv0d6kT4+XmRKPWY3NU63plWWnyP1uj9IAUOY0sSSshdqv3/q Y3RA== X-Forwarded-Encrypted: i=1; AKwUvBzTQplooHU8OhIOdDzQK+4wiS5e6gqf+j45KmmiOsazwZEkN/SbZerUF1GvBCm5ACPY5LmMZym3HJXKaQw=@vger.kernel.org X-Gm-Message-State: AFuF++kKSbl0vfkv1LaaMQb1teSOPUVU0jkZ4N96MiBh+Kg10td8xdIM +XQTCK9unMro+LQCzvI5KIX/02xn6eq1N54yzmtsLjtuKoAE9lZaUynKMabTUnhwOIwPbg== X-Gm-Gg: AYBFou1zHrzQ4geTJ0BvkgpZGueRJBzFkz3nS0jtBn80PHi02LjOKhp6/iN/T9egjh9 07KiUlCpf2Zx2H6ngKplq/HaA4YCHwnkGIJDJFKSBZn5ciYORtzP0YiYKPU3om8fwrm9mQhxtPI AP7giTUYMBIG8V8e5qKQ968uSC7Iq13RnRk+5ZtyuNCNpfqZ23l7vHEngtpezj0cE0qwGjUIvAa qKalYy5irgpuxuTMsYxOpNRYoMO/FslmZaaPXmRKGzrYfRn1Ml5EsovClmjXklTbxta+E7gu+6a O80ULE+m3g+eekAyVUnNX/6VaN7qndM09+Hv2hI+OvpEaqfq9havYTsU9xloPc0LzNl8w9ZneHL 6b3MeY9SeQVgDJgaze+PPhI0lhSIFMU2ByplP7RsnVetCWuuS/dkGssDs02IZTKSVX+SYUrY46t MExas59gpzKuOE+d5h58UnMy+6ZosYbptv4GKTu45Km7wh8NQ9EOqdWYu7XdKyY53J3eik8Y1tX c7jXVuMSsxQgLToH1KRD7U7ooncfUxSiPoeV5O79yThQO8RVrFNO0nHNKMdMelminG6DxcL/USE wLg2O14= X-Received: by 2002:a17:90b:2ccd:b0:398:baa7:4c2f with SMTP id 98e67ed59e1d1-39b27c442f8mr16725731a91.5.1788762517830; Sun, 06 Sep 2026 23:28:37 -0700 (PDT) Received: from LAPTOP-UUUVNN1I.localdomain ([129.126.57.197]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b25c974cfsm18978042a91.0.2026.09.06.23.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Sep 2026 23:28:37 -0700 (PDT) From: Wei Jie Law <98lawweijie@gmail.com> To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab Cc: Guennadi Liakhovetski , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 1/2] media: uvcvideo: Fix NULL deref on events for uninitialized controls Date: Mon, 7 Sep 2026 14:28:17 +0800 Message-ID: <20260907062819.2519878-2-98lawweijie@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260907062819.2519878-1-98lawweijie@gmail.com> References: <20260907062819.2519878-1-98lawweijie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A null-ptr-deref exists in v6.12.105 and upstream. KASAN crash log: KASAN: null-ptr-deref in range [0x0000000000000080-0x0000000000000087] Workqueue: events uvc_ctrl_status_event_work RIP: 0010:uvc_ctrl_status_event+0x105/0x280 uvc_ctrl_status_event_work+0x82/0x240 process_one_work+0x66f/0x10b0 XU controls are initialized lazily, on the first UVCIOC_CTRL_MAP or UVCIOC_CTRL_QUERY. Until then ctrl->info is all zeroes, so info.mappings is not a valid list head, list_empty() returns false, and uvc_ctrl_status_event() walks it from a NULL next pointer. Fixes: e5225c820c05 ("media: uvcvideo: Send a control event when a Control Change interrupt arrives") Cc: stable@vger.kernel.org Signed-off-by: Wei Jie Law <98lawweijie@gmail.com> Assisted-by: Claude:claude-opus-5 --- drivers/media/usb/uvc/uvc_ctrl.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index 3ca108b83f1d..21802f9b1b61 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -2209,7 +2209,12 @@ bool uvc_ctrl_status_event_async(struct urb *urb, struct uvc_video_chain *chain, struct uvc_device *dev = chain->dev; struct uvc_ctrl_work *w = &dev->async_ctrl; - if (list_empty(&ctrl->info.mappings)) + /* + * An uninitialized control has a zeroed info struct, so its + * mappings list head is not a list: list_empty() returns false + * and the walk dereferences NULL. + */ + if (!ctrl->initialized || list_empty(&ctrl->info.mappings)) return false; w->data = data; -- 2.43.0