From: Herve Codina <herve.codina@bootlin.com>
To: Qingshuang Fu <fuqingshuang@kylinos.cn>
Cc: Thomas Gleixner <tglx@kernel.org>, Radu Rendec <radu@rendec.net>,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] soc/fsl/qe: qe_ports_ic: Drop redundant IRQ_DOMAIN_FLAG_DESTROY_GC
Date: Mon, 7 Sep 2026 08:48:15 +0200 [thread overview]
Message-ID: <20260907084815.2e853d74@bootlin.com> (raw)
In-Reply-To: <20260907024046.28845-4-fuqingshuang@kylinos.cn>
Hi Qingshuang,
On Mon, 7 Sep 2026 10:40:46 +0800
Qingshuang Fu <fuqingshuang@kylinos.cn> wrote:
> Now that __irq_domain_instantiate() automatically sets
> IRQ_DOMAIN_FLAG_DESTROY_GC when dgc_info is provided, the explicit
> flag in the irq_domain_info is redundant. Remove it.
>
> Signed-off-by: Qingshuang Fu <fuqingshuang@kylinos.cn>
> ---
> drivers/soc/fsl/qe/qe_ports_ic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/qe/qe_ports_ic.c b/drivers/soc/fsl/qe/qe_ports_ic.c
> index 7375f92f528b..fb3b92039547 100644
> --- a/drivers/soc/fsl/qe/qe_ports_ic.c
> +++ b/drivers/soc/fsl/qe/qe_ports_ic.c
> @@ -140,7 +140,6 @@ static int qepic_probe(struct platform_device *pdev)
> };
> struct irq_domain_info d_info = {
> .fwnode = of_fwnode_handle(pdev->dev.of_node),
> - .domain_flags = IRQ_DOMAIN_FLAG_DESTROY_GC,
> .size = 32,
> .hwirq_max = 32,
> .ops = &irq_generic_chip_ops,
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
next prev parent reply other threads:[~2026-09-07 6:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 2:40 [PATCH v3 0/3] irqdomain: Auto-set IRQ_DOMAIN_FLAG_DESTROY_GC and remove redundant flag from drivers Qingshuang Fu
2026-09-07 2:40 ` [PATCH v3 1/3] irqdomain: Set IRQ_DOMAIN_FLAG_DESTROY_GC in __irq_domain_instantiate() Qingshuang Fu
2026-09-07 6:46 ` Herve Codina
2026-09-07 19:51 ` [tip: irq/drivers] " tip-bot2 for Qingshuang Fu
2026-09-07 2:40 ` [PATCH v3 2/3] irqchip/lan966x-oic: Drop redundant IRQ_DOMAIN_FLAG_DESTROY_GC Qingshuang Fu
2026-09-07 6:47 ` Herve Codina
2026-09-07 19:51 ` [tip: irq/drivers] " tip-bot2 for Qingshuang Fu
2026-09-07 2:40 ` [PATCH v3 3/3] soc/fsl/qe: qe_ports_ic: " Qingshuang Fu
2026-09-07 6:48 ` Herve Codina [this message]
2026-09-07 19:51 ` [tip: irq/drivers] " tip-bot2 for Qingshuang Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907084815.2e853d74@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=apw@canonical.com \
--cc=fuqingshuang@kylinos.cn \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=radu@rendec.net \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®